Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qEACs-0005yd-4I for pgsql-hackers@arkaria.postgresql.org; Tue, 27 Jun 2023 15:02:14 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1qEACr-0006IZ-0c for pgsql-hackers@arkaria.postgresql.org; Tue, 27 Jun 2023 15:02:13 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qEACq-0006IQ-N9 for pgsql-hackers@lists.postgresql.org; Tue, 27 Jun 2023 15:02:12 +0000 Received: from mail-oa1-x32.google.com ([2001:4860:4864:20::32]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1qEACn-000knP-FF for pgsql-hackers@postgresql.org; Tue, 27 Jun 2023 15:02:11 +0000 Received: by mail-oa1-x32.google.com with SMTP id 586e51a60fabf-19a427d7b57so3083024fac.2 for ; Tue, 27 Jun 2023 08:02:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neon-tech.20221208.gappssmtp.com; s=20221208; t=1687878128; x=1690470128; h=message-id:from:to:subject:date:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=/fm8pDxEGW2xm9mZ0qQq+FSVouqsKZrmW6HOiHMPlIw=; b=xR9ujAdKHaIl+wmXwvWuqGIJ+d+WcHbUkk5QLaTUS8KPsGhInS6EkfZegAPyvujMXg ovFkp9QFf/4rJOPRB43m5azeyG9U7M0LN+l4OCHSgTUeNL0TCq10bs0doj4BPE/HsObF 9e/xOgQURezUI9TRojc5aZw0PQmgXUtdZ4TYJDX8nEGkzeoYl6ZPgwjSz6P24TmTL0b2 QP5/MiPltnZuU4PPTPsdlGEpWFb1m7C/lH49lKieWNNMo47Qe4u5tpa5XcdJOQfDpm2E AZcEjpTGzQG0E6zHu3jDv4ilYkpvCyMvWPBHtdOFa/SOId5tSXW8ESRwJzraV7+N/+s3 0S5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687878128; x=1690470128; h=message-id:from:to:subject:date:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=/fm8pDxEGW2xm9mZ0qQq+FSVouqsKZrmW6HOiHMPlIw=; b=cV4dsmTnn+YQj6PujNk1Yvp5N2VH2+Vmq2poZ1aZyaIXz0teOFjicoTi9peKa5M4YN a74WVRFt6C+NbOxLJpdOjBKQIhps8mbyx+xZFR+RymUSbctK829eN1mIIKgBn/UurQrx Zuow2bdEjQ3JZAQOIMD4tIVu9LaX1uKUGFC1HHDmpP8t2FUhR7pe0LSAvrqe2tOWdSLF sYeJFuLGVUA0AZj9eDNsroREEsDa/CAlCjJEWOkUnJPasF3qSV67Wl/uk4KAEECfSQnL vJMhmy0QMBuzMPfSj6ryA3YT9anNgcf0e8qY39ZFIoQaMaZEmCpqUAsL+JW54Q+0AKyv LapA== X-Gm-Message-State: AC+VfDxlAcEsFVcpyHICEurrj0y5TybwLS9lNebUfRFZuDiGzsp69xYz E8wq/yAulvoqMRBllwe+G7Jr50kdjlOwnQ+GWdV2bg== X-Google-Smtp-Source: ACHHUZ4011EGCjJsMUmGTHshcoK/I0Sb/wJpqaG6UH+n8NwVOdXAlJ0U2KFZ0OIfPpzTyaGBu0ZelA== X-Received: by 2002:a05:6870:a4c1:b0:19f:add7:2cd4 with SMTP id k1-20020a056870a4c100b0019fadd72cd4mr22688850oal.32.1687878126765; Tue, 27 Jun 2023 08:02:06 -0700 (PDT) Received: from localhost ([2607:fb90:e62b:4f29:3996:e070:71ee:42fb]) by smtp.gmail.com with ESMTPSA id en41-20020a05687007a900b001a9eb707366sm5135780oab.15.2023.06.27.08.02.05 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Jun 2023 08:02:06 -0700 (PDT) Content-Type: multipart/mixed; boundary=e47f00eb15d435c8f2ae4ba500c9c5a559965c0f90ee113533324cc8f5ac Mime-Version: 1.0 Date: Tue, 27 Jun 2023 10:02:05 -0500 Subject: Make uselocale protection more consistent To: From: "Tristan Partin" Message-Id: X-Mailer: aerc 0.15.2-74-gdfabb5232875 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --e47f00eb15d435c8f2ae4ba500c9c5a559965c0f90ee113533324cc8f5ac Content-Type: multipart/alternative; boundary=6d69508d9ed0d9162c1b29b4f2c9104e087f537867f8d95618b8b6ca7244 --6d69508d9ed0d9162c1b29b4f2c9104e087f537867f8d95618b8b6ca7244 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Content-Type: text/plain; charset=UTF-8 This is a patch which implements an issue discussed in bug #17946[0]. It doesn't fix the overarching issue of the bug, but merely a consistency issue which was found while analyzing code by Heikki. I had originally submitted the patch within that thread, but for visibility and the purposes of the commitfest, I have re-sent it in its own thread. [0]: https://www.postgresql.org/message-id/49dfcad8-90fa-8577-008f-d142e61a= f46b@iki.fi --=20 Tristan Partin Neon (https://neon.tech) --6d69508d9ed0d9162c1b29b4f2c9104e087f537867f8d95618b8b6ca7244-- --e47f00eb15d435c8f2ae4ba500c9c5a559965c0f90ee113533324cc8f5ac Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=v1-0001-Make-uselocale-protection-more-consistent.patch Content-Type: text/x-patch; charset=utf-8; name=v1-0001-Make-uselocale-protection-more-consistent.patch RnJvbSAwMmEyY2RiODM0MDViNWFlY2FlYzJhZjAyZTM3OWE4MTE2MWY4MzcyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUcmlzdGFuIFBhcnRpbiA8dHJpc3RhbkBuZW9uLnRlY2g+CkRh dGU6IFdlZCwgMTQgSnVuIDIwMjMgMTE6MzY6MDAgLTA1MDAKU3ViamVjdDogW1BBVENIIHYxXSBN YWtlIHVzZWxvY2FsZSBwcm90ZWN0aW9uIG1vcmUgY29uc2lzdGVudAoKSW4gZWNwZywgdXNlbG9j YWxlIHVzZXMgYXJlIHByb3RlY3RlZCBieSBjaGVja2luZyBpZiBIQVZFX1VTRUxPQ0FMRSBpcwpk ZWZpbmVkLiBVc2UgdGhlIHNhbWUgY2hlY2sgaW4gcGdfbG9jYWxlLmMuIFNpbmNlIEhBVkVfVVNF TE9DQUxFIGltcGxpZXMKSEFWRV9MT0NBTEVfVCwgdGhlIGNvZGUgc2hvdWxkIGJlIHRoZSBzYW1l IG9uIF9hbGxfIHBsYXRmb3JtcyB0aGF0ClBvc3RncmVzIHN1cHBvcnRzLiBPdGhlcndpc2UsIEkg YW0gc3VyZSB0aGVyZSB3b3VsZCBoYXZlIGJlZW4gYSBidWcKcmVwb3J0IHdpdGggcGdfbG9jYWxl LmMgZmFpbGluZyB0byBidWlsZCBkdWUgdG8gdGhlIHN5c3RlbSBoYXZpbmcKbG9jYWxlX3QsIGJ1 dCBub3QgdXNlbG9jYWxlLgotLS0KIHNyYy9iYWNrZW5kL3V0aWxzL2FkdC9wZ19sb2NhbGUuYyB8 IDE2ICsrKysrKysrLS0tLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCA4IGluc2VydGlvbnMoKyksIDgg ZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvc3JjL2JhY2tlbmQvdXRpbHMvYWR0L3BnX2xvY2Fs ZS5jIGIvc3JjL2JhY2tlbmQvdXRpbHMvYWR0L3BnX2xvY2FsZS5jCmluZGV4IDMxZTNiMTZhZTAu LjM1ODVhZmIyOTggMTAwNjQ0Ci0tLSBhL3NyYy9iYWNrZW5kL3V0aWxzL2FkdC9wZ19sb2NhbGUu YworKysgYi9zcmMvYmFja2VuZC91dGlscy9hZHQvcGdfbG9jYWxlLmMKQEAgLTI5NzIsNyArMjk3 Miw3IEBAIHdjaGFyMmNoYXIoY2hhciAqdG8sIGNvbnN0IHdjaGFyX3QgKmZyb20sIHNpemVfdCB0 b2xlbiwgcGdfbG9jYWxlX3QgbG9jYWxlKQogCX0KIAllbHNlCiAJewotI2lmZGVmIEhBVkVfTE9D QUxFX1QKKyNpZmRlZiBIQVZFX1VTRUxPQ0FMRQogI2lmZGVmIEhBVkVfV0NTVE9NQlNfTAogCQkv KiBVc2Ugd2NzdG9tYnNfbCBmb3Igbm9uZGVmYXVsdCBsb2NhbGVzICovCiAJCXJlc3VsdCA9IHdj c3RvbWJzX2wodG8sIGZyb20sIHRvbGVuLCBsb2NhbGUtPmluZm8ubHQpOwpAQCAtMjk4NCwxMSAr Mjk4NCwxMSBAQCB3Y2hhcjJjaGFyKGNoYXIgKnRvLCBjb25zdCB3Y2hhcl90ICpmcm9tLCBzaXpl X3QgdG9sZW4sIHBnX2xvY2FsZV90IGxvY2FsZSkKIAogCQl1c2Vsb2NhbGUoc2F2ZV9sb2NhbGUp OwogI2VuZGlmCQkJCQkJCS8qIEhBVkVfV0NTVE9NQlNfTCAqLwotI2Vsc2UJCQkJCQkJLyogIUhB VkVfTE9DQUxFX1QgKi8KLQkJLyogQ2FuJ3QgaGF2ZSBsb2NhbGUgIT0gMCB3aXRob3V0IEhBVkVf TE9DQUxFX1QgKi8KKyNlbHNlCQkJCQkJCS8qICFIQVZFX1VTRUxPQ0FMRSAqLworCQkvKiBDYW4n dCBoYXZlIGxvY2FsZSAhPSAwIHdpdGhvdXQgSEFWRV9MT0NBTEVfVCwgd2hpY2ggSEFWRV9VU0VM T0NBTEUgaW1wbGllcyAqLwogCQllbG9nKEVSUk9SLCAid2NzdG9tYnNfbCBpcyBub3QgYXZhaWxh YmxlIik7CiAJCXJlc3VsdCA9IDA7CQkJCS8qIGtlZXAgY29tcGlsZXIgcXVpZXQgKi8KLSNlbmRp ZgkJCQkJCQkvKiBIQVZFX0xPQ0FMRV9UICovCisjZW5kaWYJCQkJCQkJLyogSEFWRV9VU0VMT0NB TEUgKi8KIAl9CiAKIAlyZXR1cm4gcmVzdWx0OwpAQCAtMzA0OSw3ICszMDQ5LDcgQEAgY2hhcjJ3 Y2hhcih3Y2hhcl90ICp0bywgc2l6ZV90IHRvbGVuLCBjb25zdCBjaGFyICpmcm9tLCBzaXplX3Qg ZnJvbWxlbiwKIAkJfQogCQllbHNlCiAJCXsKLSNpZmRlZiBIQVZFX0xPQ0FMRV9UCisjaWZkZWYg SEFWRV9VU0VMT0NBTEUKICNpZmRlZiBIQVZFX01CU1RPV0NTX0wKIAkJCS8qIFVzZSBtYnN0b3dj c19sIGZvciBub25kZWZhdWx0IGxvY2FsZXMgKi8KIAkJCXJlc3VsdCA9IG1ic3Rvd2NzX2wodG8s IHN0ciwgdG9sZW4sIGxvY2FsZS0+aW5mby5sdCk7CkBAIC0zMDYxLDExICszMDYxLDExIEBAIGNo YXIyd2NoYXIod2NoYXJfdCAqdG8sIHNpemVfdCB0b2xlbiwgY29uc3QgY2hhciAqZnJvbSwgc2l6 ZV90IGZyb21sZW4sCiAKIAkJCXVzZWxvY2FsZShzYXZlX2xvY2FsZSk7CiAjZW5kaWYJCQkJCQkJ LyogSEFWRV9NQlNUT1dDU19MICovCi0jZWxzZQkJCQkJCQkvKiAhSEFWRV9MT0NBTEVfVCAqLwot CQkJLyogQ2FuJ3QgaGF2ZSBsb2NhbGUgIT0gMCB3aXRob3V0IEhBVkVfTE9DQUxFX1QgKi8KKyNl bHNlCQkJCQkJCS8qICFIQVZFX1VTRUxPQ0FMRSAqLworCQkJLyogQ2FuJ3QgaGF2ZSBsb2NhbGUg IT0gMCB3aXRob3V0IEhBVkVfTE9DQUxFX1QsIHdoaWNoIEhBVkVfVVNFTE9DQUxFIGltcGxpZXMg Ki8KIAkJCWVsb2coRVJST1IsICJtYnN0b3djc19sIGlzIG5vdCBhdmFpbGFibGUiKTsKIAkJCXJl c3VsdCA9IDA7CQkJLyoga2VlcCBjb21waWxlciBxdWlldCAqLwotI2VuZGlmCQkJCQkJCS8qIEhB VkVfTE9DQUxFX1QgKi8KKyNlbmRpZgkJCQkJCQkvKiBIQVZFX1VTRUxPQ0FMRSAqLwogCQl9CiAK IAkJcGZyZWUoc3RyKTsKLS0gClRyaXN0YW4gUGFydGluCk5lb24gKGh0dHBzOi8vbmVvbi50ZWNo KQoK --e47f00eb15d435c8f2ae4ba500c9c5a559965c0f90ee113533324cc8f5ac--