Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Thu, 29 Jun 2023 14:03:19 -0500
Cc: "Peter Eisentraut" <peter@eisentraut.org>,
 <pgsql-hackers@postgresql.org>
Subject: Re: Meson build updates
To: "Andres Freund" <andres@anarazel.de>
From: "Tristan Partin" <tristan@neon.tech>
Message-Id: <CTPD8PV6RZUH.3RZ3WTADPD8DA@gonk>
References: <20230612172038.f2xf2cwlnhjldqng@awork3.anarazel.de>
 <CTAW8GBWEJ7F.129Y59WDVDNMW@gonk>
 <277c356e-7ef7-4c87-f4b2-97a13914dd02@eisentraut.org>
 <CTB00342PAX7.36RK20RD57EUH@gonk> <CTBSP2GSV4IO.2J7QXVJBTI359@gonk>
 <CTBSPHEFKSTA.3H4L369UPLIRZ@gonk> <CTBTF7D3NT2N.2KVYEWW9NCHY0@gonk>
 <fc86a216-4827-be14-2468-7309ea189f67@eisentraut.org>
 <20230629173532.cdcydvqf3x5j7524@awork3.anarazel.de>
 <CTPCMQ52DU6N.RYKQDQ2ZQ1YQ@gonk>
 <20230629185845.mrtzkwkwporfmdbn@awork3.anarazel.de>
In-Reply-To: <20230629185845.mrtzkwkwporfmdbn@awork3.anarazel.de>
Archived-At: 
 <https://www.postgresql.org/message-id/CTPD8PV6RZUH.3RZ3WTADPD8DA%40gonk>
Precedence: bulk

On Thu Jun 29, 2023 at 1:58 PM CDT, Andres Freund wrote:
> Hi,
>
> On 2023-06-29 13:34:42 -0500, Tristan Partin wrote:
> > On Thu Jun 29, 2023 at 12:35 PM CDT, Andres Freund wrote:
> > > > v5-0012-Make-finding-pkg-config-python3-more-robust.patch
> > >
> > > The commit message here is clearly outdated (still talking about Pyth=
on.h
> > > check not being required).  Does the remainder actually add any robus=
tness?
> > >
> > > I'm on board with removing unnecessary .enabled(), but from what I un=
derstand
> > > we don't gain anything from adding the if python3_inst.found() branch=
?
> >=20
> > Attached is a more up to date patch, which removes the old part of the
> > commit message. I guess robust is in the eye of the beholder. It is
> > definitely possible for the installation to not be found (Python.h not
> > existing in newer versions of Meson as an example). All my patch would
> > do is keep the build from crashing if and only if the installation
> > wasn't found.
>
> Ah - I somehow thought .find_installation().dependency() would return a
> not-found dependency when the install wasn't located.

Inspecting the Meson source code... If find_installation() fails, you
get returned a NonExistingExternalProgram, which doesn't implement
dependency()[0].

> > > Attached my version of 0007 and 0011 (with some changes from 0012 and
> > > 0015). I'm running a test of those with the extended CI I have in a b=
ranch...
> >=20
> > Thanks for the further review. Did you by chance see my other email in
> > another branch of this thread[0]?
> >=20
> > [0]: https://www.postgresql.org/message-id/CTBSCT2V1TVP.2AUJVJLNWQVG3@g=
onk
>
> I had planned to, but somehow forgot. Will reply.

Thanks!

[0]: https://github.com/mesonbuild/meson/blob/master/mesonbuild/programs.py=
#L333

--=20
Tristan Partin
Neon (https://neon.tech)