Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Mon, 03 Jul 2023 08:21:50 -0500
Message-Id: <CTSKHGN8BPUK.14RF8P15GN4ZM@gonk>
Cc: <pgsql-hackers@postgresql.org>
Subject: Re: Make uselocale protection more consistent
To: "Thomas Munro" <thomas.munro@gmail.com>, "Peter Eisentraut"
 <peter@eisentraut.org>
From: "Tristan Partin" <tristan@neon.tech>
References: <CTNITWIN1G6L.CFIPH8SYNQQW@gonk>
 <fe6fafd1-8bf3-9307-b1d0-e5074722452a@eisentraut.org>
 <CA+hUKGKkfh3wSC-J2eXd4kb499MCJZCCyiL61-mk641uzTBBAA@mail.gmail.com>
In-Reply-To: <CA+hUKGKkfh3wSC-J2eXd4kb499MCJZCCyiL61-mk641uzTBBAA@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/CTSKHGN8BPUK.14RF8P15GN4ZM%40gonk>
Precedence: bulk

On Mon Jul 3, 2023 at 1:24 AM CDT, Thomas Munro wrote:
> On Mon, Jul 3, 2023 at 6:13=E2=80=AFPM Peter Eisentraut <peter@eisentraut=
.org> wrote:
> > On 27.06.23 17:02, Tristan Partin wrote:
> > > This is a patch which implements an issue discussed in bug #17946[0].=
 It
> > > doesn't fix the overarching issue of the bug, but merely a consistenc=
y
> > > issue which was found while analyzing code by Heikki. I had originall=
y
> > > submitted the patch within that thread, but for visibility and the
> > > purposes of the commitfest, I have re-sent it in its own thread.
> > >
> > > [0]: https://www.postgresql.org/message-id/49dfcad8-90fa-8577-008f-d1=
42e61af46b@iki.fi
> >
> > I notice that HAVE_USELOCALE was introduced much later than
> > HAVE_LOCALE_T, and at the time the code was already using uselocale(),
> > so perhaps the introduction of HAVE_USELOCALE was unnecessary and shoul=
d
> > be reverted.
> >
> > I think it would be better to keep HAVE_LOCALE_T as encompassing any of
> > the various locale_t-using functions, rather than using HAVE_USELOCALE
> > as a proxy for them.  Otherwise you create weird situations like having
> > #ifdef HAVE_WCSTOMBS_L inside #ifdef HAVE_USELOCALE, which doesn't make
> > sense, I think.
>
> I propose[1] that we get rid of HAVE_LOCALE_T completely and make
> "libc" provider support unconditional.  It's standardised, and every
> target system has it, even Windows.  But Windows doesn't have
> uselocale().
>
> [1] https://www.postgresql.org/message-id/flat/CA%2BhUKGL7CmmzeRhoirzjECm=
OdABVFTn8fo6gEOaFRF1Oxey6Hw%40mail.gmail.com#aef2f2274b28ff8a36f9b8a598e3ce=
c0

I think keeping HAVE_USELOCALE is important for the Windows case as
mentioned. I need it for my localization work where I am ripping out
setlocale() on non-Windows.

--=20
Tristan Partin
Neon (https://neon.tech)