Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Thu, 06 Jul 2023 08:41:50 -0500
Message-Id: <CTV4SEUNM92R.2OM4SN8LB7CQN@gonk>
From: "Tristan Partin" <tristan@neon.tech>
Subject: Re: Fix last unitialized memory warning
To: "Peter Eisentraut" <peter@eisentraut.org>,
 <pgsql-hackers@postgresql.org>
References: <CT6HJ3U8068R.3A8SJMV02D9BC@gonk>
 <8f7880cc-3622-1c0a-a126-5b47aafeee51@eisentraut.org>
 <CTUJMJ1B57SL.3T8TKNTE9XSVD@gonk>
 <fe3d9d88-9702-3339-d86a-98a121244c9c@eisentraut.org>
In-Reply-To: <fe3d9d88-9702-3339-d86a-98a121244c9c@eisentraut.org>
Archived-At: 
 <https://www.postgresql.org/message-id/CTV4SEUNM92R.2OM4SN8LB7CQN%40gonk>
Precedence: bulk

On Thu Jul 6, 2023 at 3:21 AM CDT, Peter Eisentraut wrote:
> On 05.07.23 23:06, Tristan Partin wrote:
> > Thanks for following up. My system is Fedora 38. I can confirm this is
> > still happening on master.
> >=20
> > $ gcc --version
> > gcc (GCC) 13.1.1 20230614 (Red Hat 13.1.1-4)
> > Copyright (C) 2023 Free Software Foundation, Inc.
> > This is free software; see the source for copying conditions.  There is=
 NO
> > warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURP=
OSE.
> > $ meson setup build --buildtype=3Drelease
>
> This buildtype turns on -O3 warnings.  We have usually opted against=20
> chasing warnings in -O3 level because there are often some=20
> false-positive uninitialized variable warnings with every new compiler.
>
> Note that we have set the default build type to debugoptimized, for that=
=20
> reason.

Good to know, thanks.

Regarding the original patch, do you think it is good to be applied?

--=20
Tristan Partin
Neon (https://neon.tech)