Content-Type: multipart/mixed;
 boundary=2871a5ed1197963036d334ae03bf87c3a4bb05be52ab91244e053d01bb38
Mime-Version: 1.0
Date: Wed, 12 Jul 2023 11:10:21 -0500
Cc: <pgsql-hackers@postgresql.org>
Subject: Re: Meson build updates
To: "Tristan Partin" <tristan@neon.tech>, "Andres Freund"
 <andres@anarazel.de>
From: "Tristan Partin" <tristan@neon.tech>
Message-Id: <CU0BPAZ4TIJU.2M804H0H066GR@gonk>
References: <CSPIJVUDZFKX.3KHMOAVGF94RV@c3po>
 <20230609164135.77fjwqkqzdxfs3f5@awork3.anarazel.de>
 <CT8BP7BRV4A2.AOE7263UX2SH@gonk>
 <20230609183603.o56z3ngtak6qhb3s@awork3.anarazel.de>
 <CTBSCT2V1TVP.2AUJVJLNWQVG3@gonk>
 <20230629190242.kgnimiizjbvmdfni@awork3.anarazel.de>
 <CTPDBT2W78PQ.2QUDVHFNR5MCS@gonk>
 <20230629191308.jrmbdgngedorxytz@awork3.anarazel.de>
 <CTPDJLWBJV4V.1O65TIXTC8STQ@gonk>
In-Reply-To: <CTPDJLWBJV4V.1O65TIXTC8STQ@gonk>
Archived-At: 
 <https://www.postgresql.org/message-id/CU0BPAZ4TIJU.2M804H0H066GR%40gonk>
Precedence: bulk

--2871a5ed1197963036d334ae03bf87c3a4bb05be52ab91244e053d01bb38
Content-Type: multipart/alternative;
 boundary=3201293a2a1427cbbcca6b2933d2c111843c2bc97cad112d432f27539a98

--3201293a2a1427cbbcca6b2933d2c111843c2bc97cad112d432f27539a98
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Content-Type: text/plain; charset=UTF-8

On Thu Jun 29, 2023 at 2:17 PM CDT, Tristan Partin wrote:
> On Thu Jun 29, 2023 at 2:13 PM CDT, Andres Freund wrote:
> > Hi,
> >
> > On 2023-06-29 14:07:19 -0500, Tristan Partin wrote:
> > > I still think the overrides are important, at the very least for libp=
q,
> > > but I will defer to your aforementioned decision for now.
> >
> > libpq makes sense to me, fwiw. Just doing it for all binaries individua=
lly
> > didn't seem as obviously beneficial.
> >
> > FWIW, it seems it could be handled somewhat centrally for binaries, the
> > bin_targets array should have all that's needed?
>
> I will send a follow-up patch with at least libpq overridden. I will
> investigate the bin_targets.

Attached is a patch which does just that without overriding the
binaries. I investigated the bin_targets stuff, but some test
executables get added there, so it wouldn't work out that well.

--=20
Tristan Partin
Neon (https://neon.tech)

--3201293a2a1427cbbcca6b2933d2c111843c2bc97cad112d432f27539a98--

--2871a5ed1197963036d334ae03bf87c3a4bb05be52ab91244e053d01bb38
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
 filename=v6-0001-Add-Meson-override-for-libpq.patch
Content-Type: text/x-patch; charset=utf-8;
 name=v6-0001-Add-Meson-override-for-libpq.patch

RnJvbSBiNTJhMTNkMTU3NWU0OTY1ZThjMTc5NGU3YTYyZjI0ZWNmZWViMWNmIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBUcmlzdGFuIFBhcnRpbiA8dHJpc3RhbkBuZW9uLnRlY2g+CkRh
dGU6IFdlZCwgMTcgTWF5IDIwMjMgMTA6MzY6NTIgLTA1MDAKU3ViamVjdDogW1BBVENIIHY2XSBB
ZGQgTWVzb24gb3ZlcnJpZGUgZm9yIGxpYnBxCgpNZXNvbiBoYXMgdGhlIGFiaWxpdHkgdG8gZG8g
dHJhbnNwYXJlbnQgb3ZlcnJpZGVzIHdoZW4gcHJvamVjdHMgYXJlIHVzZWQKYXMgc3VicHJvamVj
dHMuIEZvciBpbnN0YW5jZSwgc2F5IEkgYW0gYnVpbGRpbmcgYSBQb3N0Z3JlcyBleHRlbnNpb24u
IEkKY2FuIGRlZmluZSBQb3N0Z3JlcyB0byBiZSBhIHN1YnByb2plY3Qgb2YgbXkgZXh0ZW5zaW9u
IGdpdmVuIHRoZQpmb2xsb3dpbmcgd3JhcCBmaWxlOgoKW3dyYXAtZ2l0XQp1cmwgPSBodHRwczov
L2dpdC5wb3N0Z3Jlc3FsLm9yZy9naXQvcG9zdGdyZXNxbC5naXQKcmV2aXNpb24gPSBtYXN0ZXIK
ZGVwdGggPSAxCgpbcHJvdmlkZV0KZGVwZW5kZW5jeV9uYW1lcyA9IGxpYnBxCgpUaGVuIGluIG15
IGV4dGVuc2lvbiAocm9vdCBwcm9qZWN0KSwgSSBjYW4gaGF2ZSB0aGUgZm9sbG93aW5nIGxpbmUK
c25pcHBldDoKCmxpYnBxID0gZGVwZW5kZW5jeSgnbGlicHEnKQoKVGhpcyB3aWxsIHRlbGwgTWVz
b24gdG8gdHJhbnNwYXJlbnRseSBjb21waWxlIGxpYnBxIHByaW9yIHRvIGl0CmNvbXBpbGluZyBt
eSBleHRlbnNpb24gKGJlY2F1c2UgSSBkZXBlbmQgb24gbGlicHEpIGlmIGxpYnBxIGlzbid0IGZv
dW5kCm9uIHRoZSBob3N0IHN5c3RlbS4KLS0tCiBzcmMvaW50ZXJmYWNlcy9saWJwcS9tZXNvbi5i
dWlsZCB8IDIgKysKIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQg
YS9zcmMvaW50ZXJmYWNlcy9saWJwcS9tZXNvbi5idWlsZCBiL3NyYy9pbnRlcmZhY2VzL2xpYnBx
L21lc29uLmJ1aWxkCmluZGV4IDgwZTZhMTVhZGYuLjZkMTg5NzBlODEgMTAwNjQ0Ci0tLSBhL3Ny
Yy9pbnRlcmZhY2VzL2xpYnBxL21lc29uLmJ1aWxkCisrKyBiL3NyYy9pbnRlcmZhY2VzL2xpYnBx
L21lc29uLmJ1aWxkCkBAIC04NCw2ICs4NCw4IEBAIGxpYnBxID0gZGVjbGFyZV9kZXBlbmRlbmN5
KAogICBpbmNsdWRlX2RpcmVjdG9yaWVzOiBbaW5jbHVkZV9kaXJlY3RvcmllcygnLicpXQogKQog
CittZXNvbi5vdmVycmlkZV9kZXBlbmRlbmN5KCdsaWJwcScsIGxpYnBxKQorCiBwa2djb25maWcu
Z2VuZXJhdGUoCiAgIG5hbWU6ICdsaWJwcScsCiAgIGRlc2NyaXB0aW9uOiAnUG9zdGdyZVNRTCBs
aWJwcSBsaWJyYXJ5JywKLS0gClRyaXN0YW4gUGFydGluCk5lb24gKGh0dHBzOi8vbmVvbi50ZWNo
KQoK
--2871a5ed1197963036d334ae03bf87c3a4bb05be52ab91244e053d01bb38--