Content-Type: multipart/mixed;
 boundary=394afd8cfbbdead583fcbd23725ada08d868abd7ae1105e5373dbc009ca6
Mime-Version: 1.0
Date: Tue, 08 Aug 2023 10:14:57 -0500
Subject: Re: Fix last unitialized memory warning
To: "Peter Eisentraut" <peter@eisentraut.org>,
 <pgsql-hackers@postgresql.org>
From: "Tristan Partin" <tristan@neon.tech>
Message-Id: <CUN9FLTQAMIQ.RANXYVABYETV@gonk>
References: <CT6HJ3U8068R.3A8SJMV02D9BC@gonk>
 <8f7880cc-3622-1c0a-a126-5b47aafeee51@eisentraut.org>
 <CTUJMJ1B57SL.3T8TKNTE9XSVD@gonk>
 <fe3d9d88-9702-3339-d86a-98a121244c9c@eisentraut.org>
 <CTV4SEUNM92R.2OM4SN8LB7CQN@gonk>
 <54989bdd-d6fe-92dc-a7e3-f4f31252b7eb@eisentraut.org>
 <CU6BH3JA3GCY.25ETDNK3LVULF@gonk>
 <c1d63155-7ac7-90dc-2e82-12b97e497026@eisentraut.org>
In-Reply-To: <c1d63155-7ac7-90dc-2e82-12b97e497026@eisentraut.org>
Archived-At: 
 <https://www.postgresql.org/message-id/CUN9FLTQAMIQ.RANXYVABYETV%40gonk>
Precedence: bulk

--394afd8cfbbdead583fcbd23725ada08d868abd7ae1105e5373dbc009ca6
Content-Type: multipart/alternative;
 boundary=c5ae230354df120f4d6c2a80544b8852c4012aa8eb3210f07566280bb29f

--c5ae230354df120f4d6c2a80544b8852c4012aa8eb3210f07566280bb29f
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Content-Type: text/plain; charset=UTF-8; format=Flowed

On Tue Aug 8, 2023 at 5:20 AM CDT, Peter Eisentraut wrote:
> On 19.07.23 19:15, Tristan Partin wrote:
> > On Sun Jul 9, 2023 at 2:23 AM CDT, Peter Eisentraut wrote:
> >> On 06.07.23 15:41, Tristan Partin wrote:
> >> > On Thu Jul 6, 2023 at 3:21 AM CDT, Peter Eisentraut wrote:
> >> >> On 05.07.23 23:06, Tristan Partin wrote:
> >> >>> Thanks for following up. My system is Fedora 38. I can confirm=20
> >> this is
> >> >>> still happening on master.
> >> >>>
> >> >>> $ gcc --version
> >> >>> gcc (GCC) 13.1.1 20230614 (Red Hat 13.1.1-4)
> >> >>> Copyright (C) 2023 Free Software Foundation, Inc.
> >> >>> This is free software; see the source for copying conditions. =20
> >> There is NO
> >> >>> warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR=
=20
> >> PURPOSE.
> >> >>> $ meson setup build --buildtype=3Drelease
> >> >>
> >> >> This buildtype turns on -O3 warnings.=C2=A0 We have usually opted a=
gainst
> >> >> chasing warnings in -O3 level because there are often some
> >> >> false-positive uninitialized variable warnings with every new=20
> >> compiler.
> >> >>
> >> >> Note that we have set the default build type to debugoptimized, for=
=20
> >> that
> >> >> reason.
> >> > > Good to know, thanks.
> >> > > Regarding the original patch, do you think it is good to be applie=
d?
> >>
> >> That patch looks reasonable.=C2=A0 But I can't actually reproduce the=
=20
> >> warning, even with gcc-13.=C2=A0 I do get the warning from plpgsql.=C2=
=A0 Can=20
> >> you show the warning you are seeing?
> >=20
> > Here is the full warning that the original patch suppresses.
>
> I was able to reproduce the warning now on Fedora.  I agree with the patc=
h
>
> -       PgBenchValue vargs[MAX_FARGS];
> +       PgBenchValue vargs[MAX_FARGS] =3D { 0 };
>
> I suggest to also do
>
>   typedef enum
>   {
> -       PGBT_NO_VALUE,
> +       PGBT_NO_VALUE =3D 0,
>
> to make clear that the initialization value is meant to be invalid.
>
> I also got the plpgsql warning that you showed earlier, but I couldn't=20
> think of a reasonable way to fix that.

Applied in v2.

--=20
Tristan Partin
Neon (https://neon.tech)

--c5ae230354df120f4d6c2a80544b8852c4012aa8eb3210f07566280bb29f--

--394afd8cfbbdead583fcbd23725ada08d868abd7ae1105e5373dbc009ca6
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
 filename=v2-0001-Fix-last-remaining-uninitialized-memory-warnings.patch
Content-Type: text/x-patch; charset=utf-8;
 name=v2-0001-Fix-last-remaining-uninitialized-memory-warnings.patch

RnJvbSA3ZTI4ZDA2MDg3MWIxOWE4YzA5NTM5ZTJkYTVlMjI2Yjc4MDQzMWI5IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBUcmlzdGFuIFBhcnRpbiA8dHJpc3RhbkBuZW9uLnRlY2g+CkRh
dGU6IFdlZCwgNyBKdW4gMjAyMyAwOToyMTo1OSAtMDUwMApTdWJqZWN0OiBbUEFUQ0ggdjJdIEZp
eCBsYXN0IHJlbWFpbmluZyB1bmluaXRpYWxpemVkIG1lbW9yeSB3YXJuaW5ncwoKZ2NjIGZhaWxz
IHRvIHByb3Blcmx5IGFuYWx5emUgdGhlIGNvZGUgZHVlIHRvIHRoZSBsb29wIHN0b3AgY29uZGl0
aW9uCmluY2x1ZGluZyBgbCAhPSBOVUxMYC4gTGV0J3MganVzdCBoZWxwIGl0IG91dC4KLS0tCiBz
cmMvYmluL3BnYmVuY2gvcGdiZW5jaC5jIHwgMiArLQogc3JjL2Jpbi9wZ2JlbmNoL3BnYmVuY2gu
aCB8IDIgKy0KIDIgZmlsZXMgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygt
KQoKZGlmZiAtLWdpdCBhL3NyYy9iaW4vcGdiZW5jaC9wZ2JlbmNoLmMgYi9zcmMvYmluL3BnYmVu
Y2gvcGdiZW5jaC5jCmluZGV4IDUzOWMyNzk1ZTIuLjJiYTNlMzY3YzQgMTAwNjQ0Ci0tLSBhL3Ny
Yy9iaW4vcGdiZW5jaC9wZ2JlbmNoLmMKKysrIGIvc3JjL2Jpbi9wZ2JlbmNoL3BnYmVuY2guYwpA
QCAtMjIzOSw3ICsyMjM5LDcgQEAgZXZhbFN0YW5kYXJkRnVuYyhDU3RhdGUgKnN0LAogewogCS8q
IGV2YWx1YXRlIGFsbCBmdW5jdGlvbiBhcmd1bWVudHMgKi8KIAlpbnQJCQluYXJncyA9IDA7Ci0J
UGdCZW5jaFZhbHVlIHZhcmdzW01BWF9GQVJHU107CisJUGdCZW5jaFZhbHVlIHZhcmdzW01BWF9G
QVJHU10gPSB7IDAgfTsKIAlQZ0JlbmNoRXhwckxpbmsgKmwgPSBhcmdzOwogCWJvb2wJCWhhc19u
dWxsID0gZmFsc2U7CiAKZGlmZiAtLWdpdCBhL3NyYy9iaW4vcGdiZW5jaC9wZ2JlbmNoLmggYi9z
cmMvYmluL3BnYmVuY2gvcGdiZW5jaC5oCmluZGV4IDk1N2M5Y2E5ZGEuLmY4ZWZhNGI4NjggMTAw
NjQ0Ci0tLSBhL3NyYy9iaW4vcGdiZW5jaC9wZ2JlbmNoLmgKKysrIGIvc3JjL2Jpbi9wZ2JlbmNo
L3BnYmVuY2guaApAQCAtMzMsNyArMzMsNyBAQCB1bmlvbiBZWVNUWVBFOwogICovCiB0eXBlZGVm
IGVudW0KIHsKLQlQR0JUX05PX1ZBTFVFLAorCVBHQlRfTk9fVkFMVUUgPSAwLAogCVBHQlRfTlVM
TCwKIAlQR0JUX0lOVCwKIAlQR0JUX0RPVUJMRSwKLS0gClRyaXN0YW4gUGFydGluCk5lb24gKGh0
dHBzOi8vbmVvbi50ZWNoKQoK
--394afd8cfbbdead583fcbd23725ada08d868abd7ae1105e5373dbc009ca6--