Content-Type: multipart/mixed;
 boundary=e188a6c30e6345c230560a362beffda0ab8cacb0a04c2008a490ebe9606f
Mime-Version: 1.0
Date: Wed, 09 Aug 2023 10:29:56 -0500
Cc: <pgsql-hackers@postgresql.org>
Subject: Re: Fix last unitialized memory warning
To: "Peter Eisentraut" <peter@eisentraut.org>
From: "Tristan Partin" <tristan@neon.tech>
Message-Id: <CUO4DOBLGCGQ.2O00AZU0E82UY@gonk>
References: <CT6HJ3U8068R.3A8SJMV02D9BC@gonk>
 <8f7880cc-3622-1c0a-a126-5b47aafeee51@eisentraut.org>
 <CTUJMJ1B57SL.3T8TKNTE9XSVD@gonk>
 <fe3d9d88-9702-3339-d86a-98a121244c9c@eisentraut.org>
 <CTV4SEUNM92R.2OM4SN8LB7CQN@gonk>
 <54989bdd-d6fe-92dc-a7e3-f4f31252b7eb@eisentraut.org>
 <CU6BH3JA3GCY.25ETDNK3LVULF@gonk>
 <c1d63155-7ac7-90dc-2e82-12b97e497026@eisentraut.org>
 <CUN9FLTQAMIQ.RANXYVABYETV@gonk>
 <a88b0adf-9e26-fbbc-805e-6e0da5ae64bf@eisentraut.org>
 <7ae6b2ac-b7e4-8a19-9421-2c6e7add0188@eisentraut.org>
In-Reply-To: <7ae6b2ac-b7e4-8a19-9421-2c6e7add0188@eisentraut.org>
Archived-At: 
 <https://www.postgresql.org/message-id/CUO4DOBLGCGQ.2O00AZU0E82UY%40gonk>
Precedence: bulk

--e188a6c30e6345c230560a362beffda0ab8cacb0a04c2008a490ebe9606f
Content-Type: multipart/alternative;
 boundary=b0caef48028b126ddd010af3096ca8b61f4e046fbc5113578a4a2694eea3

--b0caef48028b126ddd010af3096ca8b61f4e046fbc5113578a4a2694eea3
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Content-Type: text/plain; charset=UTF-8; format=Flowed

On Wed Aug 9, 2023 at 10:02 AM CDT, Peter Eisentraut wrote:
> On 09.08.23 10:07, Peter Eisentraut wrote:
> > On 08.08.23 17:14, Tristan Partin wrote:
> >>> I was able to reproduce the warning now on Fedora.=C2=A0 I agree with=
 the=20
> >>> patch
> >>>
> >>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 PgBenchValue vargs[MAX_FARGS];
> >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 PgBenchValue vargs[MAX_FARGS] =
=3D { 0 };
> >>>
> >>> I suggest to also do
> >>>
> >>> =C2=A0 typedef enum
> >>> =C2=A0 {
> >>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 PGBT_NO_VALUE,
> >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 PGBT_NO_VALUE =3D 0,
> >>>
> >>> to make clear that the initialization value is meant to be invalid.
> >>>
> >>> I also got the plpgsql warning that you showed earlier, but I=20
> >>> couldn't think of a reasonable way to fix that.
> >>
> >> Applied in v2.
> >=20
> > committed
>
> This patch has apparently upset one buildfarm member with a very old=20
> compiler:=20
> https://buildfarm.postgresql.org/cgi-bin/show_history.pl?nm=3Dlapwing&br=
=3DHEAD
>
> Any thoughts?

Best I could find is SO question[0] which links out to[1]. Try this=20
patch. Otherwise, a memset() would probably do too.

[0]: https://stackoverflow.com/questions/13746033/how-to-repair-warning-mis=
sing-braces-around-initializer
[1]: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D53119

--=20
Tristan Partin
Neon (https://neon.tech)

--b0caef48028b126ddd010af3096ca8b61f4e046fbc5113578a4a2694eea3--

--e188a6c30e6345c230560a362beffda0ab8cacb0a04c2008a490ebe9606f
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
 filename=v1-0001-Fix-erroneous-Werror-missing-braces-on-old-GCC.patch
Content-Type: text/x-patch; charset=utf-8;
 name=v1-0001-Fix-erroneous-Werror-missing-braces-on-old-GCC.patch

RnJvbSBlY2IzNDJhODhlNWZiMmE4OGYwMDg2ZGNmNDZmZGNhZGI2ZDkzMGJhIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBUcmlzdGFuIFBhcnRpbiA8dHJpc3RhbkBuZW9uLnRlY2g+CkRh
dGU6IFdlZCwgOSBBdWcgMjAyMyAxMDoxMjo0NyAtMDUwMApTdWJqZWN0OiBbUEFUQ0ggdjFdIEZp
eCBlcnJvbmVvdXMgLVdlcnJvcj1taXNzaW5nLWJyYWNlcyBvbiBvbGQgR0NDCgpUaGUgYnVpbGRm
YXJtIHJlcG9ydHMgdGhhdCB0aGlzIGlzIGFuIGVycm9yIG9uIGdjYyAoRGViaWFuIDQuNy4yLTUp
CjQuNy4yLCAzMi1iaXQuIFRoZSBidWcgc2VlbXMgdG8gYmUgR0NDIGJ1ZyA1MzExOSwgd2hpY2gg
aGFzIG9idmlvdXNseQpiZWVuIGZpeGVkIGZvciB5ZWFycy4KLS0tCiBzcmMvYmluL3BnYmVuY2gv
cGdiZW5jaC5jIHwgNyArKysrKystCiAxIGZpbGUgY2hhbmdlZCwgNiBpbnNlcnRpb25zKCspLCAx
IGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvc3JjL2Jpbi9wZ2JlbmNoL3BnYmVuY2guYyBiL3Ny
Yy9iaW4vcGdiZW5jaC9wZ2JlbmNoLmMKaW5kZXggMmJhM2UzNjdjNC4uZDJiN2ZjODdlNCAxMDA2
NDQKLS0tIGEvc3JjL2Jpbi9wZ2JlbmNoL3BnYmVuY2guYworKysgYi9zcmMvYmluL3BnYmVuY2gv
cGdiZW5jaC5jCkBAIC0yMjM5LDEwICsyMjM5LDE1IEBAIGV2YWxTdGFuZGFyZEZ1bmMoQ1N0YXRl
ICpzdCwKIHsKIAkvKiBldmFsdWF0ZSBhbGwgZnVuY3Rpb24gYXJndW1lbnRzICovCiAJaW50CQkJ
bmFyZ3MgPSAwOwotCVBnQmVuY2hWYWx1ZSB2YXJnc1tNQVhfRkFSR1NdID0geyAwIH07CiAJUGdC
ZW5jaEV4cHJMaW5rICpsID0gYXJnczsKIAlib29sCQloYXNfbnVsbCA9IGZhbHNlOwogCisJLyoK
KwkgKiBUaGlzIHZhbHVlIGlzIGRvdWJsZSBicmFjZWQgdG8gd29ya2Fyb3VuZCBHQ0MgYnVnIDUz
MTE5LCB3aGljaCBzZWVtcyB0bworCSAqIGV4aXN0IGF0IGxlYXN0IG9uIGdjYyAoRGViaWFuIDQu
Ny4yLTUpIDQuNy4yLCAzMi1iaXQuCisJICovCisJUGdCZW5jaFZhbHVlIHZhcmdzW01BWF9GQVJH
U10gPSB7IHsgMCB9IH07CisKIAlmb3IgKG5hcmdzID0gMDsgbmFyZ3MgPCBNQVhfRkFSR1MgJiYg
bCAhPSBOVUxMOyBuYXJncysrLCBsID0gbC0+bmV4dCkKIAl7CiAJCWlmICghZXZhbHVhdGVFeHBy
KHN0LCBsLT5leHByLCAmdmFyZ3NbbmFyZ3NdKSkKLS0gClRyaXN0YW4gUGFydGluCk5lb24gKGh0
dHBzOi8vbmVvbi50ZWNoKQoK
--e188a6c30e6345c230560a362beffda0ab8cacb0a04c2008a490ebe9606f--