Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8; format=Flowed
Date: Thu, 17 Aug 2023 14:45:54 -0500
Message-Id: <CUV2U1MR5T8E.2T55FGZG23INJ@gonk>
Cc: "PostgreSQL Hackers" <pgsql-hackers@lists.postgresql.org>,
 <andres@anarazel.dev>
Subject: Re: meson: pgxs Makefile.global differences
To: "Andrew Dunstan" <andrew@dunslane.net>
From: "Tristan Partin" <tristan@neon.tech>
References: <61d629b6-d5ad-a49e-e905-b66d3ac4903a@dunslane.net>
In-Reply-To: <61d629b6-d5ad-a49e-e905-b66d3ac4903a@dunslane.net>
Archived-At: <https://www.postgresql.org/message-id/CUV2U1MR5T8E.2T55FGZG23INJ%40gonk>
Precedence: bulk

On Thu Aug 17, 2023 at 2:32 PM CDT, Andrew Dunstan wrote:
> I started digging into a warning I noticed on my FDW builds where=20
> Postgres is built with meson, e.g.=20
> <https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=3Dcrake&dt=
=3D2023-08-16%2018%3A37%3A25&stg=3DFileTextArrayFDW-build>=20
> which has this:
>
> cc1: warning: =E2=80=98-Wformat-security=E2=80=99 ignored without =E2=80=
=98-Wformat=E2=80=99=20
> [-Wformat-security]
>
> I found that the pgxs Makefile.global built under meson is a bit=20
> different. On debug builds for both this is what I get on HEAD (meson)=20
> and REL_15_STABLE (autoconf), stripped of the current components:
>
>  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 HEAD: CFLAGS =3D-Wshado=
w=3Dcompatible-local
> REL_15_STABLE: CFLAGS =3D-Wall=C2=A0 -g
>
> The warning is apparently due to the missing -Wall.
>
> Shouldn't we be aiming for pretty much identical settings?

I agree that they should be identical. The meson bild should definitely=20
be aiming for 100% compatibility for the Makefile.global.

--=20
Tristan Partin
Neon (https://neon.tech)