Content-Type: multipart/mixed;
 boundary=2664deabee98fb5844a3d434672fd54f47b9f7cdac7d0a46f9f046b4d059
Mime-Version: 1.0
Date: Tue, 19 Sep 2023 15:54:53 -0500
Message-Id: <CVN6YUCH9TNC.1TYXN3DNYP4IE@neon.tech>
To: "Matthias van de Meent" <boekewurm+postgres@gmail.com>
From: "Tristan Partin" <tristan@neon.tech>
Cc: "PostgreSQL Hackers" <pgsql-hackers@postgresql.org>
Subject: Re: Extensible storage manager API - SMGR hook Redux
References: <CAEze2WgMySu2suO_TLvFyGY3URa4mAx22WeoEicnK=PCNWEMrA@mail.gmail.com>
In-Reply-To: <CAEze2WgMySu2suO_TLvFyGY3URa4mAx22WeoEicnK=PCNWEMrA@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/CVN6YUCH9TNC.1TYXN3DNYP4IE%40neon.tech>
Precedence: bulk

--2664deabee98fb5844a3d434672fd54f47b9f7cdac7d0a46f9f046b4d059
Content-Type: multipart/alternative;
 boundary=3bbf3a5fd043d8a3de6499610533d7100596f939af0c4e8f0941fa328ee5

--3bbf3a5fd043d8a3de6499610533d7100596f939af0c4e8f0941fa328ee5
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Content-Type: text/plain; charset=UTF-8; format=Flowed

Found these warnings while compiling while only 0001 is applied.

[1166/2337] Compiling C object src/backend/postgres_lib.a.p/storage_smgr_md=
.c.o
../src/backend/storage/smgr/md.c: In function =E2=80=98mdexists=E2=80=99:
../src/backend/storage/smgr/md.c:224:28: warning: passing argument 1 of =E2=
=80=98mdopenfork=E2=80=99 from incompatible pointer type [-Wincompatible-po=
inter-types]
  224 |         return (mdopenfork(reln, forknum, EXTENSION_RETURN_NULL) !=
=3D NULL);
      |                            ^~~~
      |                            |
      |                            SMgrRelation {aka SMgrRelationData *}
../src/backend/storage/smgr/md.c:167:43: note: expected =E2=80=98MdSMgrRela=
tion=E2=80=99 {aka =E2=80=98MdSMgrRelationData *=E2=80=99} but argument is =
of type =E2=80=98SMgrRelation=E2=80=99 {aka =E2=80=98SMgrRelationData *=E2=
=80=99}
  167 | static MdfdVec *mdopenfork(MdSMgrRelation reln, ForkNumber forknum,=
 int behavior);
      |                            ~~~~~~~~~~~~~~~^~~~
../src/backend/storage/smgr/md.c: In function =E2=80=98mdcreate=E2=80=99:
../src/backend/storage/smgr/md.c:287:40: warning: passing argument 1 of =E2=
=80=98register_dirty_segment=E2=80=99 from incompatible pointer type [-Winc=
ompatible-pointer-types]
  287 |                 register_dirty_segment(reln, forknum, mdfd);
      |                                        ^~~~
      |                                        |
      |                                        SMgrRelation {aka SMgrRelati=
onData *}
../src/backend/storage/smgr/md.c:168:51: note: expected =E2=80=98MdSMgrRela=
tion=E2=80=99 {aka =E2=80=98MdSMgrRelationData *=E2=80=99} but argument is =
of type =E2=80=98SMgrRelation=E2=80=99 {aka =E2=80=98SMgrRelationData *=E2=
=80=99}
  168 | static void register_dirty_segment(MdSMgrRelation reln, ForkNumber =
forknum,

Here is a diff to be applied to 0001 which fixes the warnings that get=20
generated when compiling. I did see that one of the warnings gets fixed=20
0002 (the mdexists() one). I am assuming that change was just missed=20
while rebasing the patchset or something. I did not see a fix for
mdcreate() in 0002 however.

--=20
Tristan Partin
Neon (https://neon.tech)

--3bbf3a5fd043d8a3de6499610533d7100596f939af0c4e8f0941fa328ee5--

--2664deabee98fb5844a3d434672fd54f47b9f7cdac7d0a46f9f046b4d059
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename=smgr.diff
Content-Type: text/x-patch; charset=utf-8; name=smgr.diff

ZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL3N0b3JhZ2Uvc21nci9tZC5jIGIvc3JjL2JhY2tlbmQv
c3RvcmFnZS9zbWdyL21kLmMKaW5kZXggZjNlNDc2ODE2MC4uZmRjOWY2MmZkZiAxMDA2NDQKLS0t
IGEvc3JjL2JhY2tlbmQvc3RvcmFnZS9zbWdyL21kLmMKKysrIGIvc3JjL2JhY2tlbmQvc3RvcmFn
ZS9zbWdyL21kLmMKQEAgLTIxMyw2ICsyMTMsOCBAQCBtZGluaXQodm9pZCkKIGJvb2wKIG1kZXhp
c3RzKFNNZ3JSZWxhdGlvbiByZWxuLCBGb3JrTnVtYmVyIGZvcmtudW0pCiB7CisJTWRTTWdyUmVs
YXRpb24gbWRyZWxuID0gKE1kU01nclJlbGF0aW9uKSByZWxuOworCiAJLyoKIAkgKiBDbG9zZSBp
dCBmaXJzdCwgdG8gZW5zdXJlIHRoYXQgd2Ugbm90aWNlIGlmIHRoZSBmb3JrIGhhcyBiZWVuIHVu
bGlua2VkCiAJICogc2luY2Ugd2Ugb3BlbmVkIGl0LiAgQXMgYW4gb3B0aW1pemF0aW9uLCB3ZSBj
YW4gc2tpcCB0aGF0IGluIHJlY292ZXJ5LApAQCAtMjIxLDcgKzIyMyw3IEBAIG1kZXhpc3RzKFNN
Z3JSZWxhdGlvbiByZWxuLCBGb3JrTnVtYmVyIGZvcmtudW0pCiAJaWYgKCFJblJlY292ZXJ5KQog
CQltZGNsb3NlKHJlbG4sIGZvcmtudW0pOwogCi0JcmV0dXJuIChtZG9wZW5mb3JrKHJlbG4sIGZv
cmtudW0sIEVYVEVOU0lPTl9SRVRVUk5fTlVMTCkgIT0gTlVMTCk7CisJcmV0dXJuIChtZG9wZW5m
b3JrKG1kcmVsbiwgZm9ya251bSwgRVhURU5TSU9OX1JFVFVSTl9OVUxMKSAhPSBOVUxMKTsKIH0K
IAogLyoKQEAgLTI4NCw3ICsyODYsNyBAQCBtZGNyZWF0ZShTTWdyUmVsYXRpb24gcmVsbiwgRm9y
a051bWJlciBmb3JrbnVtLCBib29sIGlzUmVkbykKIAltZGZkLT5tZGZkX3NlZ25vID0gMDsKIAog
CWlmICghU21ncklzVGVtcChyZWxuKSkKLQkJcmVnaXN0ZXJfZGlydHlfc2VnbWVudChyZWxuLCBm
b3JrbnVtLCBtZGZkKTsKKwkJcmVnaXN0ZXJfZGlydHlfc2VnbWVudChtZHJlbG4sIGZvcmtudW0s
IG1kZmQpOwogfQogCiAvKgo=
--2664deabee98fb5844a3d434672fd54f47b9f7cdac7d0a46f9f046b4d059--