Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qj1Gj-008xyT-Pq for pgsql-hackers@arkaria.postgresql.org; Wed, 20 Sep 2023 17:45:45 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qj1Gg-001Ym2-QJ for pgsql-hackers@arkaria.postgresql.org; Wed, 20 Sep 2023 17:45:42 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qj1Gg-001YlZ-Ac for pgsql-hackers@lists.postgresql.org; Wed, 20 Sep 2023 17:45:42 +0000 Received: from mail-oa1-x2b.google.com ([2001:4860:4864:20::2b]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1qj1Gd-005fF9-Fi for pgsql-hackers@lists.postgresql.org; Wed, 20 Sep 2023 17:45:41 +0000 Received: by mail-oa1-x2b.google.com with SMTP id 586e51a60fabf-1c504386374so39936fac.3 for ; Wed, 20 Sep 2023 10:45:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neon-tech.20230601.gappssmtp.com; s=20230601; t=1695231938; x=1695836738; darn=lists.postgresql.org; h=in-reply-to:references:from:to:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=yPWjZm53r6sHPS2LfJOZI/mmqocZa17VYL61JGdG8i4=; b=eCdbgSf8oep+b5+LqyvFUGPBxuUQQx4dqGXK7eW1NJZps8dGliNi1RhDsJV22jhp52 mRAxH2JKFc7y9p6fdMAZ3JQ/3V8c/UnJR6ckX+5g5rUzZYMM/tQsFEQ/cusDfloYMGmL Qg+7R4kOyznKR1YT1kJHXd3cBzvNgYlKzvpgSd2Oobc0yM6zOywiBOBIEnw+2qOXI8v+ N1XGZUTsOwjlcfMP61BIq97/lmVL2RR/4Kdx6fXnptUxN6IK+L+ccnGq702sZAXdp3U+ qhzhQq/wx+D42gLbMz2DbSDyThJxrnesTqPNzGNGT17vkkJhFMx17c+6UWjWWuwuKS6v I1rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695231938; x=1695836738; h=in-reply-to:references:from:to:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=yPWjZm53r6sHPS2LfJOZI/mmqocZa17VYL61JGdG8i4=; b=nbx1xDaOUU2lwasg5BSS5mQewjN8UkBu+kwQ4O3hjwgOM+3zB694bl4Q1S4i1CdqP1 /T1FrIW6xYqxWhLD5y0Rf5LCYpf4ICBvNOzdBvjGSEoS/mbaAK5ysvvGzYR8C3zb1kds TF60qxV2rKUOWe6lwVMfvzNEqJS3xzY4/Ajg03uDnBAMzXQgTZU6BYN466I8RX65zskN VSPGoYtubDv/5FqDxFrzdTHGGLfLUcWBJK5+iy43OOPRQ9+pATewgQVEYvWREiNAHnMr ODLJ9rovkU7gg0KTQt/eezsls/o1O6x4EIPQonUwG18Cb2hsqRgIChAlrBINOqeNbxqd DqsQ== X-Gm-Message-State: AOJu0Yz3L6yfrJNRhNYQnYlkt/KRnJU4Y3hB1d3NiGBOdj7L8014sf8r VyAzC5FzxcVDBEvDq4WADAMezXy0cxxe6IP+Eiw= X-Google-Smtp-Source: AGHT+IF2bTBpG8nqbwNOtPSRuzj7WdGj0e5CT8w7bfgY2HYIkQALP274nvk9KDTGXgT1ShpSTzO70w== X-Received: by 2002:a05:6870:8926:b0:1be:f4b3:7f49 with SMTP id i38-20020a056870892600b001bef4b37f49mr3536628oao.23.1695231938257; Wed, 20 Sep 2023 10:45:38 -0700 (PDT) Received: from localhost ([2607:fb91:1284:cc4d:3996:e070:71ee:42fb]) by smtp.gmail.com with ESMTPSA id x49-20020a056830247100b006c20f55525esm4803316otr.1.2023.09.20.10.45.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Sep 2023 10:45:37 -0700 (PDT) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8; format=Flowed Date: Wed, 20 Sep 2023 12:45:36 -0500 Message-Id: Cc: "Pg Hackers" Subject: Re: pg_upgrade --check fails to warn about abstime To: "Alvaro Herrera" From: "Tristan Partin" X-Mailer: aerc 0.15.2-211-g37d5fc691aff References: <202309201654.ng4ksea25mti@alvherre.pgsql> In-Reply-To: <202309201654.ng4ksea25mti@alvherre.pgsql> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk > +/* > + * check_for_removed_data_type_usage > + * > + * similar to the above, but for types that were removed in 12. > + */ > +static void > +check_for_removed_data_type_usage(ClusterInfo *cluster, const char *data= type) Seems like you could make this more generic instead of hardcoding=20 version 12, and then you could use it for any future removed types as=20 well. Just a thought. --=20 Tristan Partin Neon (https://neon.tech)