Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8; format=Flowed
Date: Wed, 20 Sep 2023 13:13:03 -0500
Message-Id: <CVNY5H2S5PCU.1OGT8EPVXNDEI@neon.tech>
To: "Alvaro Herrera" <alvherre@alvh.no-ip.org>
From: "Tristan Partin" <tristan@neon.tech>
Cc: "Pg Hackers" <pgsql-hackers@lists.postgresql.org>
Subject: Re: pg_upgrade --check fails to warn about abstime
References: <CVNXKGJRAAWS.25S80HUEMM7II@neon.tech>
 <202309201758.vox63zqcqpi4@alvherre.pgsql>
In-Reply-To: <202309201758.vox63zqcqpi4@alvherre.pgsql>
Archived-At: 
 <https://www.postgresql.org/message-id/CVNY5H2S5PCU.1OGT8EPVXNDEI%40neon.tech>
Precedence: bulk

On Wed Sep 20, 2023 at 12:58 PM CDT, Alvaro Herrera wrote:
> On 2023-Sep-20, Tristan Partin wrote:
>
> > > +/*
> > > + * check_for_removed_data_type_usage
> > > + *
> > > + *        similar to the above, but for types that were removed in 1=
2.
> > > + */
> > > +static void
> > > +check_for_removed_data_type_usage(ClusterInfo *cluster, const char *=
datatype)
> >=20
> > Seems like you could make this more generic instead of hardcoding versi=
on
> > 12, and then you could use it for any future removed types as well.
>
> Yeah, I thought about that, and then closed that with "we can whack it
> around when we need it".  At this point I imagine there's very few other
> datatypes we can remove from the core server, if any.

Makes complete sense to me. Patch looks good to me with one comment.

> +                pg_fatal("Your installation contains the \"%s\" data typ=
e in user tables.\n"
> +                                 "Data type \"%s\" has been removed in P=
ostgreSQL version 12,\n"
> +                                 "so this cluster cannot currently be up=
graded.  You can drop the\n"
> +                                 "problem columns, or change them to ano=
ther data type, and restart\n"
> +                                 "the upgrade.  A list of the problem co=
lumns is in the file:\n"
> +                                 "    %s", datatype, datatype, output_pa=
th);

I would wrap the second \"%s\" in commas.

> Data type, "abstime", has been...

Maybe also add a "The" to start that sentence to make it less terse. Up=20
to you.

--=20
Tristan Partin
Neon (https://neon.tech)