Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8; format=Flowed
Date: Mon, 06 Nov 2023 11:16:34 -0600
Message-Id: <CWRWDTTPP0WZ.2W75ZAVL5ND1M@neon.tech>
Cc: "Tom Lane" <tgl@sss.pgh.pa.us>, <pgsql-hackers@postgresql.org>
Subject: Re: psql not responding to SIGINT upon db reconnection
To: "Shlok Kyal" <shlok.kyal.oss@gmail.com>
From: "Tristan Partin" <tristan@neon.tech>
References: <CUAJJDVD8L61.2AH6VEEDMTXX3@gonk>
 <CUAKHCX5472I.SJP0AWQRYVFA@gonk> <CUAKIOVISECO.2S7MSQFOP1304@gonk>
 <1588058.1690220636@sss.pgh.pa.us> <CUAO24Z1Y72E.2069AD01EB4LO@gonk>
 <CANhcyEVBQWoPJK+C_h1CKyN3Wr2VKHuPx=bSB4PH2LuGdut4qg@mail.gmail.com>
In-Reply-To: 
 <CANhcyEVBQWoPJK+C_h1CKyN3Wr2VKHuPx=bSB4PH2LuGdut4qg@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/CWRWDTTPP0WZ.2W75ZAVL5ND1M%40neon.tech>
Precedence: bulk

On Thu Nov 2, 2023 at 4:03 AM CDT, Shlok Kyal wrote:
> Hi,
>
> > That sounds like a much better solution. Attached you will find a v4
> > that implements your suggestion. Please let me know if there is
> > something that I missed. I can confirm that the patch works.
> >
> >         $ ./build/src/bin/psql/psql -h pg.neon.tech
> >         NOTICE:  Welcome to Neon!
> >         Authenticate by visiting:
> >             https://console.neon.tech/psql_session/xxx
> >
> >
> >         NOTICE:  Connecting to database.
> >         psql (17devel, server 15.3)
> >         SSL connection (protocol: TLSv1.3, cipher: TLS_AES_256_GCM_SHA3=
84, compression: off)
> >         Type "help" for help.
> >
> >         tristan957=3D> \c
> >         NOTICE:  Welcome to Neon!
> >         Authenticate by visiting:
> >             https://console.neon.tech/psql_session/yyy
> >
> >
> >         ^Cconnection to server at "pg.neon.tech" (3.18.6.96), port 5432=
 failed:
> >         Previous connection kept
> >         tristan957=3D>
>
> I went through CFbot and found out that some tests are timing out.
> Links:
> https://cirrus-ci.com/task/6735437444677632
> https://cirrus-ci.com/task/4536414189125632
> https://cirrus-ci.com/task/5046587584413696
> https://cirrus-ci.com/task/6172487491256320
> https://cirrus-ci.com/task/5609537537835008
>
> Some tests which are timing out are as follows:
> [00:48:49.243] Summary of Failures:
> [00:48:49.243]
> [00:48:49.243] 4/270 postgresql:regress / regress/regress TIMEOUT 1000.01=
s
> [00:48:49.243] 6/270 postgresql:pg_upgrade / pg_upgrade/002_pg_upgrade
> TIMEOUT 1000.02s
> [00:48:49.243] 34/270 postgresql:recovery /
> recovery/027_stream_regress TIMEOUT 1000.02s
> [00:48:49.243] 48/270 postgresql:plpgsql / plpgsql/regress TIMEOUT 1000.0=
2s
> [00:48:49.243] 49/270 postgresql:plperl / plperl/regress TIMEOUT 1000.01s
> [00:48:49.243] 61/270 postgresql:dblink / dblink/regress TIMEOUT 1000.03s
> [00:48:49.243] 89/270 postgresql:postgres_fdw / postgres_fdw/regress
> TIMEOUT 1000.01s
> [00:48:49.243] 93/270 postgresql:test_decoding / test_decoding/regress
> TIMEOUT 1000.02s
> [00:48:49.243] 110/270 postgresql:test_extensions /
> test_extensions/regress TIMEOUT 1000.03s
> [00:48:49.243] 123/270 postgresql:unsafe_tests / unsafe_tests/regress
> TIMEOUT 1000.02s
> [00:48:49.243] 152/270 postgresql:pg_dump / pg_dump/010_dump_connstr
> TIMEOUT 1000.03s
>
> Just want to make sure you are aware of the issue.

Hi Shlok!

Thanks for taking a look. I will check these failures out to see if=20
I can reproduce.

--=20
Tristan Partin
Neon (https://neon.tech)