Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8; format=Flowed
Date: Fri, 01 Dec 2023 15:55:29 -0600
Message-Id: <CXDBYZZR3T3Q.3CQUPEYXLP4NL@neon.tech>
Cc: <pgsql-hackers@lists.postgresql.org>
Subject: Re: pgsql: meson: docs: Add {html,man} targets, rename
 install-doc-*
To: "Andres Freund" <andres@anarazel.de>, "Andrew Dunstan"
 <andrew@dunslane.net>
From: "Tristan Partin" <tristan@neon.tech>
References: <E1r5Fwj-006RcU-Sh@gemulon.postgresql.org>
 <746ba786-85bb-d1f7-b613-57bec35c642a@dunslane.net>
 <20231129022843.6vfvgxjqpbgb62p5@awork3.anarazel.de>
 <703110e4-b495-e409-26a5-28e9fca8f3a5@dunslane.net>
 <20231129183619.3hrnwaexbrpygbxg@awork3.anarazel.de>
In-Reply-To: <20231129183619.3hrnwaexbrpygbxg@awork3.anarazel.de>
Archived-At: <https://www.postgresql.org/message-id/CXDBYZZR3T3Q.3CQUPEYXLP4NL%40neon.tech>
Precedence: bulk

Commits look fine to me, but I hate the new target names... Luckily,=20
I just use plain ninja, so I don't interact with that.

>  +    for name, v in targets_info_byname.items():
>  +        if len(targets_info_byname[name]) > 1:

My only comment is that you could reverse the logic and save yourself an=20
indentation.

- if len(targets_info_byname[name]) > 1:
+ if len(targets_info_byname[name]) <=3D 1:
+     continue

But whatever you want.

--=20
Tristan Partin
Neon (https://neon.tech)