public inbox for [email protected]
help / color / mirror / Atom feedFrom: Tristan Partin <[email protected]>
To: pgsql-hackers <[email protected]>
Subject: Remove WIN32 conditional compilation from win32common.c
Date: Tue, 05 Dec 2023 12:37:44 -0600
Message-ID: <[email protected]> (raw)
The file is only referenced in Meson and MSVC scripts from what I can
tell, and the Meson reference is protected by a Windows check.
--
Tristan Partin
Neon (https://neon.tech)
Attachments:
[text/x-patch] v1-0001-Remove-WIN32-conditional-compilation-from-win32co.patch (783B, ../[email protected]/2-v1-0001-Remove-WIN32-conditional-compilation-from-win32co.patch)
download | inline diff:
From bc9ffc7b0b141959a4c2a3f8b731f457ff5825c1 Mon Sep 17 00:00:00 2001
From: Tristan Partin <[email protected]>
Date: Tue, 5 Dec 2023 10:18:37 -0600
Subject: [PATCH v1] Remove WIN32 conditional compilation from win32common.c
This file is only compiled when WIN32 is defined, so the #ifdef was
not needed.
---
src/port/win32common.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/src/port/win32common.c b/src/port/win32common.c
index 2fd78f7f93..a075d01209 100644
--- a/src/port/win32common.c
+++ b/src/port/win32common.c
@@ -19,8 +19,6 @@
#include "postgres.h"
#endif
-#ifdef WIN32
-
/*
* pgwin32_get_file_type
*
@@ -64,5 +62,3 @@ pgwin32_get_file_type(HANDLE hFile)
return fileType;
}
-
-#endif /* WIN32 */
--
Tristan Partin
Neon (https://neon.tech)
view thread (2+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected]
Subject: Re: Remove WIN32 conditional compilation from win32common.c
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox