Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rCqL6-00HTcB-13 for pgsql-hackers@arkaria.postgresql.org; Tue, 12 Dec 2023 00:09:32 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rCqL1-0008hj-Vh for pgsql-hackers@arkaria.postgresql.org; Tue, 12 Dec 2023 00:09:27 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rCqL1-0008ha-L6 for pgsql-hackers@lists.postgresql.org; Tue, 12 Dec 2023 00:09:27 +0000 Received: from mail-oa1-x30.google.com ([2001:4860:4864:20::30]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1rCqKy-009wv9-IX for pgsql-hackers@postgresql.org; Tue, 12 Dec 2023 00:09:26 +0000 Received: by mail-oa1-x30.google.com with SMTP id 586e51a60fabf-1fb13a0951bso1955266fac.3 for ; Mon, 11 Dec 2023 16:09:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neon.tech; s=google; t=1702339763; x=1702944563; darn=postgresql.org; h=from:to:subject:message-id:date:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=i1wbB+5JkLcaWoGif/wQA8n//1vVvp7YtsD0cFEJYIU=; b=FCMoH4alGwGJhHw+jCE87wK96ggULZ+tjYwkmVMwZyDhs4IK71y+i1NaO5Jdd5Zk8R iXF3UA3armdmt84AmB7axQu1LLfOGdJZJn3JXfXmF63chw2y9KwgRgs7LB2OdZ2FysQ+ /xAuMVjUdTSc9ulwOKozzZvQKcninVibvbIzE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702339763; x=1702944563; h=from:to:subject:message-id:date:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=i1wbB+5JkLcaWoGif/wQA8n//1vVvp7YtsD0cFEJYIU=; b=O/HQlV46nf66mRPvgl9TmA3+WkvIWxDEaWPmN+IR86r1gt2IIhqhkUlPclprvGcLCP 09/yIo0dA0MLckMmhf80qgIV4KzTUp21LNQV4s+IuRhGsXfSZ0BuRfPiP2RmRXUS0u+f kjsNn/fZj1U4hC8wAQr3F0yWK1lfaQ1xoKqdPEoLVq1b7b4V/UJXH9JP3KrqytIbTMZE No0P+eCd1qH8kVTsa4j8HILTKDEVAqTK237EReXdXo3omfk0FGSytl8pWj166nedyhmk 28tWBvuMIQH8R0RzPtEBPDJ+rQlroVBSTDmAaV9vy6rExeq1q0gy1piLgjTT+FBnEmVV Qz7Q== X-Gm-Message-State: AOJu0YyhIsm+BguPULW79QKoOZKtHJZe5kolqLXz7hG8FDFNGNJa6emQ EcklwKXNZh1uJrds9+0qPJAVTGI/DIg5ZuU2LV0= X-Google-Smtp-Source: AGHT+IG9s+gdI9cc53KSSlzsBhz6R/3k/dxh7UW9xisVpeNtrbZWcKesYDPsiXEqkvmJcn2XRWmaJg== X-Received: by 2002:a05:6871:a917:b0:1fb:75b:2b93 with SMTP id wn23-20020a056871a91700b001fb075b2b93mr2873260oab.79.1702339762842; Mon, 11 Dec 2023 16:09:22 -0800 (PST) Received: from localhost ([2607:fb90:e64f:544c:3996:e070:71ee:42fb]) by smtp.gmail.com with ESMTPSA id u1-20020a9d4d81000000b006d9a3503677sm1980942otk.48.2023.12.11.16.09.21 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 Dec 2023 16:09:22 -0800 (PST) Content-Type: multipart/mixed; boundary=904f534c3265bf0f684da8385f39ad73c221a47e450aaf783ced2480fa47 Mime-Version: 1.0 Date: Mon, 11 Dec 2023 18:09:21 -0600 Message-Id: Subject: Add --check option to pgindent To: From: "Tristan Partin" X-Mailer: aerc 0.16.0-88-g66b9d36b9231 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --904f534c3265bf0f684da8385f39ad73c221a47e450aaf783ced2480fa47 Content-Type: multipart/alternative; boundary=cfec07cb79cb3341086c9687ed8f65a99264d3baa8c69fd171985e50d027 --cfec07cb79cb3341086c9687ed8f65a99264d3baa8c69fd171985e50d027 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Content-Type: text/plain; charset=UTF-8; format=Flowed Not sold on the name, but --check is a combination of --silent-diff and=20 --show-diff. I envision --check mostly being used in CI environments.=20 I recently came across a situation where this behavior would have been=20 useful. Without --check, you're left to capture the output of=20 --show-diff and exit 2 if the output isn't empty by yourself. --=20 Tristan Partin Neon (https://neon.tech) --cfec07cb79cb3341086c9687ed8f65a99264d3baa8c69fd171985e50d027-- --904f534c3265bf0f684da8385f39ad73c221a47e450aaf783ced2480fa47 Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=v1-0001-Add-check-option-to-pgindent.patch Content-Type: text/x-patch; charset=utf-8; name=v1-0001-Add-check-option-to-pgindent.patch RnJvbSAxMDAxMjUyZDQ5YTQ3ZTY2MDA0NWNlZTNkMmJhNWFiZDg3ZTkyNWQ5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUcmlzdGFuIFBhcnRpbiA8dHJpc3RhbkBuZW9uLnRlY2g+CkRh dGU6IE1vbiwgMTEgRGVjIDIwMjMgMTc6MzQ6MTcgLTA2MDAKU3ViamVjdDogW1BBVENIIHYxXSBB ZGQgLS1jaGVjayBvcHRpb24gdG8gcGdpbmRlbnQKClRoZSBvcHRpb24gaXMgYSBjb21iaW5hdGlv biBvZiAtLXNob3ctZGlmZiBhbmQgLS1zaWxlbnQtZGlmZi4gSXQgaXMKdXNlZnVsIGZvciBzaXR1 YXRpb25zIHN1Y2ggYXMgQ0kgY2hlY2tzIHdoZXJlIHRoZSBkaWZmIGNhbiBiZSBsb2dnZWQsCmJ1 dCB3aWxsIGFsc28gY2F1c2UgdGhlIGJ1aWxkIHRvIGZhaWwuIFdpdGhvdXQgc3VjaCBhbiBvcHRp b24sIHBlb3BsZQphcmUgbGVmdCB0byByZS1pbXBsZW1lbnQgdGhlIHNhbWUgbG9naWMgb3ZlciBh bmQgb3ZlciBhZ2Fpbi4KLS0tCiBzcmMvdG9vbHMvcGdpbmRlbnQvcGdpbmRlbnQgfCAyMCArKysr KysrKysrKysrKysrKy0tLQogMSBmaWxlIGNoYW5nZWQsIDE3IGluc2VydGlvbnMoKyksIDMgZGVs ZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvc3JjL3Rvb2xzL3BnaW5kZW50L3BnaW5kZW50IGIvc3Jj L3Rvb2xzL3BnaW5kZW50L3BnaW5kZW50CmluZGV4IGJjZTYzZDk1ZGEuLmEyODUwMTVjNzYgMTAw NzU1Ci0tLSBhL3NyYy90b29scy9wZ2luZGVudC9wZ2luZGVudAorKysgYi9zcmMvdG9vbHMvcGdp bmRlbnQvcGdpbmRlbnQKQEAgLTIzLDcgKzIzLDggQEAgbXkgJGRldm51bGwgPSBGaWxlOjpTcGVj LT5kZXZudWxsOwogCiBteSAoJHR5cGVkZWZzX2ZpbGUsICR0eXBlZGVmX3N0ciwgQGV4Y2x1ZGVz LAogCSRpbmRlbnQsICRidWlsZCwgJHNob3dfZGlmZiwKLQkkc2lsZW50X2RpZmYsICRoZWxwLCBA Y29tbWl0cywpOworCSRzaWxlbnRfZGlmZiwgJGhlbHAsIEBjb21taXRzLAorCSRjaGVjaywpOwog CiAkaGVscCA9IDA7CiAKQEAgLTM1LDcgKzM2LDggQEAgbXkgJW9wdGlvbnMgPSAoCiAJImV4Y2x1 ZGVzPXMiID0+IFxAZXhjbHVkZXMsCiAJImluZGVudD1zIiA9PiBcJGluZGVudCwKIAkic2hvdy1k aWZmIiA9PiBcJHNob3dfZGlmZiwKLQkic2lsZW50LWRpZmYiID0+IFwkc2lsZW50X2RpZmYsKTsK Kwkic2lsZW50LWRpZmYiID0+IFwkc2lsZW50X2RpZmYsCisJImNoZWNrIiA9PiBcJGNoZWNrLCk7 CiBHZXRPcHRpb25zKCVvcHRpb25zKSB8fCB1c2FnZSgiYmFkIGNvbW1hbmQgbGluZSBhcmd1bWVu dCIpOwogCiB1c2FnZSgpIGlmICRoZWxwOwpAQCAtNDMsNiArNDUsMTIgQEAgdXNhZ2UoKSBpZiAk aGVscDsKIHVzYWdlKCJDYW5ub3QgaGF2ZSBib3RoIC0tc2lsZW50LWRpZmYgYW5kIC0tc2hvdy1k aWZmIikKICAgaWYgJHNpbGVudF9kaWZmICYmICRzaG93X2RpZmY7CiAKK3VzYWdlKCJDYW5ub3Qg aGF2ZSBib3RoIC0tY2hlY2sgYW5kIC0tc2hvdy1kaWZmIikKKyAgaWYgJGNoZWNrICYmICRzaG93 X2RpZmY7CisKK3VzYWdlKCJDYW5ub3QgaGF2ZSBib3RoIC0tY2hlY2sgYW5kIC0tc2lsZW50LWRp ZmYiKQorICBpZiAkY2hlY2sgJiYgJHNpbGVudF9kaWZmOworCiB1c2FnZSgiQ2Fubm90IHVzZSAt LWNvbW1pdCB3aXRoIGNvbW1hbmQgbGluZSBmaWxlIGxpc3QiKQogICBpZiAoQGNvbW1pdHMgJiYg QEFSR1YpOwogCkBAIC0zMjUsNiArMzMzLDcgQEAgT3B0aW9uczoKIAktLWluZGVudD1QQVRIICAg ICAgICAgICBwYXRoIHRvIHBnX2JzZF9pbmRlbnQgcHJvZ3JhbQogCS0tc2hvdy1kaWZmICAgICAg ICAgICAgIHNob3cgdGhlIGNoYW5nZXMgdGhhdCB3b3VsZCBiZSBtYWRlCiAJLS1zaWxlbnQtZGlm ZiAgICAgICAgICAgZXhpdCB3aXRoIHN0YXR1cyAyIGlmIGFueSBjaGFuZ2VzIHdvdWxkIGJlIG1h ZGUKKwktLWNoZWNrICAgICAgICAgICAgICAgICBjb21iaW5hdGlvbiBvZiAtLXNob3ctZGlmZiBh bmQgLS1zaWxlbnQtZGlmZgogVGhlIC0tZXhjbHVkZXMgYW5kIC0tY29tbWl0IG9wdGlvbnMgY2Fu IGJlIGdpdmVuIG1vcmUgdGhhbiBvbmNlLgogRU9GCiAJaWYgKCRoZWxwKQpAQCAtNDE3LDcgKzQy NiwxMiBAQCBmb3JlYWNoIG15ICRzb3VyY2VfZmlsZW5hbWUgKEBmaWxlcykKIAogCWlmICgkc291 cmNlIG5lICRvcmlnX3NvdXJjZSkKIAl7Ci0JCWlmICgkc2lsZW50X2RpZmYpCisJCWlmICgkY2hl Y2spCisJCXsKKwkJCXByaW50IHNob3dfZGlmZigkc291cmNlLCAkc291cmNlX2ZpbGVuYW1lKTsK KwkJCWV4aXQgMjsKKwkJfQorCQllbHNpZiAoJHNpbGVudF9kaWZmKQogCQl7CiAJCQlleGl0IDI7 CiAJCX0KLS0gClRyaXN0YW4gUGFydGluCk5lb24gKGh0dHBzOi8vbmVvbi50ZWNoKQoK --904f534c3265bf0f684da8385f39ad73c221a47e450aaf783ced2480fa47--