Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8; format=Flowed
Date: Wed, 13 Dec 2023 11:23:50 -0600
Message-Id: <CXNDPJZ3TMF7.E06EJFULOOZI@neon.tech>
To: "Tom Lane" <tgl@sss.pgh.pa.us>
From: "Tristan Partin" <tristan@neon.tech>
Cc: <pgsql-hackers@postgresql.org>, "Andrew Dunstan" <andrew@dunslane.net>
Subject: Re: Clean up find_typedefs and add support for Mac
References: <CXMO0W1VX6GZ.NGSL94S57W1Z@neon.tech>
 <2490307.1702422146@sss.pgh.pa.us>
In-Reply-To: <2490307.1702422146@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/CXNDPJZ3TMF7.E06EJFULOOZI%40neon.tech>
Precedence: bulk

On Tue Dec 12, 2023 at 5:02 PM CST, Tom Lane wrote:
> "Tristan Partin" <tristan@neon.tech> writes:
> > The big patch here is adding support for Mac. objdump -W doesn't work o=
n=20
> > Mac. So, I used dsymutil and dwarfdump to achieve the same result.
>
> We should probably nuke the current version of src/tools/find_typedef
> altogether in favor of copying the current buildfarm code for that.
> We know that the buildfarm's version works, whereas I'm not real sure
> that src/tools/find_typedef is being used in anger by anyone.  Also,
> we're long past the point where developers can avoid having Perl
> installed.
>
> Ideally, the buildfarm client would then start to use find_typedef
> from the tree rather than have its own copy, both to reduce
> duplication and to ensure that the in-tree copy keeps working.

That makes sense to me. Where can I find the buildfarm code to propose=20
a different patch, at least pulling in the current state of the=20
buildfarm script? Or perhaps Andrew is the best person for this job.

--=20
Tristan Partin
Neon (https://neon.tech)