Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rFc6c-00Awdl-Bc for pgsql-hackers@arkaria.postgresql.org; Tue, 19 Dec 2023 15:34:02 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rFc6a-002FAn-6E for pgsql-hackers@arkaria.postgresql.org; Tue, 19 Dec 2023 15:34:00 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rFc6Z-002FAa-Rw for pgsql-hackers@lists.postgresql.org; Tue, 19 Dec 2023 15:33:59 +0000 Received: from mail-ot1-x32e.google.com ([2607:f8b0:4864:20::32e]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1rFc6X-00BBgE-0N for pgsql-hackers@postgresql.org; Tue, 19 Dec 2023 15:33:58 +0000 Received: by mail-ot1-x32e.google.com with SMTP id 46e09a7af769-6d9f879f784so3625880a34.2 for ; Tue, 19 Dec 2023 07:33:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neon.tech; s=google; t=1703000036; x=1703604836; darn=postgresql.org; h=in-reply-to:references:to:subject:cc:from:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=9bIZX2JtYBjqbU6YKzDZcJKPNnzEhdnmZ84jmD073Tk=; b=HjEmuxCdcfaBIgLk14eKzF3Yy3Xi+TvTwe6MEYl3Z4HTXn6V3gJSeZL24PVGwKDlGo hCgTQLj2EO1CQ81ScRVmwJHuIYy/IKPxovB3a6QaiYtIw2TH3SfjC+6eMbjR8Bdx/wQn SShmoUWNJjb+FRZydgpRLKyjclDbz2L/+ibbE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703000036; x=1703604836; h=in-reply-to:references:to:subject:cc:from:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=9bIZX2JtYBjqbU6YKzDZcJKPNnzEhdnmZ84jmD073Tk=; b=PGpURs5lJbM6k9w3/fOjsrrNHvIXUoOmcYgC5JAFhnpafxxQSAVOC2ZcsG+5Xz+O1T g9juQHQjguxfKgcZv5T0Um8tOhS3FdCHjXuxjwlYT1vWc/xJltmeNM5Qoe1WbqHb2y8I GGbFnaqCqgzQkBGELDlxSJix8oEQxd0Fq5d9qQsDDIV7Qi0MsH2Yms8p4vTMcZDt/TjG 9tB4m2hGvqW6gPBpQplZmHDoFalaFm+VByKf5E2rmLcdnO1tNa/7DXVq+dmcjRAptkUo up1qwJJqKGSjof4IdG+0Pz9baO409rZQPrdpFQrlX4QwW+GBKxYlHuyV2chSwQutFnyA lltA== X-Gm-Message-State: AOJu0YywtUQfi1nxjaFQCu5m+YnEcEYXA0Ica42ust9lsNw7RoGPjmE6 r/G68eqto2synIlsOjU9k+4GzPwLFBf0SrD1sZ2DYw== X-Google-Smtp-Source: AGHT+IFDGi/3LYMlDuz1c6pRYuuD+0TZSXBD5jNy3aDsdCvL3hS8e6kGPZv4f8Gh6ESsxn9KtW1j2w== X-Received: by 2002:a9d:6c56:0:b0:6d9:e15c:79bc with SMTP id g22-20020a9d6c56000000b006d9e15c79bcmr18720142otq.68.1703000036456; Tue, 19 Dec 2023 07:33:56 -0800 (PST) Received: from localhost ([2600:1700:210:c270::3b]) by smtp.gmail.com with ESMTPSA id j9-20020a056830014900b006d853a36d07sm5039802otp.55.2023.12.19.07.33.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 Dec 2023 07:33:55 -0800 (PST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8; format=Flowed Date: Tue, 19 Dec 2023 09:33:54 -0600 Message-Id: From: "Tristan Partin" Cc: "Andrew Dunstan" , "Alvaro Herrera" , "Tom Lane" , "Euler Taveira" , "Michael Banck" , "PostgreSQL Hackers" Subject: Re: Add --check option to pgindent To: "Tristan Partin" , "Jelte Fennema-Nio" , "Daniel Gustafsson" X-Mailer: aerc 0.16.0-93-gbd29700e708d References: <202312121530.7vztxm3bfyrx@alvherre.pgsql> <4b390361-484d-7598-ac13-db2dd7072ad3@dunslane.net> <46DAFBD4-0387-4F8B-96A2-A39499600C32@yesql.se> In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Mon Dec 18, 2023 at 3:18 PM CST, Tristan Partin wrote: > On Mon Dec 18, 2023 at 10:50 AM CST, Tristan Partin wrote: > > On Mon Dec 18, 2023 at 10:14 AM CST, Jelte Fennema-Nio wrote: > > > On Mon, 18 Dec 2023 at 13:42, Daniel Gustafsson wro= te: > > > > I think this is pretty much ready to go, the attached v4 squashes t= he changes > > > > and fixes the man-page which also needed an update. The referenced= Wiki page > > > > will need an edit or two after this goes in, but that's easy enough= . > > > > > > One thing I'm wondering: When both --check and --diff are passed, > > > should pgindent still early exit with 2 on the first incorrectly > > > formatted file? Or should it show diffs for all failing files? I'm > > > leaning towards the latter making more sense. > > > > Makes sense. Let me iterate on the squashed version of the patch. > > Here is an additional patch which implements the behavior you described.= =20 > The first patch is just Daniel's squashed version of my patches. Assuming all this is good, I now have access to edit the Wiki. The PR=20 for buildfarm client code is up, and hopefully that PR is correct. --=20 Tristan Partin Neon (https://neon.tech)