Content-Type: multipart/mixed;
 boundary=1a8676cad4b823d9fde66fa7dc22bf7add8b29d19bbda0f53fcdb2adf0dd
Mime-Version: 1.0
Date: Tue, 19 Dec 2023 14:43:49 -0600
Message-Id: <CXSLPXNZVASK.7Y7JSMC2FTK9@neon.tech>
Subject: Add support for __attribute__((returns_nonnull))
To: "pgsql-hackers" <pgsql-hackers@postgresql.org>
From: "Tristan Partin" <tristan@neon.tech>
Archived-At: <https://www.postgresql.org/message-id/CXSLPXNZVASK.7Y7JSMC2FTK9%40neon.tech>
Precedence: bulk

--1a8676cad4b823d9fde66fa7dc22bf7add8b29d19bbda0f53fcdb2adf0dd
Content-Type: multipart/alternative;
 boundary=44c4dbc01f3f555809da5e630a41454f5a213d242eef04b4bf9537facce3

--44c4dbc01f3f555809da5e630a41454f5a213d242eef04b4bf9537facce3
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Content-Type: text/plain; charset=UTF-8; format=Flowed

Here is a patch which adds support for the returns_nonnull attribute=20
alongside all the other attributes we optionally support.

I recently wound up in a situation where I was checking for NULL return=20
values of a function that couldn't ever return NULL because the=20
inability to allocate memory was always elog(ERROR)ed (aborted).

I didn't go through and mark anything, but I feel like it could be=20
useful for people going forward, including myself.

--=20
Tristan Partin
Neon (https://neon.tech)

--44c4dbc01f3f555809da5e630a41454f5a213d242eef04b4bf9537facce3--

--1a8676cad4b823d9fde66fa7dc22bf7add8b29d19bbda0f53fcdb2adf0dd
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
 filename=v1-0001-Add-support-for-__attribute__-returns_nonnull.patch
Content-Type: text/x-patch; charset=utf-8;
 name=v1-0001-Add-support-for-__attribute__-returns_nonnull.patch

RnJvbSAxNWEzNmQ2ODUxOWIzMzJlN2FlOTcwNzA4Mzk5NzQ0Y2JjNjljNmMzIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBUcmlzdGFuIFBhcnRpbiA8dHJpc3RhbkBuZW9uLnRlY2g+CkRh
dGU6IFR1ZSwgMTkgRGVjIDIwMjMgMTQ6Mzk6MDMgLTA2MDAKU3ViamVjdDogW1BBVENIIHYxXSBB
ZGQgc3VwcG9ydCBmb3IgX19hdHRyaWJ1dGVfXygocmV0dXJuc19ub25udWxsKSkKCkFsbG93cyBm
b3IgbWFya2luZyBmdW5jdGlvbnMgdGhhdCBjYW4ndCBwb3NzaWJseSByZXR1cm4gTlVMTCwgbGlr
ZSB0aG9zZQp0aGF0IGFsd2F5cyBlbG9nKEVSUk9SKSBmb3IgaW5zdGFuY2UgaW4gdGhlIGNhc2Ug
b2YgZmFpbHVyZXMuCi0tLQogc3JjL2luY2x1ZGUvYy5oIHwgMTIgKysrKysrKysrKysrCiAxIGZp
bGUgY2hhbmdlZCwgMTIgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL3NyYy9pbmNsdWRlL2Mu
aCBiL3NyYy9pbmNsdWRlL2MuaAppbmRleCAyNmJmN2VjMTZlLi5lM2ExMjdmOTU0IDEwMDY0NAot
LS0gYS9zcmMvaW5jbHVkZS9jLmgKKysrIGIvc3JjL2luY2x1ZGUvYy5oCkBAIC0yODUsNiArMjg1
LDE4IEBACiAjZGVmaW5lIHBnX3VucmVhY2hhYmxlKCkgYWJvcnQoKQogI2VuZGlmCiAKKy8qCisg
KiBQbGFjZSBvbiBmdW5jdGlvbnMgd2hpY2ggcmV0dXJuIGEgcG9pbnRlciBidXQgY2FuJ3QgcmV0
dXJuIE5VTEwuIFdoZW4gdXNlZCwKKyAqIGl0IGNhbiBhbGxvdyB0aGUgY29tcGlsZXIgdG8gd2Fy
biBpZiBhIE5VTEwgY2hlY2sgb2NjdXJzIGluIHRoZSBwYXJlbnQKKyAqIGZ1bmN0aW9uIGJlY2F1
c2UgdGhhdCBOVUxMIGNoZWNrIHdvdWxkIGFsd2F5cyBmYWlsLiBJdCBpcyBhbHNvIGFuIG9wcG9y
dHVuaXR5CisgKiB0byBoZWxwIHRoZSBjb21waWxlciB3aXRoIG9wdGltaXphdGlvbnMuCisgKi8K
KyNpZiBfX2hhc19hdHRyaWJ1dGUgKHJldHVybnNfbm9ubnVsbCkKKyNkZWZpbmUgcGdfcmV0dXJu
c19ub25udWxsIF9fYXR0cmlidXRlX18oKHJldHVybnNfbm9ubnVsbCkpCisjZWxzZQorI2RlZmlu
ZSBwZ19yZXR1cm5zX25vbm51bGwKKyNlbmRpZgorCiAvKgogICogSGludHMgdG8gdGhlIGNvbXBp
bGVyIGFib3V0IHRoZSBsaWtlbGlob29kIG9mIGEgYnJhbmNoLiBCb3RoIGxpa2VseSgpIGFuZAog
ICogdW5saWtlbHkoKSByZXR1cm4gdGhlIGJvb2xlYW4gdmFsdWUgb2YgdGhlIGNvbnRhaW5lZCBl
eHByZXNzaW9uLgotLSAKVHJpc3RhbiBQYXJ0aW4KTmVvbiAoaHR0cHM6Ly9uZW9uLnRlY2gpCgo=
--1a8676cad4b823d9fde66fa7dc22bf7add8b29d19bbda0f53fcdb2adf0dd--