Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rFyfy-00D1Wx-3k for pgsql-hackers@arkaria.postgresql.org; Wed, 20 Dec 2023 15:40:02 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rFyfw-00E2P4-RJ for pgsql-hackers@arkaria.postgresql.org; Wed, 20 Dec 2023 15:40:00 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rFyfw-00E2Ov-Gm for pgsql-hackers@lists.postgresql.org; Wed, 20 Dec 2023 15:40:00 +0000 Received: from mail-yw1-x112e.google.com ([2607:f8b0:4864:20::112e]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1rFyft-00BLrg-Op for pgsql-hackers@lists.postgresql.org; Wed, 20 Dec 2023 15:39:59 +0000 Received: by mail-yw1-x112e.google.com with SMTP id 00721157ae682-5e637faa52fso30132017b3.1 for ; Wed, 20 Dec 2023 07:39:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neon.tech; s=google; t=1703086797; x=1703691597; darn=lists.postgresql.org; h=in-reply-to:references:from:to:cc:subject:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=VKLbqDLe/j0DD0eT++sTFr35234RaPDEpPB15HaaVNo=; b=qT91mmpvU2NJ+G42SJnGQcgQQ8UZvxs/ZWOZdjuYZUay25zJEnC26xSNaReSggs17e 8VNoyhA36RtyQgqWOnGpTRaQJHXLY2zRfxpet6MYDOnx+pLHHUv4D664QNInetOagI6D Ap3hUzpQ8i1tuxu24vSv6Q6N8/IOJEdZCZ4CU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703086797; x=1703691597; h=in-reply-to:references:from:to:cc:subject:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=VKLbqDLe/j0DD0eT++sTFr35234RaPDEpPB15HaaVNo=; b=reS4XBHOhQuw1s9zMmJxOJECGg03lApbxORq/bac1LYzPrYAwVlzaMsgdkqPU1MBXA KWzUkO5shabU4uulSbox2R5Rem5wbfJGc8ks7YQT6UGO+0OY0j/MBnCblV7yVdvy+5Br lDO8qcIwxBgEtVtR/zrTw2xIX16uPiuWfecXX0ZqLRPvLSMlhbCH+LKc9vO890+C6itb aPp6lNZMy/cUlnKhbdYKHXbC5nX9OchBDSFqfISXdz/PkoHr8Y4vKCQ1+7WmydlDNt6W D2ufjKg2Yu91eVMUWRR2+K4rMD1y33rplhjmzELcVeAQACBLfps9Vjjmo84HDOWQhuPV XIBQ== X-Gm-Message-State: AOJu0YzEFEt2nUc3/SF61PeUssWvJMuFiExV5OpzeSl0SEfJxfdP6bzS h5xvYaLjPtp27EDc/NH68T5YaSqn3os/81KD1N6EGQ== X-Google-Smtp-Source: AGHT+IGyUCNuyMgsTv+FOfvr8tB5umEppQ+p1byZo9toDu/H2usvuL6cq7E1NaWkxVu3UW9CYwADpQ== X-Received: by 2002:a0d:dd14:0:b0:5e7:cf73:e98d with SMTP id g20-20020a0ddd14000000b005e7cf73e98dmr2392521ywe.41.1703086796889; Wed, 20 Dec 2023 07:39:56 -0800 (PST) Received: from localhost ([2600:1700:210:c270::3b]) by smtp.gmail.com with ESMTPSA id y4-20020a0def04000000b005a7daa09f43sm10795642ywe.125.2023.12.20.07.39.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Dec 2023 07:39:56 -0800 (PST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8; format=Flowed Date: Wed, 20 Dec 2023 09:39:55 -0600 Message-Id: Subject: Re: Unchecked strdup leading to segfault in pg_dump Cc: "Postgres hackers" To: "Daniel Gustafsson" From: "Tristan Partin" X-Mailer: aerc 0.16.0-93-gbd29700e708d References: In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Wed Dec 20, 2023 at 8:52 AM CST, Daniel Gustafsson wrote: > While looking at something else I noticed that pg_dump performs strdup wi= thout > checking the returned pointer, which will segfault in hasSuffix() in case= of > OOM. The attached, which should be backpatched to 16, changes to using > pg_strdup instead which handles it. Looks good to me. --=20 Tristan Partin Neon (https://neon.tech)