public inbox for [email protected]
help / color / mirror / Atom feedFrom: Srirama Kucherlapati <[email protected]>
To: Heikki Linnakangas <[email protected]>
To: Laurenz Albe <[email protected]>
To: Bruce Momjian <[email protected]>
To: Heikki Linnakangas <[email protected]>
Cc: Peter Eisentraut <[email protected]>
Cc: Alvaro Herrera <[email protected]>
Cc: [email protected] <[email protected]>
Cc: Noah Misch <[email protected]>
Cc: Michael Paquier <[email protected]>
Cc: Andres Freund <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: Thomas Munro <[email protected]>
Cc: [email protected] <[email protected]>
Cc: [email protected] <[email protected]>
Subject: RE: AIX support
Date: Wed, 19 Jun 2024 15:57:08 +0000
Message-ID: <CY8PR15MB560282A99569E110AEED3257DBCF2@CY8PR15MB5602.namprd15.prod.outlook.com> (raw)
In-Reply-To: <[email protected]>
References: <CY5PR11MB639218D04CFAED0FC09ED9DFFDED2@CY5PR11MB6392.namprd11.prod.outlook.com>
<[email protected]>
<CY5PR11MB6392F178646E31D9BF417118FDEB2@CY5PR11MB6392.namprd11.prod.outlook.com>
<[email protected]>
<DS0PR15MB5623A624B285AF799705C50ADBF42@DS0PR15MB5623.namprd15.prod.outlook.com>
<[email protected]>
<[email protected]>
<CY8PR15MB5602AA47C13A33DBF68BEA73DBFB2@CY8PR15MB5602.namprd15.prod.outlook.com>
<[email protected]>
<CY8PR15MB56029161FE37A1DE9DE36B70DBC72@CY8PR15MB5602.namprd15.prod.outlook.com>
<CY8PR15MB5602CAFFE00371049D68CD25DBCD2@CY8PR15MB5602.namprd15.prod.outlook.com>
<[email protected]>
Thanks Hikki, for going through the changes.
> +/* Commenting for XLC
> + * "IBM XL C/C++ for AIX, V12.1" miscompiles, for 32-bit, some inline
> + * expansions of ginCompareItemPointers() "long long" arithmetic. To take
> + * advantage of inlining, build a 64-bit PostgreSQL.
> +#if defined(__ILP32__) && defined(__IBMC__)
> +#define PG_FORCE_DISABLE_INLINE
> +#endif
> + */
I can remove these unwanted comments.
I have to analyze the changes for the rest of your comment and will get back to you.
Warm regards,
Sriram.
From: Heikki Linnakangas <[email protected]>
Date: Wednesday, 19 June 2024 at 8:45 PM
To: Srirama Kucherlapati <[email protected]>, Laurenz Albe <[email protected]>, Bruce Momjian <[email protected]>, Heikki Linnakangas <[email protected]>
Cc: Peter Eisentraut <[email protected]>, Alvaro Herrera <[email protected]>, [email protected] <[email protected]>, Noah Misch <[email protected]>, Michael Paquier <[email protected]>, Andres Freund <[email protected]>, Tom Lane <[email protected]>, Thomas Munro <[email protected]>, [email protected] <[email protected]>, [email protected] <[email protected]>
Subject: [EXTERNAL] Re: AIX support
On 19/06/2024 17:55, Srirama Kucherlapati wrote:
> +/* Commenting for XLC
> + * "IBM XL C/C++ for AIX, V12.1" miscompiles, for 32-bit, some inline
> + * expansions of ginCompareItemPointers() "long long" arithmetic. To take
> + * advantage of inlining, build a 64-bit PostgreSQL.
> +#if defined(__ILP32__) && defined(__IBMC__)
> +#define PG_FORCE_DISABLE_INLINE
> +#endif
> + */
This seems irrelevant.
> + * Ordinarily, we'd code the branches here using GNU-style local symbols, that
> + * is "1f" referencing "1:" and so on. But some people run gcc on AIX with
> + * IBM's assembler as backend, and IBM's assembler doesn't do local symbols.
> + * So hand-code the branch offsets; fortunately, all PPC instructions are
> + * exactly 4 bytes each, so it's not too hard to count.
Could you use GCC assembler to avoid this?
> @@ -662,6 +666,21 @@ tas(volatile slock_t *lock)
>
> #if !defined(HAS_TEST_AND_SET) /* We didn't trigger above, let's try here */
>
> +#if defined(_AIX) /* AIX */
> +/*
> + * AIX (POWER)
> + */
> +#define HAS_TEST_AND_SET
> +
> +#include <sys/atomic_op.h>
> +
> +typedef int slock_t;
> +
> +#define TAS(lock) _check_lock((slock_t *) (lock), 0, 1)
> +#define S_UNLOCK(lock) _clear_lock((slock_t *) (lock), 0)
> +#endif /* _AIX */
> +
> +
> /* These are in sunstudio_(sparc|x86).s */
>
> #if defined(__SUNPRO_C) && (defined(__i386) || defined(__x86_64__) || defined(__sparc__) || defined(__sparc))
What CPI/compiler/OS configuration is this for, exactly? Could we rely
on GCC-provided __sync_lock_test_and_set() builtin function instead?
> +# Allow platforms with buggy compilers to force restrict to not be
> +# used by setting $FORCE_DISABLE_RESTRICT=yes in the relevant
> +# template.
Surely we don't need that anymore? Or is the compiler still buggy?
Do you still care about 32-bit binaries on AIX? If not, let's make that
the default in configure or a check for it, and remove the instructions
on building 32-bit binaries from the docs.
Please try hard to remove any changes from the diff that are not
absolutely necessary.
- Heikki
view thread (20+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: RE: AIX support
In-Reply-To: <CY8PR15MB560282A99569E110AEED3257DBCF2@CY8PR15MB5602.namprd15.prod.outlook.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox