Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8; format=Flowed
Date: Wed, 17 Jan 2024 10:15:38 -0600
Message-Id: <CYH46EOI1L9I.2CBHTXWCEI65Y@neon.tech>
Cc: "pgsql-hackers" <pgsql-hackers@postgresql.org>, "Jelte Fennema-Nio"
 <postgres@jeltef.nl>
Subject: Re: Add pgindent test to check if codebase is correctly formatted
To: "Alvaro Herrera" <alvherre@alvh.no-ip.org>
From: "Tristan Partin" <tristan@neon.tech>
References: <CYGL6HF4TM36.2TFP4FVTVMB6A@neon.tech>
 <202401170950.fdfpjlne22yv@alvherre.pgsql>
In-Reply-To: <202401170950.fdfpjlne22yv@alvherre.pgsql>
Archived-At: 
 <https://www.postgresql.org/message-id/CYH46EOI1L9I.2CBHTXWCEI65Y%40neon.tech>
Precedence: bulk

On Wed Jan 17, 2024 at 3:50 AM CST, Alvaro Herrera wrote:
> Hmm, should this also install typedefs.list and pgindent.man?
> What about the tooling to reformat Perl code?

Good point about pgindent.man. It would definitely be good to install=20
alongside pgindent and pg_bsd_indent.

I don't know if we need to install the typedefs.list file. I think it=20
would just be good enough to also install the find_typedefs script. But=20
it needs some fixing up first[0]. Extension authors can then just=20
generate their own typedefs.list that will include the typedefs of the=20
extension and the typedefs of the postgres types they use. At least,=20
that is what we have found works at Neon.

I cannot vouch for extension authors writing Perl but I think it could=20
make sense to install the src/test/perl tree, so extension authors could=20
more easily write tests for their extensions in Perl. But we could=20
install the perltidy file and whatever else too. I keep my Perl writing=20
to a minimum, so I am not the best person to vouch for these usecases.

[0]: https://www.postgresql.org/message-id/aaa59ef5-dce8-7369-5cae-48772766=
4127%40dunslane.net

--=20
Tristan Partin
Neon (https://neon.tech)