Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rSfxX-00FCHY-85 for pgsql-hackers@arkaria.postgresql.org; Wed, 24 Jan 2024 16:18:39 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rSfxW-006Eac-Bt for pgsql-hackers@arkaria.postgresql.org; Wed, 24 Jan 2024 16:18:38 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rSfxW-006EZr-1Y for pgsql-hackers@lists.postgresql.org; Wed, 24 Jan 2024 16:18:38 +0000 Received: from mail-ot1-x332.google.com ([2607:f8b0:4864:20::332]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1rSfxT-003V2m-9D for pgsql-hackers@postgresql.org; Wed, 24 Jan 2024 16:18:37 +0000 Received: by mail-ot1-x332.google.com with SMTP id 46e09a7af769-6dde1f23060so3556721a34.2 for ; Wed, 24 Jan 2024 08:18:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neon.tech; s=google; t=1706113113; x=1706717913; darn=postgresql.org; h=in-reply-to:references:from:to:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=tQP3pJwJg2b/VwcxxvzrUM/O0ezuweL45jMHShJVsqo=; b=TjvYyp5nhsdK9zopL78HVfsnLwYNR+wdKXV/kOm4bj/HJLISWzyGSouqHYTS6Cr8pV ZLQqTNCUpNkMvzprliHDfCz2OHCYyY0FUs/I6dNisfcFrzRG8tWI/gfUQLGykG6sNzwd 07P6cbyZL4dIC4/tG2QCSAFsAFGUKtWahTFfc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706113113; x=1706717913; h=in-reply-to:references:from:to:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=tQP3pJwJg2b/VwcxxvzrUM/O0ezuweL45jMHShJVsqo=; b=kVmSH1FfpMFE5+KrYpSwmkNrLN6Fjtio6OeyrsJn2VMiKQBqkZ5V8CCdi4H1XPQOUy 3+8m/UJq0tNkhxZO9k9Mkdo9SM9BaLm0Sg5y+wI2uQJgm5uMXL8b+AZy1hA8Y9fnM5tB 6FuQn/QRACUFlADZv5HO3uaHppCdupsiO86c5I0aZXMY6DntpGu/gKm8ulNDvlwpNYoA iG3eB2dDH8KGalEafLSgvjFGC3ZJt0hz9yQQldm/l7afBvDfxcJbIbDdLfTKmx444pwQ c00ueeifTqTsasabmZLVKzD5+UPLi3GdlnioNOXqniYZFKBmNXhacapza4Wy8vWAiGGT nzrw== X-Gm-Message-State: AOJu0Ywwh9ozrVqYdV5becGWAi6bxviq4hoesRBhSJuEgxhE3Woe9dIE C+68Hv+5AlQp0S10AUjP/ap5l8hOeQTI+ua709QxxCeudjS8OU92/oq5Sm8yzfQDC3wqai863QA d X-Google-Smtp-Source: AGHT+IHKZb/5YkGmYtbLGBc1GGlL73Wz+b+zZk6ae87V6hkMDrzeRdtTlX1cN5PlXPlo6Zu1Vsto7w== X-Received: by 2002:a05:6830:12d4:b0:6dc:375b:57e0 with SMTP id a20-20020a05683012d400b006dc375b57e0mr1662549otq.59.1706113112835; Wed, 24 Jan 2024 08:18:32 -0800 (PST) Received: from localhost ([2607:fb90:e683:8cf6:3996:e070:71ee:42fb]) by smtp.gmail.com with ESMTPSA id g19-20020a056830161300b006ddd897c37bsm2632911otr.37.2024.01.24.08.18.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Jan 2024 08:18:32 -0800 (PST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8; format=Flowed Date: Wed, 24 Jan 2024 10:18:31 -0600 Message-Id: Cc: "pgsql-hackers" Subject: Re: make dist using git archive To: "Peter Eisentraut" From: "Tristan Partin" X-Mailer: aerc 0.16.0-149-g2d8b81f619fc References: <40e80f77-a294-4f29-a16f-e21bc7bc75fc@eisentraut.org> <02714192-6eba-4145-ac1c-0a245801014f@eisentraut.org> In-Reply-To: <02714192-6eba-4145-ac1c-0a245801014f@eisentraut.org> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Tue Jan 23, 2024 at 3:30 AM CST, Peter Eisentraut wrote: > On 22.01.24 21:04, Tristan Partin wrote: > > I am not really following why we can't use the builtin Meson dist=20 > > command. The only difference from my testing is it doesn't use a=20 > > --prefix argument. > > Here are some problems I have identified: > > 1. meson dist internally runs gzip without the -n option. That makes=20 > the tar.gz archive include a timestamp, which in turn makes it not=20 > reproducible. > > 2. Because gzip includes a platform indicator in the archive, the=20 > produced tar.gz archive is not reproducible across platforms. (I don't= =20 > know if gzip has an option to avoid that. git archive uses an internal= =20 > gzip implementation that handles this.) > > 3. Meson does not support tar.bz2 archives. > > 4. Meson uses git archive internally, but then unpacks and repacks the=20 > archive, which loses the ability to use git get-tar-commit-id. > > 5. I have found that the tar archives created by meson and git archive=20 > include the files in different orders. I suspect that the Python=20 > tarfile module introduces some either randomness or platform dependency. > > 6. meson dist is also slower because of the additional work. > > 7. meson dist produces .sha256sum files but we have called them .sha256.= =20 > (This is obviously trivial, but it is something that would need to be= =20 > dealt with somehow nonetheless.) > > Most or all of these issues are fixable, either upstream in Meson or by= =20 > adjusting our own requirements. But for now this route would have some= =20 > significant disadvantages. Thanks Peter. I will bring these up with upstream! --=20 Tristan Partin Neon (https://neon.tech)