Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8; format=Flowed
Date: Fri, 26 Jan 2024 13:46:36 -0600
Message-Id: <CYOWATSP6ZAI.20MLCCV55GHJG@neon.tech>
Cc: "pgsql-hackers" <pgsql-hackers@postgresql.org>
Subject: Re: make dist using git archive
To: "Peter Eisentraut" <peter@eisentraut.org>
From: "Tristan Partin" <tristan@neon.tech>
References: <40e80f77-a294-4f29-a16f-e21bc7bc75fc@eisentraut.org>
 <CYLI6IZ5RAVR.3RBBF4F3P8MHX@neon.tech>
 <673bbcc2-3e38-44b6-9710-e7c1b2446334@eisentraut.org>
 <CYNXE6A4IB2S.V1YYOX54IVJ@neon.tech>
 <dbff5b4f-21a9-4340-82ee-884b13ee6a3d@eisentraut.org>
In-Reply-To: <dbff5b4f-21a9-4340-82ee-884b13ee6a3d@eisentraut.org>
Archived-At: 
 <https://www.postgresql.org/message-id/CYOWATSP6ZAI.20MLCCV55GHJG%40neon.tech>
Precedence: bulk

On Fri Jan 26, 2024 at 12:28 AM CST, Peter Eisentraut wrote:
> On 25.01.24 17:25, Tristan Partin wrote:
> > For what it's worth, I run Meson 1.3, and the behavior of generating th=
e=20
> > tarballs even though it is a dirty tree still occurred. In the new patc=
h=20
> > you seem to say it was fixed in 0.60.
>
> The problem I'm referring to is that before 0.60, alias_target cannot=20
> depend on run_target (only "build target").  This is AFAICT not=20
> documented and might not have been an intentional change, but you can=20
> trace it in the meson source code, and it shows in the PostgreSQL CI.=20
> That's also why for the above bzip2 issue I have to use custom_target in=
=20
> place of your run_target.

https://github.com/mesonbuild/meson/pull/12783

Thanks for finding these issues.

--=20
Tristan Partin
Neon (https://neon.tech)