Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8; format=Flowed
Date: Fri, 01 Mar 2024 10:42:19 -0600
Message-Id: <CZIKAT2WH7YR.31FQYQ4XBO58J@neon.tech>
From: "Tristan Partin" <tristan@neon.tech>
Cc: "Pg Hackers" <pgsql-hackers@lists.postgresql.org>
Subject: Re: make BuiltinTrancheNames less ugly
To: "Alvaro Herrera" <alvherre@alvh.no-ip.org>, "Heikki Linnakangas"
 <hlinnaka@iki.fi>
References: <7f638c9c-8a15-4deb-a3a5-c1a445762fcd@iki.fi>
 <202403011400.znd4wzeofwnp@alvherre.pgsql>
In-Reply-To: <202403011400.znd4wzeofwnp@alvherre.pgsql>
Archived-At: <https://www.postgresql.org/message-id/CZIKAT2WH7YR.31FQYQ4XBO58J%40neon.tech>
Precedence: bulk

On Fri Mar 1, 2024 at 8:00 AM CST, Alvaro Herrera wrote:
> On 2024-Feb-23, Heikki Linnakangas wrote:
>
> > On 12/02/2024 19:01, Tristan Partin wrote:
> > > On Wed Jan 24, 2024 at 8:09 AM CST, Alvaro Herrera wrote:
> > > > IMO it would be less ugly to have the origin file lwlocknames.txt b=
e
> > > > not a text file but a .h with a macro that can be defined by
> > > > interested parties so that they can extract what they want from the
> > > > file, like PG_CMDTAG or PG_KEYWORD.  Using Perl for this seems dirt=
y...
> > >=20
> > > I really like this idea, and would definitely be more inclined to see
> > > a solution like this.
> >=20
> > +1 to that idea from me too. Seems pretty straightforward.
>
> OK, here's a patch that does it.  I have not touched Meson yet.
>
> I'm pretty disappointed of not being able to remove
> generate-lwlocknames.pl (it now generates the .h, no longer the .c
> file), but I can't find a way to do the equivalent #defines in CPP ...
> it'd require invoking the C preprocessor twice.  Maybe an intermediate
> .h file would solve the problem, but I have no idea how would that work
> with Meson.  I guess I'll do it in Make and let somebody suggest a Meson
> way.

I can help you with Meson if you get the Make implementation done.

--=20
Tristan Partin
Neon (https://neon.tech)