Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rs21D-004M0E-LJ for pgsql-hackers@arkaria.postgresql.org; Wed, 03 Apr 2024 14:55:16 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rs21C-003QbW-CG for pgsql-hackers@arkaria.postgresql.org; Wed, 03 Apr 2024 14:55:14 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rs21C-003Qal-0T for pgsql-hackers@lists.postgresql.org; Wed, 03 Apr 2024 14:55:14 +0000 Received: from mail-oo1-xc31.google.com ([2607:f8b0:4864:20::c31]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1rs219-000NDc-9H for pgsql-hackers@postgresql.org; Wed, 03 Apr 2024 14:55:12 +0000 Received: by mail-oo1-xc31.google.com with SMTP id 006d021491bc7-5a47cecb98bso4270126eaf.0 for ; Wed, 03 Apr 2024 07:55:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neon.tech; s=google; t=1712156110; x=1712760910; darn=postgresql.org; h=in-reply-to:references:from:to:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=OE+xOsM4i8cXPJW5GLREQ8CeHywWVjtXGYWzEvbhoJQ=; b=ktHBvMXwzKAt7Qi2/brJEyCVyYwTlTL58sNOHcRvF3JIjaOKYcqApgo6aD+5PjX4eQ aS7Gv+FUXbe4YoKDtHZVUWWxEoUNDjemsIuhnC7XESX7aE6qfVDpMEtpdspTT7PHy5J0 Yi8M+azWrxL17/5fmimCfms4fbYbvvvVgyx6w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712156110; x=1712760910; h=in-reply-to:references:from:to:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=OE+xOsM4i8cXPJW5GLREQ8CeHywWVjtXGYWzEvbhoJQ=; b=KUIYktPiB/7wJlRlcRBMJDp0J4hFqg8qf8lUIVYn+HKL15XesJGCM0UdKlTml0E+fi j9jMLMbpYOzsshfnN6PuqBzG6c6zuT3o1TErFevQ5S7kopbQuRSdp694VCTdY5/bXETd 5476lE5ztmvq8tLSknuBOFym1jPwLoXKL+ZsCs1NgTd/cHX8RMWgMM7Dbmc7gKkBtXBK LrecHuwLaR9Y8i9xsdtNjOs1PJly5yaI4iBU4M5lpdn63LwhFzqVr4LoNaz49FRm3WgV Szrr+1d21JTUqKO9eYzyU1dm9wBBD9PgeKjJO224uxK8XgAwuRII9Tp0Iki6oGLVuS7s bb5A== X-Forwarded-Encrypted: i=1; AJvYcCVNhU+OAhQ+sEAV9oK+/GXDnoE4DgwQNzq3rEul2cRoB9Wu+Q0ZqYl7pNg/erNF0U0DwqaZn0XYQZk+gqTARMVwZWwSsYBYzipTAIp/ X-Gm-Message-State: AOJu0YywkAWFIM7rGzD0kD4MBDC8jXhfonL9q8rWE6/L2DzPFgBMJzng rvEuLh/+VuDnwkxXlXWW3Uj+AHCY66TShNrdDHBLrmn7HXEwjHqLZrLMaRkQS6E= X-Google-Smtp-Source: AGHT+IE7t4aX672kq47EJtxQ27HvUxOvztFe0Kb4/Hf8WXJhTp6QhR5UPdJqynUauvL8vwMPH2D5Kw== X-Received: by 2002:a05:6820:208:b0:5a4:7696:6ba8 with SMTP id bw8-20020a056820020800b005a476966ba8mr14442083oob.7.1712156110544; Wed, 03 Apr 2024 07:55:10 -0700 (PDT) Received: from localhost ([2607:fb90:f22d:7a0:3996:e070:71ee:42fb]) by smtp.gmail.com with ESMTPSA id f14-20020a4abb0e000000b005a46d5bd558sm3240466oop.45.2024.04.03.07.55.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Apr 2024 07:55:09 -0700 (PDT) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8; format=Flowed Date: Wed, 03 Apr 2024 09:55:08 -0500 Message-Id: Cc: "Robert Haas" , "Heikki Linnakangas" , , "Shlok Kyal" Subject: Re: psql not responding to SIGINT upon db reconnection To: "Jelte Fennema-Nio" From: "Tristan Partin" X-Mailer: aerc 0.17.0-89-g28fde6118fca References: <1588058.1690220636@sss.pgh.pa.us> <5e28b89f-0033-4e42-8184-b71b731c1aa2@iki.fi> <9b3693b7-0bc3-430a-b43f-eae44e8a39b6@iki.fi> <032868e0-a530-4fc7-972c-af6f08950b7e@iki.fi> <2049574.1712154700@sss.pgh.pa.us> In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Wed Apr 3, 2024 at 9:50 AM CDT, Jelte Fennema-Nio wrote: > On Wed, 3 Apr 2024 at 16:31, Tom Lane wrote: > > If we do the latter, we will almost certainly get pushback from > > distros who check for library ABI breaks. I fear the comment > > suggesting that we could remove it someday is too optimistic. > > Alright, changed patch 0002 to keep the variant. But remove it from > the recently added switch/case. And also updated the comment to remove > the "for awhile". Removing from the switch statement causes a warning: > [1/2] Compiling C object src/bin/psql/psql.p/command.c.o > ../src/bin/psql/command.c: In function =E2=80=98wait_until_connected=E2= =80=99: > ../src/bin/psql/command.c:3803:17: warning: enumeration value =E2=80=98PG= RES_POLLING_ACTIVE=E2=80=99 not handled in switch [-Wswitch] > 3803 | switch (PQconnectPoll(conn)) > | ^~~~~~ --=20 Tristan Partin Neon (https://neon.tech)