public inbox for [email protected]  

help / color / mirror / Atom feed

From: Li, Yong <[email protected]>
To: Michael Paquier <[email protected]>
Cc: Bertrand Drouvot <[email protected]>
Cc: Jeff Davis <[email protected]>
Cc: Aleksander Alekseev <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Cc: Bagga, Rishu <[email protected]>
Cc: Robert Haas <[email protected]>
Cc: Andrey Borodin <[email protected]>
Cc: Shyrabokau, Anton <[email protected]>
Subject: Re: Proposal to add page headers to SLRU pages
Date: Thu, 13 Jun 2024 08:41:23 +0000
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<CAJ7c6TMrFrUF1W3nO=w+3mJu_G8UaQkMJh2aV9WhP20Xs0M_6g@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>



> On Jun 10, 2024, at 16:01, Michael Paquier <[email protected]> wrote:
> 
> External Email
> 
> From: Michael Paquier <[email protected]>
> Subject: Re: Proposal to add page headers to SLRU pages
> Date: June 10, 2024 at 16:01:50 GMT+8
> To: Bertrand Drouvot <[email protected]>
> Cc: "Li, Yong" <[email protected]>, Jeff Davis <[email protected]>, Aleksander Alekseev <[email protected]>, PostgreSQL Hackers <[email protected]>, "Bagga, Rishu" <[email protected]>, Robert Haas <[email protected]>, Andrey Borodin <[email protected]>, "Shyrabokau, Anton" <[email protected]>
> 
> 
> On Mon, Jun 10, 2024 at 07:19:56AM +0000, Bertrand Drouvot wrote:
>> On Tue, Mar 19, 2024 at 06:48:33AM +0000, Li, Yong wrote:
>>> Unfortunately, the test requires a setup of two different versions of PG. I am not
>>> aware of an existing test infrastructure which can run automated tests using two
>>> PGs. I did manually verify the output of pg_upgrade.
>> 
>> I think there is something in t/002_pg_upgrade.pl (see src/bin/pg_upgrade/TESTING),
>> that could be used to run automated tests using an old and a current version.
> 
> Cluster.pm relies on install_path for stuff, where it is possible to
> create tests with multiple nodes pointing to different installation
> paths.  This allows mixing nodes with different build options, or just
> different major versions like pg_upgrade's perl tests.
> —
> Michael
> 
> 

Thanks for pointing	this out. Here is what I have tried:
1. Manually build and install PostgreSQL from the latest source code.
2. Following the instructions from src/bin/pg_upgrade to manually dump the regression database.
3. Apply the patch to the latest code, and build from the source.
4. Run “make check” by following the instructions from src/bin/pg_upgrade and setting up the olddump and oldinstall to point to the “old” installation used in step 2.

All tests pass.


Yong

view thread (22+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Proposal to add page headers to SLRU pages
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox