Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8; format=Flowed
Date: Mon, 15 Apr 2024 16:06:03 -0500
Message-Id: <D0L038YNGLYO.D2Q6GHBR7U40@neon.tech>
Cc: <pgsql-hackers@lists.postgresql.org>
Subject: Re: SQL function which allows to distinguish a server being in
 point in time recovery mode and an ordinary replica
To: <m.litsarev@postgrespro.ru>
From: "Tristan Partin" <tristan@neon.tech>
References: <06c02ef916d85e77778e5cdfdf67a3df@postgrespro.ru>
In-Reply-To: <06c02ef916d85e77778e5cdfdf67a3df@postgrespro.ru>
Archived-At: <https://www.postgresql.org/message-id/D0L038YNGLYO.D2Q6GHBR7U40%40neon.tech>
Precedence: bulk

On Tue Mar 26, 2024 at 9:28 AM CDT, m.litsarev wrote:
> Hi,
>
> At present time, an existing pg_is_in_recovery() method is not enough
> to distinguish a server being in point in time recovery (PITR) mode and=
=20
> an ordinary replica
> because it returns true in both cases.
>
> That is why pg_is_standby_requested() function introduced in attached=20
> patch might help.
> It reports whether a standby.signal file was found in the data directory=
=20
> at startup process.
> Instructions for reproducing the possible use case are also attached.
>
> Hope it will be usefull.

Hey Mikhail,

Saw your patch for the first time today. Looks like your patch is messed=20
up? You seem to have more of the diff at the bottom which seems to add=20
a test. Want to send a v2 with a properly formatted patch?

Example command:

git format-patch -v2 -M HEAD^

--=20
Tristan Partin
Neon (https://neon.tech)