Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8; format=Flowed
Date: Tue, 07 May 2024 00:44:51 -0500
Message-Id: <D1369WP0F8SD.2B1P7N8DEEW1@neon.tech>
From: "Tristan Partin" <tristan@neon.tech>
Cc: "pgsql-hackers" <pgsql-hackers@postgresql.org>, "Andres Freund"
 <andres@anarazel.de>
Subject: Re: Use pgstat_kind_infos to read fixed shared stats structs
To: "Michael Paquier" <michael@paquier.xyz>
References: <D12SQ7OYCD85.20BUVF3DWU5K7@neon.tech>
 <ZjmW3ZI1HbVyfDpZ@paquier.xyz>
In-Reply-To: <ZjmW3ZI1HbVyfDpZ@paquier.xyz>
Archived-At: <https://www.postgresql.org/message-id/D1369WP0F8SD.2B1P7N8DEEW1%40neon.tech>
Precedence: bulk

On Mon May 6, 2024 at 9:50 PM CDT, Michael Paquier wrote:
> On Mon, May 06, 2024 at 02:07:53PM -0500, Tristan Partin wrote:
> > This was originally thought of by Andres in
> > 5891c7a8ed8f2d3d577e7eea34dacff12d7b6bbd.
>
> +1 because you are removing a duplication between the order of the
> items in PgStat_Kind and the order when these are read.  I suspect
> that nobody would mess up with the order if adding a stats kind with a
> fixed number of objects, but that makes maintenance slightly easier in
> the long-term :)
>
> > Not a fix, per se, but it does remove a comment. Perhaps the discussion=
 will
> > just lead to someone deleting the comment, and keeping the code as is.
> > Either way, a win :).
>
> Yup.  Let's leave that as something to do for v18.

Thanks for the feedback Michael. Should I just throw the patch in the=20
next commitfest so it doesn't get left behind?

--=20
Tristan Partin
Neon (https://neon.tech)