Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1s4OuU-003WCu-1o for pgsql-hackers@arkaria.postgresql.org; Tue, 07 May 2024 17:47:25 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1s4OuQ-004KeK-U1 for pgsql-hackers@arkaria.postgresql.org; Tue, 07 May 2024 17:47:23 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1s4OuQ-004Ke4-JX for pgsql-hackers@lists.postgresql.org; Tue, 07 May 2024 17:47:23 +0000 Received: from mail-oa1-x2d.google.com ([2001:4860:4864:20::2d]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1s4OuO-001uFC-R0 for pgsql-hackers@postgresql.org; Tue, 07 May 2024 17:47:22 +0000 Received: by mail-oa1-x2d.google.com with SMTP id 586e51a60fabf-23dd52c6176so3435071fac.1 for ; Tue, 07 May 2024 10:47:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neon.tech; s=google; t=1715104040; x=1715708840; darn=postgresql.org; h=in-reply-to:references:cc:from:to:subject:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=G5DXvpkpGU21yx2dkK1cB3j/NebZDfjXYor0bF3KeHw=; b=QPr7FaWvukgwwkJcs+5sM/svYrRrOQf8/OGYXi/JF2UR0Bh8teR+klfeyOxvf46scj 6LIPZrqFoJx/R7yCG/7zamQ9czLJ8czGTD6qEL2R56U1ob6cv54UmSx1FzI2V3DjJVEx CvoVDuvgXHnC7MttKUiWGTJ9QP5J9ipcygb0c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715104040; x=1715708840; h=in-reply-to:references:cc:from:to:subject:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=G5DXvpkpGU21yx2dkK1cB3j/NebZDfjXYor0bF3KeHw=; b=rGRExEjJe+PYuWeQhWfZ5Ba+uOnaQEwtBOi4RZN1rvnBaNHS8VZQNZKmC13/1WxLQI N9qxR1DHT5szWt2N6U0TwcZkNRlrzhL81BrlPmPY+2O6UR3WX/KHtfbnfVpa9VGgLQ84 JLQex2OqvMokthnIMvpji7RaSU9lts4tk2TR8X7leo4xSHhBi7EacGlejFRrP9okDXpu arSHi4Ewy4cuCwGAu6mtMEp9HRATocpSrVW5Vr9LbztW+CGDo44SyZvalqUq7ygLW24w 5DKq1il9mzqrJGQFhtDg98XrXMU9CthIORyT8RPFxwL4Z2aIeP2VMWolJOhtkGsMSMTp c57A== X-Gm-Message-State: AOJu0YxmJJLj/XSfAkPp0QS5A2H1NSZ1NEAZ4/iTTCJQ5MIsNZuP7r22 Pq3B6Vt4kKE2bPh9R/dHNvlCuBzpKyeL9TGNErHv9E8MVALR7XdT8DU7sC+x0+mjaYJkVXM+KWP 3AUs= X-Google-Smtp-Source: AGHT+IE1KZlrP0bK/gUt1H+ctN4ZFZY6g9ni+HuEvTVqEonPbEOANqyRgc+aQq12kmOrVxWRBnbWjA== X-Received: by 2002:a05:6870:7099:b0:23c:3c36:959d with SMTP id 586e51a60fabf-24091ce0300mr216283fac.15.1715104040121; Tue, 07 May 2024 10:47:20 -0700 (PDT) Received: from localhost ([2607:fb90:e690:15c7:3996:e070:71ee:42fb]) by smtp.gmail.com with ESMTPSA id et4-20020a0568303c8400b006ee0d82d41dsm2559374otb.71.2024.05.07.10.47.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 May 2024 10:47:19 -0700 (PDT) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8; format=Flowed Date: Tue, 07 May 2024 12:47:18 -0500 Message-Id: Subject: Re: Use pgstat_kind_infos to read fixed shared stats structs To: "Michael Paquier" From: "Tristan Partin" Cc: "pgsql-hackers" , "Andres Freund" X-Mailer: aerc 0.17.0-122-g7b4c8f67eb5f References: In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Tue May 7, 2024 at 1:01 AM CDT, Michael Paquier wrote: > On Tue, May 07, 2024 at 12:44:51AM -0500, Tristan Partin wrote: > > Thanks for the feedback Michael. Should I just throw the patch in the n= ext > > commitfest so it doesn't get left behind? > > Better to do so, yes. I have noted this thread in my TODO list, but > we're a couple of weeks away from the next CF and things tend to get > easily forgotten. Added here: https://commitfest.postgresql.org/48/4978/ --=20 Tristan Partin Neon (https://neon.tech)