Feedback-ID: idd01497b:Fastmail
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8; format=Flowed
Date: Tue, 16 Jul 2024 15:53:45 -0500
Message-Id: <D2R9FY2W0D7S.249249RYHGISR@partin.io>
Cc: "Nazir Bilal Yavuz" <byavuz81@gmail.com>, "PostgreSQL Developers"
 <pgsql-hackers@lists.postgresql.org>
Subject: Re: Meson far from ready on Windows
To: "Andres Freund" <andres@anarazel.de>, "Dave Page" <dpage@pgadmin.org>
From: "Tristan Partin" <tristan@partin.io>
References: <20240618143850.nl67cwctsodmgfpi@awork3.anarazel.de>
 <CA+OCxoxwwA7u3mw9r7+miRzxdwzet9=Xq3JxVFpkd6TajP9eGA@mail.gmail.com>
 <20240618160845.gbqkiv4dbjghlp63@awork3.anarazel.de>
 <CA+OCxozsg3NOkTfK4KCb0gmxwnaNv4P=yuMZe_CgeXTM=ZGW7g@mail.gmail.com>
 <20240620205849.whd3434zoqqm2iy4@awork3.anarazel.de>
 <CA+OCxoxJ075+R63sgsHBExB+x3BV3o1xs9EBxGEuYmZQOkW=UQ@mail.gmail.com>
 <20240625104145.b255idixhgq4hrrx@alap3.anarazel.de>
 <CA+OCxozhkrfLe=ZUt4fcs3G-Qew30e5H37AL7o7aZ3bC54TAoQ@mail.gmail.com>
 <20240625113906.7gecsoyjcqjrejiz@alap3.anarazel.de>
 <CA+OCxozShTj4eBn5wtjQ16bL3qMq1ETO_CBCMHFfXcvQyZSZaw@mail.gmail.com>
 <20240709065101.xhc74r3mdg2lmn4w@awork3.anarazel.de>
In-Reply-To: <20240709065101.xhc74r3mdg2lmn4w@awork3.anarazel.de>
Archived-At: 
 <https://www.postgresql.org/message-id/D2R9FY2W0D7S.249249RYHGISR%40partin.io>
Precedence: bulk

> From 9f7c96dfab4d807e668c9d32b44db5f4ff122e15 Mon Sep 17 00:00:00 2001
> From: Andres Freund <andres@anarazel.de>
> Date: Mon, 8 Jul 2024 15:55:56 -0700
> Subject: [PATCH v2 02/10] Don't define HAVE_[GSSAPI_]GSSAPI_EXT_H
>=20
> The check for gssapi_ext.h was added in f7431bca8b0. As we require
> gssapi_ext.h to be present, there's no point in defining symbols for the
> header presence.
>=20
> While at it, use cc.has_header() instead of cc.check_header(), that's a b=
it
> cheaper and it seems improbably that gssapi.h would compile while gssapi_=
ext.h
> would not.

improbable

Other than that, it looks pretty solid. Looks like we could help future=20
us out by teaching compiler.find_library() to take a list of names to=20
look at similar to how dependency() works now.

Reviewed-by: Tristan Partin <tristan@partin.io>

--=20
Tristan Partin
Neon (https://neon.tech)