Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.2\))
Subject: Re: [PATCH] Extend the length of BackgroundWorker.bgw_library_name
From: Daniel Gustafsson <daniel@yesql.se>
In-Reply-To: <20230420233243.GB1437940@nathanxps13>
Date: Fri, 21 Apr 2023 10:49:48 +0200
Cc: Yurii Rashkovskii <yrashk@gmail.com>,
 pgsql-hackers@lists.postgresql.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <D326A802-7DDF-4B65-9AC7-1083F10294D5@yesql.se>
References: <CA+RLCQyjFV5Y8tG5QgUb6gjteL4S3p+1gcyqWTqigyM93WZ9Pg@mail.gmail.com>
 <20230313173528.GA195204@nathanxps13>
 <D32826BC-97A9-4D3D-8BD7-3639044F8D4B@yesql.se>
 <20230420233243.GB1437940@nathanxps13>
To: Nathan Bossart <nathandbossart@gmail.com>
Archived-At: <https://www.postgresql.org/message-id/D326A802-7DDF-4B65-9AC7-1083F10294D5%40yesql.se>
Precedence: bulk

> On 21 Apr 2023, at 01:32, Nathan Bossart <nathandbossart@gmail.com> =
wrote:
>=20
> On Wed, Mar 15, 2023 at 10:38:34AM +0100, Daniel Gustafsson wrote:
>> While here, I wonder if we should document what BGW_MAXLEN is defined =
as in
>> bgworker.sgml?
>=20
> I am -0.5 for this.  If you are writing a new background worker, it's
> probably reasonable to expect that you can locate the definition of
> BGW_MAXLEN. =20

Of course.  The question is if it's a helpful addition for someone who =
is
reading the documentation section on implementing background workers =
where we
explicitly mention BGW_MAXLEN without saying what it is.

> Also, I think there's a good chance that we'd forget to update
> such documentation the next time we adjust it.

There is that, but once set to MAXPGPATH it seems unlikely to change
particularly often so it seems the wrong thing to optimize for.

--
Daniel Gustafsson