Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81\))
Subject: Re: vacuumdb: add --dry-run
From: Chao Li <li.evan.chao@gmail.com>
In-Reply-To: <aTcmCNuBamK1xwu5@nathan>
Date: Tue, 9 Dec 2025 07:04:24 +0800
Cc: =?utf-8?Q?=C3=81lvaro_Herrera?= <alvherre@kurilemu.de>,
 Corey Huinker <corey.huinker@gmail.com>,
 pgsql-hackers@postgresql.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <D34BB1FD-C704-4855-804D-932C054B1981@gmail.com>
References: <aTcUSHQniPgksgC5@nathan>
 <202512081821.lruaedzh3qkr@alvherre.pgsql> <aTcYjvO7f-9DXbrk@nathan>
 <aTcmCNuBamK1xwu5@nathan>
To: Nathan Bossart <nathandbossart@gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/D34BB1FD-C704-4855-804D-932C054B1981%40gmail.com>
Precedence: bulk


> On Dec 9, 2025, at 03:24, Nathan Bossart <nathandbossart@gmail.com> =
wrote:
>=20
> On Mon, Dec 08, 2025 at 12:27:26PM -0600, Nathan Bossart wrote:
>> On Mon, Dec 08, 2025 at 07:23:16PM +0100, =C3=81lvaro Herrera wrote:
>>> I haven't read this thread, but chanced to come across this and =
wanted
>>> to note recent commit c05dee191125.  I'm not opposed to changing =
what
>>> went in there, but let's make them all the same.
>>=20
>> Ah, that must've been where I stole from originally.  Will switch it =
back.
>=20
> As promised...
>=20
> --=20
> nathan
> =
<v7-0001-vacuumdb-Move-some-options-to-vacuumingOptions-st.patch><v7-0002-=
Add-ParallelSlotSetIdle.patch><v7-0003-vacuumdb-Add-dry-run.patch>

I searched over the source tree, and find =E2=80=9CRunning in xxx =
mode=E2=80=9D in initdb and option.c:

Initdb:
```
printf(_("Running in debug mode.\n"));

printf(_("Running in no-clean mode. Mistakes will not be cleaned =
up.\n"));```

Options.
```
pg_log(PG_REPORT, "Running in verbose mode=E2=80=9D);
```

And =E2=80=9C=E2=80=9DExecuting in dry-run mode=E2=80=9D in a few =
commands: pg_archivecleanup.c, pg_createsubscriber.c, pg_combinebackup.c =
and pg_rewind.c.

Should we make them all consistent?

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/