Feedback-ID: idd01497b:Fastmail
Content-Type: multipart/mixed;
 boundary=fd5f344420b9f6c6850719361e5cb46bea88b50e207696019c1f13d0dfcf
Mime-Version: 1.0
Date: Tue, 13 Aug 2024 18:17:31 -0500
Message-Id: <D3F61A59ARFJ.12K4NG1DEJ6DE@partin.io>
From: "Tristan Partin" <tristan@partin.io>
Cc: "pgsql-hackers" <pgsql-hackers@postgresql.org>
Subject: Re: On non-Windows, hard depend on uselocale(3)
To: "Thomas Munro" <thomas.munro@gmail.com>, "Tom Lane" <tgl@sss.pgh.pa.us>
References: <CWZBBRR6YA8D.8EHMDRGLCKCD@neon.tech> <2689177.1700070346@sss.pgh.pa.us>
 <CA+hUKGKo7Q4zayx37JxMaD-BzmkaW9j+k70bhA9auN9jztFrVQ@mail.gmail.com>
 <2946058.1700081498@sss.pgh.pa.us>
 <CA+hUKGKu7H7iPNQsZ5FcPkZVbgXc5iTBgUjdpM2EHP4q=Tz42Q@mail.gmail.com>
 <12842.1700083028@sss.pgh.pa.us>
 <CA+hUKGJ4s6uDK_KYK-2q=2aWztgvTHYqGeSzugaTCEs6_3XqAg@mail.gmail.com>
 <98824.1700089582@sss.pgh.pa.us>
 <CA+hUKGLLb1MiqAUwtSb6gQsqm8wgAh+7UEE-6P1tQxjhHCFmrw@mail.gmail.com>
 <664255.1700245108@sss.pgh.pa.us> <810814.1700261928@sss.pgh.pa.us>
 <CA+hUKGLy2AeE0a6MHq_KQhJXbOQJ6UHsrUoCwb5OGj+WijAWqw@mail.gmail.com>
 <1155474.1700433384@sss.pgh.pa.us>
 <CA+hUKG+YxfUyUOY7OHUFCgenAgq9znksd=Z+vyb20KHG=2iAnw@mail.gmail.com>
 <1330178.1700498443@sss.pgh.pa.us>
 <CA+hUKG+Yv+ps=nS2T8SS1UDU=iySHSr4sGHYiYGkPTpZx6Ooww@mail.gmail.com>
 <CA+hUKGLs9ccA7pUfphZOuf_fcVq2FAai7Cm0pmbQk0Qcs4VoVQ@mail.gmail.com>
 <CA+hUKGKOuA4vTkFk01RSLqyM0pzNjYm-3h2zAtW48Ffc7FjjNg@mail.gmail.com>
 <CA+hUKG+ue0KC5KSqMuL5zi7uCSuXCLP_B+sZSq5=yS84606ZsA@mail.gmail.com>
In-Reply-To: <CA+hUKG+ue0KC5KSqMuL5zi7uCSuXCLP_B+sZSq5=yS84606ZsA@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/D3F61A59ARFJ.12K4NG1DEJ6DE%40partin.io>
Precedence: bulk

--fd5f344420b9f6c6850719361e5cb46bea88b50e207696019c1f13d0dfcf
Content-Type: multipart/alternative;
 boundary=b66228576d6d4e7469f1998b992b28d8f14da41fbbf9e74d75958ffa8bf3

--b66228576d6d4e7469f1998b992b28d8f14da41fbbf9e74d75958ffa8bf3
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Content-Type: text/plain; charset=UTF-8; format=Flowed

Hey Thomas,

Thanks for picking this up. I think your patch looks really good. Are=20
you familiar with gcc's function poisoning?

	#include <stdio.h>
	#pragma GCC poison puts
=09
	int main(){
	#pragma GCC bless begin puts
	    puts("a");
	#pragma GCC bless end puts
	}

I wonder if we could use function poisoning to our advantage. For=20
instance in ecpg, it looks like you got all of the strtod() invocations=20
and replaced them with strtod_l(). Here is a patch with an example of=20
what I'm talking about.

--=20
Tristan Partin
Neon (https://neon.tech)

--b66228576d6d4e7469f1998b992b28d8f14da41fbbf9e74d75958ffa8bf3--

--fd5f344420b9f6c6850719361e5cb46bea88b50e207696019c1f13d0dfcf
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
 filename=v1-0001-Poison-strtod-in-ecpg.patch
Content-Type: text/x-patch; charset=utf-8;
 name=v1-0001-Poison-strtod-in-ecpg.patch

RnJvbSBhNzZhM2YyNTc3ZDA5OGY3Y2U1YTNlZDE3NjhhY2E0MjkzYWVkZmNjIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBUcmlzdGFuIFBhcnRpbiA8dHJpc3RhbkBwYXJ0aW4uaW8+CkRh
dGU6IFR1ZSwgMTMgQXVnIDIwMjQgMTg6MDY6MjAgLTA1MDAKU3ViamVjdDogW1BBVENIIHYxXSBQ
b2lzb24gc3RydG9kIGluIGVjcGcKCmVjcGcgZXhjbHVzaXZlbHkgdXNlcyBzdHJ0b2RfbCBub3cu
CgpTaWduZWQtb2ZmLWJ5OiBUcmlzdGFuIFBhcnRpbiA8dHJpc3RhbkBwYXJ0aW4uaW8+Ci0tLQog
c3JjL2ludGVyZmFjZXMvZWNwZy9lY3BnbGliL2RhdGEuYyAgICAgICAgIHwgMSArCiBzcmMvaW50
ZXJmYWNlcy9lY3BnL2luY2x1ZGUvZWNwZ19wb2lzb24uaCAgfCA2ICsrKysrKwogc3JjL2ludGVy
ZmFjZXMvZWNwZy9wZ3R5cGVzbGliL2R0X2NvbW1vbi5jIHwgMSArCiBzcmMvaW50ZXJmYWNlcy9l
Y3BnL3BndHlwZXNsaWIvaW50ZXJ2YWwuYyAgfCAxICsKIHNyYy9pbnRlcmZhY2VzL2VjcGcvcGd0
eXBlc2xpYi9udW1lcmljLmMgICB8IDEgKwogNSBmaWxlcyBjaGFuZ2VkLCAxMCBpbnNlcnRpb25z
KCspCiBjcmVhdGUgbW9kZSAxMDA2NDQgc3JjL2ludGVyZmFjZXMvZWNwZy9pbmNsdWRlL2VjcGdf
cG9pc29uLmgKCmRpZmYgLS1naXQgYS9zcmMvaW50ZXJmYWNlcy9lY3BnL2VjcGdsaWIvZGF0YS5j
IGIvc3JjL2ludGVyZmFjZXMvZWNwZy9lY3BnbGliL2RhdGEuYwppbmRleCA4NTZmNGM5NDcyZC4u
MTMwMjNmYzIxZWIgMTAwNjQ0Ci0tLSBhL3NyYy9pbnRlcmZhY2VzL2VjcGcvZWNwZ2xpYi9kYXRh
LmMKKysrIGIvc3JjL2ludGVyZmFjZXMvZWNwZy9lY3BnbGliL2RhdGEuYwpAQCAtNiw2ICs2LDcg
QEAKICNpbmNsdWRlIDxtYXRoLmg+CiAKICNpbmNsdWRlICJlY3BnZXJybm8uaCIKKyNpbmNsdWRl
ICJlY3BnX3BvaXNvbi5oIgogI2luY2x1ZGUgImVjcGdsaWIuaCIKICNpbmNsdWRlICJlY3BnbGli
X2V4dGVybi5oIgogI2luY2x1ZGUgImVjcGd0eXBlLmgiCmRpZmYgLS1naXQgYS9zcmMvaW50ZXJm
YWNlcy9lY3BnL2luY2x1ZGUvZWNwZ19wb2lzb24uaCBiL3NyYy9pbnRlcmZhY2VzL2VjcGcvaW5j
bHVkZS9lY3BnX3BvaXNvbi5oCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAw
Li45N2FlOWQ3YTE0MwotLS0gL2Rldi9udWxsCisrKyBiL3NyYy9pbnRlcmZhY2VzL2VjcGcvaW5j
bHVkZS9lY3BnX3BvaXNvbi5oCkBAIC0wLDAgKzEsNiBAQAorI2lmbmRlZiBfRUNQR19QT0lTT05f
SAorI2RlZmluZSBfRUNQR19QT0lTT05fSAorCisjcHJhZ21hIEdDQyBwb2lzb24gc3RydG9kCisK
KyNlbmRpZgkJCQkJCQkvKiAhX0VDUEdfUE9JU09OX0ggKi8KZGlmZiAtLWdpdCBhL3NyYy9pbnRl
cmZhY2VzL2VjcGcvcGd0eXBlc2xpYi9kdF9jb21tb24uYyBiL3NyYy9pbnRlcmZhY2VzL2VjcGcv
cGd0eXBlc2xpYi9kdF9jb21tb24uYwppbmRleCA5MjQ1OTcyOGJmNC4uMmE5YzVlYzMyYzAgMTAw
NjQ0Ci0tLSBhL3NyYy9pbnRlcmZhY2VzL2VjcGcvcGd0eXBlc2xpYi9kdF9jb21tb24uYworKysg
Yi9zcmMvaW50ZXJmYWNlcy9lY3BnL3BndHlwZXNsaWIvZHRfY29tbW9uLmMKQEAgLTgsNiArOCw3
IEBACiAKICNpbmNsdWRlICJjb21tb24vc3RyaW5nLmgiCiAjaW5jbHVkZSAiZHQuaCIKKyNpbmNs
dWRlICJlY3BnX3BvaXNvbi5oIgogI2luY2x1ZGUgInBndHlwZXNfdGltZXN0YW1wLmgiCiAjaW5j
bHVkZSAicGd0eXBlc2xpYl9leHRlcm4uaCIKIApkaWZmIC0tZ2l0IGEvc3JjL2ludGVyZmFjZXMv
ZWNwZy9wZ3R5cGVzbGliL2ludGVydmFsLmMgYi9zcmMvaW50ZXJmYWNlcy9lY3BnL3BndHlwZXNs
aWIvaW50ZXJ2YWwuYwppbmRleCAxNTVjNmNjNzc3MC4uYmZjYzcyMzM5OTkgMTAwNjQ0Ci0tLSBh
L3NyYy9pbnRlcmZhY2VzL2VjcGcvcGd0eXBlc2xpYi9pbnRlcnZhbC5jCisrKyBiL3NyYy9pbnRl
cmZhY2VzL2VjcGcvcGd0eXBlc2xpYi9pbnRlcnZhbC5jCkBAIC0xMiw2ICsxMiw3IEBACiAKICNp
bmNsdWRlICJjb21tb24vc3RyaW5nLmgiCiAjaW5jbHVkZSAiZHQuaCIKKyNpbmNsdWRlICJlY3Bn
X3BvaXNvbi5oIgogI2luY2x1ZGUgInBndHlwZXNfZXJyb3IuaCIKICNpbmNsdWRlICJwZ3R5cGVz
X2ludGVydmFsLmgiCiAjaW5jbHVkZSAicGd0eXBlc2xpYl9leHRlcm4uaCIKZGlmZiAtLWdpdCBh
L3NyYy9pbnRlcmZhY2VzL2VjcGcvcGd0eXBlc2xpYi9udW1lcmljLmMgYi9zcmMvaW50ZXJmYWNl
cy9lY3BnL3BndHlwZXNsaWIvbnVtZXJpYy5jCmluZGV4IDQ5OTM4NTQzZDAzLi4yNjIzZjM2MjU2
NSAxMDA2NDQKLS0tIGEvc3JjL2ludGVyZmFjZXMvZWNwZy9wZ3R5cGVzbGliL251bWVyaWMuYwor
KysgYi9zcmMvaW50ZXJmYWNlcy9lY3BnL3BndHlwZXNsaWIvbnVtZXJpYy5jCkBAIC02LDYgKzYs
NyBAQAogI2luY2x1ZGUgPGZsb2F0Lmg+CiAjaW5jbHVkZSA8bGltaXRzLmg+CiAKKyNpbmNsdWRl
ICJlY3BnX3BvaXNvbi5oIgogI2luY2x1ZGUgInBndHlwZXNfZXJyb3IuaCIKICNpbmNsdWRlICJw
Z3R5cGVzX251bWVyaWMuaCIKICNpbmNsdWRlICJwZ3R5cGVzbGliX2V4dGVybi5oIgotLSAKVHJp
c3RhbiBQYXJ0aW4KaHR0cHM6Ly90cmlzdGFuLnBhcnRpbi5pbwoK
--fd5f344420b9f6c6850719361e5cb46bea88b50e207696019c1f13d0dfcf--