public inbox for [email protected]  

help / color / mirror / Atom feed

From: Daniel Gustafsson <[email protected]>
To: Gurjeet Singh <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: Reorder connection markers in libpq TAP tests
Date: Fri, 21 Apr 2023 12:55:44 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <CABwTF4USR+RmEx1ef1H=y8x3gJrgSv7+pXubQbsZuyvQ+TBgKw@mail.gmail.com>
References: <CABwTF4WcYAENqyUQS2crAYfDuJ497v82ty2-MirjaC+zz9e8nQ@mail.gmail.com>
	<CABwTF4USR+RmEx1ef1H=y8x3gJrgSv7+pXubQbsZuyvQ+TBgKw@mail.gmail.com>

> On 21 Apr 2023, at 08:38, Gurjeet Singh <[email protected]> wrote:
> 
> On Thu, Apr 20, 2023 at 11:00 PM Gurjeet Singh <[email protected]> wrote:
>> 
>> Commit 7f5b198 introduced TAP tests that use string literals to mark
>> the presence of a query in server logs. For no explicable reason, the
>> tests with the marker 'connect2' occur before the tests that use
>> 'connect1' marker.
>> 
>> The attached patch swaps the connection marker strings so that a
>> reader doesn't have to spend extra deciphering why 'connect2' tests
>> appear before 'connect1' tests.
> 
> Please see attached v2 of the patch. It now includes same fix in
> another TAP tests file.

-	  'Potentially unsafe test load_balance not enabled in PG_TEST_EXTRA';
+	  'Potentially unsafe test; load_balance not enabled in PG_TEST_EXTRA';

We have this spelling without a ';' in multiple places so I left this alone.

I have applied this version of the patch apart from the above hunk. Thanks!

--
Daniel Gustafsson

view thread (2+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: Reorder connection markers in libpq TAP tests
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox