Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tmDKO-005092-U9 for pgsql-hackers@arkaria.postgresql.org; Sun, 23 Feb 2025 14:51:33 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tmDKN-00An8T-LO for pgsql-hackers@arkaria.postgresql.org; Sun, 23 Feb 2025 14:51:31 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tmDKN-00An7s-7W for pgsql-hackers@lists.postgresql.org; Sun, 23 Feb 2025 14:51:31 +0000 Received: from mail-ed1-x531.google.com ([2a00:1450:4864:20::531]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1tmDKJ-000JXN-1s for pgsql-hackers@lists.postgresql.org; Sun, 23 Feb 2025 14:51:30 +0000 Received: by mail-ed1-x531.google.com with SMTP id 4fb4d7f45d1cf-5dec817f453so5932312a12.2 for ; Sun, 23 Feb 2025 06:51:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jeltef.nl; s=google; t=1740322286; x=1740927086; darn=lists.postgresql.org; h=in-reply-to:references:from:to:subject:cc:message-id:date :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=VUamTJ7t18nw01dsbqIk2Qkq9xd+snkLJsksu+Qls9o=; b=PF3xExpGoq3aXeWOa6x5VscSvH0YAfV6RICncw5cb7tiqLgjnuq2MwLWjLpLkqgF+L mbaRWQsRRrZikgpY6S0fOXmrMr6/fRVgYtxv76VxtEVw9N/oNG7Eild/K6UFtOYzpVV1 N4oAoXUiytCGdFw62ThIHthF1+nldorQRD9JtTJEQNtoCmS+kXnEy19HLyTAhv+ezw6a HFr19PR7vWMXK+JDppYllzQZYFP196YGRLzZbL2gQa1sUWr8de6BG2agfIZr6CXpuYjs 8r28bARtAiZOnxkXf98OYYwwh1zNVy5dewd996V/B3RxSl1IRVopoXRT/wn3v+7HPLU9 gt2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740322286; x=1740927086; h=in-reply-to:references:from:to:subject:cc:message-id:date :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VUamTJ7t18nw01dsbqIk2Qkq9xd+snkLJsksu+Qls9o=; b=bQpV8AoL969RFDtpEJOoWHY909OZ9/ZDQKBxtYgrrFUXp+eSE9y4nGaFh4kdg7tWIR Q4Ab3ovze6IWrYgwgr0EJSEjeb4oVK3RncNPclCmP6Z6N5IeZr/S2Mf6eBRjQFRTzKgP GnZcH4XvN8s+I9p/HYktp1urhZjkbtN7RKcmSGzHPbimTrypRpn/QBwiwnRd256I7k0q hCnnr752HXGpoulSy4KLw0+27El1CDBEbeKRLcSCQe9VyT4dvnbq+T0ni4V3HCM4PfS3 NAEdJgWMr2jc4cxMcoOEhz3bfRq2muZ5TpngMObCjfXLRnLXVi6AW9JBc9VCajXRgQgr 5ybw== X-Forwarded-Encrypted: i=1; AJvYcCW920Xfnn8xpF+u8Is/asBB0ayTwdFvgegTj4fBl1xvsaxVWBNoDJTdaa2uQlXfFyhankN1mQWaFopVJrRE@lists.postgresql.org X-Gm-Message-State: AOJu0YzaBWI6SH1s8P+oZw4KZ16+JC8wHr3a7/gqnz5kf2A4Jo4mOF82 +iGyYUrpXI9TExmMc2fu3kdy/AP/wqEaQNOwsF/Wd+Jc4gZApp4in72wVO8C24pUAbadxZw+Jx0 i X-Gm-Gg: ASbGncvtILA5PPkNVPdzVI+q7Jz0mYUbYdjdLiPfi63xrBIXn3Yjit1CgZEp+eYgcwd 0i3LRKifM+3g54eJjfXpMUDK6UWWrXzxGPTdDbRy9+AIcNHtiWqCLPsA8SRgqMQkbIEWdywSsIT ExgyE89oi54BgU+E8L6up+2TggIxjsMcK7sTFYd6dOH7MCNR0j5F9H5Zcc92FlDgeYFKoG9HCvM xqCWPnO0IIduYRUPTuFcPXhiNtGLREYvXRcicH7SELYmjYnFOUJTbtYgdJWHnq+ubEQMOOX07gx e4nQbaQmqaq7YwSciezGcn+6ajUMqeGt46nEwJcFn6xwWGyALHg= X-Google-Smtp-Source: AGHT+IFYpixlCW7d9bhBoFy2BF+4gLZghsvQSj8kNKQaaL4gHiCw3io54jFpt9qy3EtftMEkHL4GYw== X-Received: by 2002:a05:6402:2548:b0:5e0:7ff3:20c with SMTP id 4fb4d7f45d1cf-5e0b710743bmr10449123a12.17.1740322286192; Sun, 23 Feb 2025 06:51:26 -0800 (PST) Received: from localhost (145-53-221-196.fixed.kpn.net. [145.53.221.196]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e0a2e25589sm6084203a12.42.2025.02.23.06.51.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 23 Feb 2025 06:51:25 -0800 (PST) Content-Type: multipart/mixed; boundary=564634f42d349a8d4867d50ed0d56c99edc377d87d58be79dd0a53d53b43 Mime-Version: 1.0 Date: Sun, 23 Feb 2025 15:51:24 +0100 Message-Id: Cc: "Magnus Hagander" , "PostgreSQL Developers" Subject: Re: Adding extension default version to \dx To: "Nathan Bossart" , "Michael Banck" From: "Jelte Fennema-Nio" X-Mailer: aerc 0.19.0-3-g31273bbcc76a-dirty References: <67813520.170a0220.183245.7bf0@mx.google.com> In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --564634f42d349a8d4867d50ed0d56c99edc377d87d58be79dd0a53d53b43 Content-Type: multipart/alternative; boundary=289355e23a4eb6934fc539cffbf314ff17f2aeadbb719aaa8eb9c5c98a5e --289355e23a4eb6934fc539cffbf314ff17f2aeadbb719aaa8eb9c5c98a5e Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Content-Type: text/plain; charset=UTF-8; format=Flowed On Mon Jan 27, 2025 at 8:39 PM CET, Nathan Bossart wrote: > +1 > > Separately, I see that there's one update needed for > src/test/regress/expected/psql.out. The documentation for \dx looks > generic enough that it probably doesn't need any updates, though. Attached is an updated patch that fixes the tests and changes the whitespace as discussed (including removing a spurious second space before the ON, which I noticed while changing it). As well as a seprate patch that changes the "c" alias to "d". --289355e23a4eb6934fc539cffbf314ff17f2aeadbb719aaa8eb9c5c98a5e-- --564634f42d349a8d4867d50ed0d56c99edc377d87d58be79dd0a53d53b43 Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=v2-0001-Add-default-extension-version-to-dx.patch Content-Type: text/x-patch; charset=utf-8; name=v2-0001-Add-default-extension-version-to-dx.patch RnJvbSA5NzYyMzg4Y2ZlM2IxNmIyMmE0NjhlYmUyOWI2MTNlMmI4MTA4OGYzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKZWx0ZSBGZW5uZW1hLU5pbyA8Z2l0aHViLXRlY2hAamVsdGVm Lm5sPgpEYXRlOiBTdW4sIDIzIEZlYiAyMDI1IDE1OjE4OjI3ICswMTAwClN1YmplY3Q6IFtQQVRD SCB2MiAxLzJdIEFkZCBkZWZhdWx0IGV4dGVuc2lvbiB2ZXJzaW9uIHRvIFxkeAoKSW4gYW4gZWZm b3J0IHRvIG1ha2UgYXQgbGVhc3QgYSBjb3VwbGUgb2YgbW9yZSBwZW9wbGUgcmVhbGl6ZSB0aGV5 IGhhdmUKdG8gcnVuIEFMVEVSIEVYVEVOU0lPTiBVUERBVEUgYWZ0ZXIgdGhleSd2ZSB1cGdyYWRl ZCBhbiBleHRlbnNpb24sICBhcwp3ZWxsIGFzIG1ha2UgaXQgYSBiaXQgZWFzaWVyIHRvIHJlYWxp emUgd2hlbiB5b3UgaGF2ZSB0byBkbyBpdCwgdGhpcwphZGRzIHRoZSBkZWZhdWx0IHZlcnNpb24g b2YgYW4gZXh0ZW5zaW9uIHRvIHRoZSBvdXRwdXQgb2YgXGR4LiBXZQpwcmV2aW91c2x5IHNob3dl ZCB0aGUgaW5zdGFsbGVkIHZlcnNpb24gaW4gdGhlIHNjaGVtYSwgYnV0IG5vCmluZGljYXRpb25z IHRoYXQgYSBuZXdlciBvbmUgbWlnaHQgYmUgaW5zdGFsbGVkIG9uIHRoZSBzeXN0ZW0uCi0tLQog c3JjL2Jpbi9wc3FsL2Rlc2NyaWJlLmMgICAgICAgICAgICB8IDUgKysrKy0KIHNyYy90ZXN0L3Jl Z3Jlc3MvZXhwZWN0ZWQvcHNxbC5vdXQgfCA2ICsrKy0tLQogMiBmaWxlcyBjaGFuZ2VkLCA3IGlu c2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvc3JjL2Jpbi9wc3FsL2Rl c2NyaWJlLmMgYi9zcmMvYmluL3BzcWwvZGVzY3JpYmUuYwppbmRleCBlNmNmNDY4YWM5ZS4uMDFl NjI0MzBmZmYgMTAwNjQ0Ci0tLSBhL3NyYy9iaW4vcHNxbC9kZXNjcmliZS5jCisrKyBiL3NyYy9i aW4vcHNxbC9kZXNjcmliZS5jCkBAIC02MTg4LDEzICs2MTg4LDE2IEBAIGxpc3RFeHRlbnNpb25z KGNvbnN0IGNoYXIgKnBhdHRlcm4pCiAJaW5pdFBRRXhwQnVmZmVyKCZidWYpOwogCXByaW50ZlBR RXhwQnVmZmVyKCZidWYsCiAJCQkJCSAgIlNFTEVDVCBlLmV4dG5hbWUgQVMgXCIlc1wiLCAiCi0J CQkJCSAgImUuZXh0dmVyc2lvbiBBUyBcIiVzXCIsIG4ubnNwbmFtZSBBUyBcIiVzXCIsIGMuZGVz Y3JpcHRpb24gQVMgXCIlc1wiXG4iCisJCQkJCSAgImUuZXh0dmVyc2lvbiBBUyBcIiVzXCIsIGFl LmRlZmF1bHRfdmVyc2lvbiBBUyBcIiVzXCIsIgorCQkJCQkgICJuLm5zcG5hbWUgQVMgXCIlc1wi LCBjLmRlc2NyaXB0aW9uIEFTIFwiJXNcIlxuIgogCQkJCQkgICJGUk9NIHBnX2NhdGFsb2cucGdf ZXh0ZW5zaW9uIGUgIgogCQkJCQkgICJMRUZUIEpPSU4gcGdfY2F0YWxvZy5wZ19uYW1lc3BhY2Ug biBPTiBuLm9pZCA9IGUuZXh0bmFtZXNwYWNlICIKIAkJCQkJICAiTEVGVCBKT0lOIHBnX2NhdGFs b2cucGdfZGVzY3JpcHRpb24gYyBPTiBjLm9iam9pZCA9IGUub2lkICIKKwkJCQkJICAiTEVGVCBK T0lOIHBnX2NhdGFsb2cucGdfYXZhaWxhYmxlX2V4dGVuc2lvbnMoKSBhZShuYW1lLCBkZWZhdWx0 X3ZlcnNpb24sIGNvbW1lbnQpIE9OIGFlLm5hbWUgPSBlLmV4dG5hbWUgIgogCQkJCQkgICJBTkQg Yy5jbGFzc29pZCA9ICdwZ19jYXRhbG9nLnBnX2V4dGVuc2lvbic6OnBnX2NhdGFsb2cucmVnY2xh c3NcbiIsCiAJCQkJCSAgZ2V0dGV4dF9ub29wKCJOYW1lIiksCiAJCQkJCSAgZ2V0dGV4dF9ub29w KCJWZXJzaW9uIiksCisJCQkJCSAgZ2V0dGV4dF9ub29wKCJEZWZhdWx0IHZlcnNpb24iKSwKIAkJ CQkJICBnZXR0ZXh0X25vb3AoIlNjaGVtYSIpLAogCQkJCQkgIGdldHRleHRfbm9vcCgiRGVzY3Jp cHRpb24iKSk7CiAKZGlmZiAtLWdpdCBhL3NyYy90ZXN0L3JlZ3Jlc3MvZXhwZWN0ZWQvcHNxbC5v dXQgYi9zcmMvdGVzdC9yZWdyZXNzL2V4cGVjdGVkL3BzcWwub3V0CmluZGV4IDY1NDNlOTBkZTc1 Li4zOGUyNGRmMzNhYiAxMDA2NDQKLS0tIGEvc3JjL3Rlc3QvcmVncmVzcy9leHBlY3RlZC9wc3Fs Lm91dAorKysgYi9zcmMvdGVzdC9yZWdyZXNzL2V4cGVjdGVkL3BzcWwub3V0CkBAIC02NDU5LDkg KzY0NTksOSBAQCBMaXN0IG9mIHNjaGVtYXMKICgwIHJvd3MpCiAKIFxkeCAibm8uc3VjaC5pbnN0 YWxsZWQuZXh0ZW5zaW9uIgotICAgICBMaXN0IG9mIGluc3RhbGxlZCBleHRlbnNpb25zCi0gTmFt ZSB8IFZlcnNpb24gfCBTY2hlbWEgfCBEZXNjcmlwdGlvbiAKLS0tLS0tLSstLS0tLS0tLS0rLS0t LS0tLS0rLS0tLS0tLS0tLS0tLQorICAgICAgICAgICAgICBMaXN0IG9mIGluc3RhbGxlZCBleHRl bnNpb25zCisgTmFtZSB8IFZlcnNpb24gfCBEZWZhdWx0IHZlcnNpb24gfCBTY2hlbWEgfCBEZXNj cmlwdGlvbiAKKy0tLS0tLSstLS0tLS0tLS0rLS0tLS0tLS0tLS0tLS0tLS0rLS0tLS0tLS0rLS0t LS0tLS0tLS0tLQogKDAgcm93cykKIAogXGRYICJuby5zdWNoLmV4dGVuZGVkLnN0YXRpc3RpY3Mi CgpiYXNlLWNvbW1pdDogNDU0YzE4MmY4NTQyODkwZDBlMmVhYzg1ZjcwZDlhMjU0YTM0ZmNlMwot LSAKMi40My4wCgo= --564634f42d349a8d4867d50ed0d56c99edc377d87d58be79dd0a53d53b43 Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=v2-0002-Use-d-alias-for-pg_description-consistently.patch Content-Type: text/x-patch; charset=utf-8; name=v2-0002-Use-d-alias-for-pg_description-consistently.patch RnJvbSAwNDJmZTFkOTBhYTEyZDc5ODM4N2I2MWRjZDM1MTE1NjI2NzE0ZmVjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKZWx0ZSBGZW5uZW1hLU5pbyA8Z2l0aHViLXRlY2hAamVsdGVm Lm5sPgpEYXRlOiBTdW4sIDIzIEZlYiAyMDI1IDE1OjQxOjQ4ICswMTAwClN1YmplY3Q6IFtQQVRD SCB2MiAyLzJdIFVzZSBkIGFsaWFzIGZvciBwZ19kZXNjcmlwdGlvbiBjb25zaXN0ZW50bHkKCklu IHRoZSBwc3FsIHF1ZXJ5IGZvciBcZHggd2UgdXNlZCAiYyIgYXMgYW4gYWxpYXMgZm9yIHBnX2Rl c2NyaXB0aW9uLgpUaGF0J3MgYSBwcmV0dHkgYXJiaXRyYXJ5IGxldHRlciBhbmQgZ2l2ZW4gdGhh dCBpbiBhbGwgb3RoZXIgcXVlcmllcyBpbgp1c2UgImQiIGFzIGFsaWFzIGZvciB0aGF0IHRhYmxl IHRoaXMgY2hhbmdlcyB0aGF0IHRvIGZvbGxvdyB0aGF0CmNvbnZlbnRpb24uCgpSZXBvcnRlZC1C eTogTWljaGFlbCBCYW5jawotLS0KIHNyYy9iaW4vcHNxbC9kZXNjcmliZS5jIHwgMiArLQogMSBm aWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEv c3JjL2Jpbi9wc3FsL2Rlc2NyaWJlLmMgYi9zcmMvYmluL3BzcWwvZGVzY3JpYmUuYwppbmRleCAw MWU2MjQzMGZmZi4uMGUxM2M4MWEyMDMgMTAwNjQ0Ci0tLSBhL3NyYy9iaW4vcHNxbC9kZXNjcmli ZS5jCisrKyBiL3NyYy9iaW4vcHNxbC9kZXNjcmliZS5jCkBAIC02MTkyLDcgKzYxOTIsNyBAQCBs aXN0RXh0ZW5zaW9ucyhjb25zdCBjaGFyICpwYXR0ZXJuKQogCQkJCQkgICJuLm5zcG5hbWUgQVMg XCIlc1wiLCBjLmRlc2NyaXB0aW9uIEFTIFwiJXNcIlxuIgogCQkJCQkgICJGUk9NIHBnX2NhdGFs b2cucGdfZXh0ZW5zaW9uIGUgIgogCQkJCQkgICJMRUZUIEpPSU4gcGdfY2F0YWxvZy5wZ19uYW1l c3BhY2UgbiBPTiBuLm9pZCA9IGUuZXh0bmFtZXNwYWNlICIKLQkJCQkJICAiTEVGVCBKT0lOIHBn X2NhdGFsb2cucGdfZGVzY3JpcHRpb24gYyBPTiBjLm9iam9pZCA9IGUub2lkICIKKwkJCQkJICAi TEVGVCBKT0lOIHBnX2NhdGFsb2cucGdfZGVzY3JpcHRpb24gZCBPTiBkLm9iam9pZCA9IGUub2lk ICIKIAkJCQkJICAiTEVGVCBKT0lOIHBnX2NhdGFsb2cucGdfYXZhaWxhYmxlX2V4dGVuc2lvbnMo KSBhZShuYW1lLCBkZWZhdWx0X3ZlcnNpb24sIGNvbW1lbnQpIE9OIGFlLm5hbWUgPSBlLmV4dG5h bWUgIgogCQkJCQkgICJBTkQgYy5jbGFzc29pZCA9ICdwZ19jYXRhbG9nLnBnX2V4dGVuc2lvbic6 OnBnX2NhdGFsb2cucmVnY2xhc3NcbiIsCiAJCQkJCSAgZ2V0dGV4dF9ub29wKCJOYW1lIiksCi0t IAoyLjQzLjAKCg== --564634f42d349a8d4867d50ed0d56c99edc377d87d58be79dd0a53d53b43--