Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51.11.1\))
Subject: Re: disabled SSL log_like tests
From: Daniel Gustafsson <daniel@yesql.se>
In-Reply-To: <80137.1746654871@sss.pgh.pa.us>
Date: Thu, 8 May 2025 13:20:06 +0200
Cc: Thomas Munro <thomas.munro@gmail.com>,
 Andrew Dunstan <andrew@dunslane.net>,
 PostgreSQL Hackers <pgsql-hackers@postgresql.org>,
 Jacob Champion <jacob.champion@enterprisedb.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <D9A0285C-D051-4E6F-B9F0-09CE3282EA54@yesql.se>
References: <984fca80-85a8-4c6f-a5cc-bb860950b435@dunslane.net>
 <2199758.1744901785@sss.pgh.pa.us>
 <1ce11d3f-624c-4003-a032-1b10cc138305@dunslane.net>
 <2814408.1745005558@sss.pgh.pa.us> <2859105.1745015195@sss.pgh.pa.us>
 <1120735.1745350422@sss.pgh.pa.us>
 <CA+hUKG+fLqyweHqFSBcErueUVT0vDuSNWui-ySz3+d_APmq7dw@mail.gmail.com>
 <3058990.1746485124@sss.pgh.pa.us> <3227092.1746580691@sss.pgh.pa.us>
 <CA+hUKGJkUJAwckjBr-=B9oUdDgjSEH+3njd__OnPoPuAtze3Qg@mail.gmail.com>
 <3248136.1746592452@sss.pgh.pa.us>
 <3004EFB2-8FFA-429A-AC5E-E3F40E002A94@yesql.se>
 <3320404.1746633879@sss.pgh.pa.us>
 <8E3E58BF-CC99-4C45-9FB8-3BA83AA6FDC8@yesql.se>
 <51363.1746646179@sss.pgh.pa.us>
 <8293D36E-8027-4DB8-AB41-5EA2C2A9A788@yesql.se>
 <80137.1746654871@sss.pgh.pa.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/D9A0285C-D051-4E6F-B9F0-09CE3282EA54%40yesql.se>
Precedence: bulk

> On 7 May 2025, at 23:54, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>=20
> Daniel Gustafsson <daniel@yesql.se> writes:
>> I haven't looked at the test in question yet, but we do skip some SSL =
tests if
>> running against libressl already so I assume this will be able to =
follow the
>> same pattern.
>=20
> Ah, thanks for the tip.  I propose the attached, which disables the
> RSA-PSS test altogether on LibreSSL, and modifies the
> intermediate-cert test to accept the result we're actually getting
> on LibreSSL.  We could revert that one if anyone can figure out
> how to make it better, but I don't wish to put any more time into
> it myself.

LGTM for now.

> +# Determine whether this build uses OpenSSL or LibreSSL. As a =
heuristic, the
> +# HAVE_SSL_CTX_SET_CERT_CB macro isn't defined for LibreSSL.
> +my $libressl =3D not check_pg_config("#define =
HAVE_SSL_CTX_SET_CERT_CB 1");

Longer term it would be nice to move this into SSL::Server and have the =
module
export a function or symbol which returns the underlying library and =
version,
but that's not for this patch.

> +
> +# As of 5/2025, LibreSSL doesn't actually work for RSA-PSS =
certificates.

Should we add a link to the relevant thread for future readers?  OpenBSD =
refer
to MARC for archiving which I believe is stable enough for an inclusion.

	https://marc.info/?l=3Dlibressl&m=3D174664225002441&w=3D2

--
Daniel Gustafsson