Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
From: Andrew Dunstan <andrew@dunslane.net>
Mime-Version: 1.0 (1.0)
Subject: Re: pg_waldump: support decoding of WAL inside tarfile
Date: Sat, 28 Mar 2026 21:59:21 -0400
Message-Id: <D9BBAD84-A69C-48BD-9C79-341EA04D8E13@dunslane.net>
References: <1633233.1774740875@sss.pgh.pa.us>
Cc: Thomas Munro <thomas.munro@gmail.com>, Tomas Vondra <tomas@vondra.me>,
 Andres Freund <andres@anarazel.de>, Michael Paquier <michael@paquier.xyz>,
 Amul Sul <sulamul@gmail.com>, Zsolt Parragi <zsolt.parragi@percona.com>,
 Robert Haas <robertmhaas@gmail.com>, Chao Li <li.evan.chao@gmail.com>,
 Anthonin Bonnefoy <anthonin.bonnefoy@datadoghq.com>,
 Masao Fujii <masao.fujii@gmail.com>,
 Jakub Wartak <jakub.wartak@enterprisedb.com>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
In-Reply-To: <1633233.1774740875@sss.pgh.pa.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/D9BBAD84-A69C-48BD-9C79-341EA04D8E13%40dunslane.net>
Precedence: bulk


> On Mar 28, 2026, at 7:34=E2=80=AFPM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>=20
> =EF=BB=BFThomas Munro <thomas.munro@gmail.com> writes:
>>> On Sun, Mar 29, 2026 at 11:37=E2=80=AFAM Tom Lane <tgl@sss.pgh.pa.us> wr=
ote:
>>> It looks like to make this test stable on modern FreeBSD,
>>> we need to see if tar accepts --no-read-sparse and use that
>>> switch if so.
>=20
>> Yeah.  Here's my attempt at perl.
>=20
> Andrew might have some stylistic suggestions, but this looks
> plausible to me.

Looks basically ok to me, although I wouldn=E2=80=99t make the variable name=
 all caps.

Cheers

Andrew