Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51.11.2\))
Subject: Re: Serverside SNI support in libpq
From: Daniel Gustafsson <daniel@yesql.se>
In-Reply-To: <359138.1777922557@sss.pgh.pa.us>
Date: Mon, 4 May 2026 22:31:36 +0200
Cc: Zsolt Parragi <zsolt.parragi@percona.com>,
 Michael Banck <mbanck@gmx.net>,
 Jacob Champion <jacob.champion@enterprisedb.com>,
 Jelte Fennema-Nio <postgres@jeltef.nl>,
 Heikki Linnakangas <hlinnaka@iki.fi>,
 "li.evan.chao" <li.evan.chao@gmail.com>,
 Michael Paquier <michael@paquier.xyz>,
 Andres Freund <andres@anarazel.de>,
 Pgsql Hackers <pgsql-hackers@lists.postgresql.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <DB146660-EED0-4926-B32A-1EF38EDFF4E9@yesql.se>
References: 
 <CAOYmi+nsqYiXLxN7G4A5edBJWXZ8qD=zFnaE2bEzuMj2_xBT7Q@mail.gmail.com>
 <B481FA78-0173-4D0F-84C5-EDFB613B6428@yesql.se>
 <AE0BE080-02E8-4EF2-980B-15302FA1599E@yesql.se>
 <A4CFF972-B404-4422-A9BF-E0E2797CCBF3@yesql.se>
 <CAN4CZFOGiKAX_gD4Ck+o79n5hAVr3UmuTbYwaABcCuhWA3UehQ@mail.gmail.com>
 <1C38F269-E552-4F78-9E88-E91CEDB12F35@yesql.se>
 <23D19F69-A8DE-4F89-99F6-5FC48762CE4D@yesql.se>
 <CAN4CZFOFAgfyjO7MtCajmtErL1uSzDrSEmxGHOwMFYY3J4Qp+A@mail.gmail.com>
 <561BF011-1626-43A5-BD82-913E67EEBA8B@yesql.se>
 <BAA4F15D-6295-41DD-A1F8-6F5C1E1ECC52@yesql.se>
 <7DA91781-AA47-447A-BA6F-99FE7E83954E@yesql.se>
 <CAN4CZFMo_AfSSAfa=0EaC1ARYuQk774R6kcZz6WJZH3oXvn4fw@mail.gmail.com>
 <1CEF92A7-B41A-46A2-BEBA-34307BFE594B@yesql.se>
 <359138.1777922557@sss.pgh.pa.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/DB146660-EED0-4926-B32A-1EF38EDFF4E9%40yesql.se>
Precedence: bulk

> On 4 May 2026, at 21:22, Tom Lane <tgl@sss.pgh.pa.us> wrote:

> It seems quite odd to me that load_host(), which in fact returns
> HostsFileLoadResult codes, is declared to return int.  That seems
> to have been done because HostsFileLoadResult wasn't declared in
> the same header, but there is no visible reason why it shouldn't be.
> Any objection to the attached fixup?

At some point during the development of the patch there was a reason =
(which I
cannot remember right now) for the declaration being in hba.h, but I =
clearly
missed moving it when that no longrer applied.  No objections to the =
patch,
thanks!

> As a side matter, "load_host" seems like a remarkably generic name
> that conveys little about what it actually does, and to the extent
> that it does convey anything the implication is wrong: it returns
> (potentially) info about multiple hosts not just one.  Can't we do
> better?

It's following the naming convention of load_hba() which reads =
pg_hba.conf, and
load_ident() which reads pg_ident.conf - thus load_hosts() for the =
function
that reads pg_hosts.conf.  Perhaps load_pg_hosts_conf() or =
load_hosts_config()
would convey more meaning?

--
Daniel Gustafsson