Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1nLVLC-000837-0t
	for pgsql-hackers@arkaria.postgresql.org; Sat, 19 Feb 2022 19:24:22 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1nLVL9-0001Jq-4x
	for pgsql-hackers@arkaria.postgresql.org; Sat, 19 Feb 2022 19:24:19 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <daniel@yesql.se>)
	id 1nLVL8-0001Jh-Rz
	for pgsql-hackers@lists.postgresql.org; Sat, 19 Feb 2022 19:24:18 +0000
Received: from smtp.outgoing.loopia.se ([93.188.3.37])
	by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <daniel@yesql.se>)
	id 1nLVL1-00047k-7Y
	for pgsql-hackers@lists.postgresql.org; Sat, 19 Feb 2022 19:24:18 +0000
Received: from s807.loopia.se (localhost [127.0.0.1])
	by s807.loopia.se (Postfix) with ESMTP id BA6782F1884C
	for <pgsql-hackers@lists.postgresql.org>; Sat, 19 Feb 2022 20:24:09 +0100 (CET)
Received: from s934.loopia.se (unknown [172.22.191.6])
	by s807.loopia.se (Postfix) with ESMTP id ABD8E2E28ACC;
	Sat, 19 Feb 2022 20:24:09 +0100 (CET)
Received: from s476.loopia.se (unknown [172.22.191.5])
	by s934.loopia.se (Postfix) with ESMTP id A99067DE89C;
	Sat, 19 Feb 2022 20:24:09 +0100 (CET)
X-Virus-Scanned: amavisd-new at amavis.loopia.se
X-Spam-Flag: NO
X-Spam-Score: -1
X-Spam-Level:
X-Spam-Status: No, score=-1 tagged_above=-999 required=6.2
	tests=[ALL_TRUSTED=-1] autolearn=disabled
Received: from s645.loopia.se ([172.22.191.5])
	by s476.loopia.se (s476.loopia.se [172.22.190.16]) (amavisd-new, port 10024)
	with LMTP id dm8jw9MlbLS1; Sat, 19 Feb 2022 20:24:09 +0100 (CET)
X-Loopia-Auth: user
X-Loopia-User: daniel@yesql.se
X-Loopia-Originating-IP: 89.255.232.193
Received: from [192.168.72.144] (customer-89-255-232-193.stosn.net [89.255.232.193])
	(Authenticated sender: daniel@yesql.se)
	by s645.loopia.se (Postfix) with ESMTPSA id 427A31570441;
	Sat, 19 Feb 2022 20:24:09 +0100 (CET)
Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.7\))
Subject: Re: doc: join state for merge join
From: Daniel Gustafsson <daniel@yesql.se>
In-Reply-To: <CALNJ-vQVthfQXVqmrHR8BKHtC4fMGbhM1xbvJNJAPexTq_dH=w@mail.gmail.com>
Date: Sat, 19 Feb 2022 20:24:09 +0100
Cc: PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <DB455024-1EAB-40C1-84DB-EB65FE3FF758@yesql.se>
References: <CALNJ-vQVthfQXVqmrHR8BKHtC4fMGbhM1xbvJNJAPexTq_dH=w@mail.gmail.com>
To: Zhihong Yu <zyu@yugabyte.com>
X-Mailer: Apple Mail (2.3608.120.23.2.7)
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/DB455024-1EAB-40C1-84DB-EB65FE3FF758%40yesql.se>
Precedence: bulk

> On 19 Feb 2022, at 14:20, Zhihong Yu <zyu@yugabyte.com> wrote:

> When i was looking at the code for ExecMergeJoin(), I noticed a few =
places where the join state name in the comment doesn't match the actual =
state.

Given the comments on the other states, I'm bound to agree.  Unless =
there are
objections I'll go ahead with this one.

--
Daniel Gustafsson		https://vmware.com/