Content-Type: multipart/mixed;
 boundary=9c575561e4b016bfc0eaf360ca5beee4a9e852d9f5a91c3972148ede29a7
Mime-Version: 1.0
Date: Mon, 29 Sep 2025 10:23:03 -0300
Message-Id: <DD5BEKORUG34.2M8492NMB9DB8@gmail.com>
To: <pgsql-hackers@lists.postgresql.org>
Subject: Remove unused parameter form find_window_run_conditions()
From: "Matheus Alcantara" <matheusssilv97@gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/DD5BEKORUG34.2M8492NMB9DB8%40gmail.com>
Precedence: bulk

--9c575561e4b016bfc0eaf360ca5beee4a9e852d9f5a91c3972148ede29a7
Content-Type: multipart/alternative;
 boundary=874cd37a1cbcd6e80e27fff8567d5f8d5d7e99cb1edd3823746d63e1cedb

--874cd37a1cbcd6e80e27fff8567d5f8d5d7e99cb1edd3823746d63e1cedb
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Content-Type: text/plain; charset=UTF-8

Hi,

Reading find_window_run_conditions() the RangeTableEntry *rte parameter
is not being used by find_window_run_conditions() and
check_and_push_window_quals(). The attached patch remove this parameter
from both functions.

The 4be9024d573 also remove unused parameter for both functions and
after studying more these functions I founded that the RangeTableEntry
is not being used as well. I've checked the other parameters and all
seems to be used now.

--
Matheus Alcantara

--874cd37a1cbcd6e80e27fff8567d5f8d5d7e99cb1edd3823746d63e1cedb--

--9c575561e4b016bfc0eaf360ca5beee4a9e852d9f5a91c3972148ede29a7
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
 filename=0001-Remove-unused-parameter-from-find_window_run_conditi.patch
Content-Type: text/plain; charset=utf-8;
 name=0001-Remove-unused-parameter-from-find_window_run_conditi.patch

RnJvbSAwZWFiNDM5OTUwN2YzY2I2ZmY0ZTBkMTQyOTA4OTI4MGQyMTM2NjIxIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXRoZXVzIEFsY2FudGFyYSA8bXRocy5kZXZAcG0ubWU+CkRh
dGU6IE1vbiwgMjkgU2VwIDIwMjUgMTA6MTQ6NTAgLTAzMDAKU3ViamVjdDogW1BBVENIXSBSZW1v
dmUgdW51c2VkIHBhcmFtZXRlciBmcm9tIGZpbmRfd2luZG93X3J1bl9jb25kaXRpb25zKCkKCi4u
LiBhbmQgY2hlY2tfYW5kX3B1c2hfd2luZG93X3F1YWxzKCkKLS0tCiBzcmMvYmFja2VuZC9vcHRp
bWl6ZXIvcGF0aC9hbGxwYXRocy5jIHwgMTIgKysrKysrLS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwg
NiBpbnNlcnRpb25zKCspLCA2IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5k
L29wdGltaXplci9wYXRoL2FsbHBhdGhzLmMgYi9zcmMvYmFja2VuZC9vcHRpbWl6ZXIvcGF0aC9h
bGxwYXRocy5jCmluZGV4IDEzMmU4YTM1YTM5Li4xMjkyNWExMTVkZCAxMDA2NDQKLS0tIGEvc3Jj
L2JhY2tlbmQvb3B0aW1pemVyL3BhdGgvYWxscGF0aHMuYworKysgYi9zcmMvYmFja2VuZC9vcHRp
bWl6ZXIvcGF0aC9hbGxwYXRocy5jCkBAIC0yMjU0LDggKzIyNTQsOCBAQCBzZXRfZHVtbXlfcmVs
X3BhdGhsaXN0KFJlbE9wdEluZm8gKnJlbCkKICAqIHJldHVybiBmYWxzZS4KICAqLwogc3RhdGlj
IGJvb2wKLWZpbmRfd2luZG93X3J1bl9jb25kaXRpb25zKFF1ZXJ5ICpzdWJxdWVyeSwgUmFuZ2VU
YmxFbnRyeSAqcnRlLAotCQkJCQkJICAgQXR0ck51bWJlciBhdHRubywgV2luZG93RnVuYyAqd2Z1
bmMsIE9wRXhwciAqb3BleHByLAorZmluZF93aW5kb3dfcnVuX2NvbmRpdGlvbnMoUXVlcnkgKnN1
YnF1ZXJ5LCBBdHRyTnVtYmVyIGF0dG5vLAorCQkJCQkJICAgV2luZG93RnVuYyAqd2Z1bmMsIE9w
RXhwciAqb3BleHByLAogCQkJCQkJICAgYm9vbCB3ZnVuY19sZWZ0LCBib29sICprZWVwX29yaWdp
bmFsLAogCQkJCQkJICAgQml0bWFwc2V0ICoqcnVuX2NvbmRfYXR0cnMpCiB7CkBAIC0yNDQ1LDcg
KzI0NDUsNyBAQCBmaW5kX3dpbmRvd19ydW5fY29uZGl0aW9ucyhRdWVyeSAqc3VicXVlcnksIFJh
bmdlVGJsRW50cnkgKnJ0ZSwKICAqIHdpbGwgdXNlIHRoZSBydW5Db25kaXRpb24gdG8gc3RvcCBy
ZXR1cm5pbmcgdHVwbGVzLgogICovCiBzdGF0aWMgYm9vbAotY2hlY2tfYW5kX3B1c2hfd2luZG93
X3F1YWxzKFF1ZXJ5ICpzdWJxdWVyeSwgUmFuZ2VUYmxFbnRyeSAqcnRlLCBOb2RlICpjbGF1c2Us
CitjaGVja19hbmRfcHVzaF93aW5kb3dfcXVhbHMoUXVlcnkgKnN1YnF1ZXJ5LCBOb2RlICpjbGF1
c2UsCiAJCQkJCQkJQml0bWFwc2V0ICoqcnVuX2NvbmRfYXR0cnMpCiB7CiAJT3BFeHByCSAgICpv
cGV4cHIgPSAoT3BFeHByICopIGNsYXVzZTsKQEAgLTI0ODUsNyArMjQ4NSw3IEBAIGNoZWNrX2Fu
ZF9wdXNoX3dpbmRvd19xdWFscyhRdWVyeSAqc3VicXVlcnksIFJhbmdlVGJsRW50cnkgKnJ0ZSwg
Tm9kZSAqY2xhdXNlLAogCQlUYXJnZXRFbnRyeSAqdGxlID0gbGlzdF9udGgoc3VicXVlcnktPnRh
cmdldExpc3QsIHZhcjEtPnZhcmF0dG5vIC0gMSk7CiAJCVdpbmRvd0Z1bmMgKndmdW5jID0gKFdp
bmRvd0Z1bmMgKikgdGxlLT5leHByOwogCi0JCWlmIChmaW5kX3dpbmRvd19ydW5fY29uZGl0aW9u
cyhzdWJxdWVyeSwgcnRlLCB0bGUtPnJlc25vLCB3ZnVuYywKKwkJaWYgKGZpbmRfd2luZG93X3J1
bl9jb25kaXRpb25zKHN1YnF1ZXJ5LCB0bGUtPnJlc25vLCB3ZnVuYywKIAkJCQkJCQkJCSAgIG9w
ZXhwciwgdHJ1ZSwgJmtlZXBfb3JpZ2luYWwsCiAJCQkJCQkJCQkgICBydW5fY29uZF9hdHRycykp
CiAJCQlyZXR1cm4ga2VlcF9vcmlnaW5hbDsKQEAgLTI0OTgsNyArMjQ5OCw3IEBAIGNoZWNrX2Fu
ZF9wdXNoX3dpbmRvd19xdWFscyhRdWVyeSAqc3VicXVlcnksIFJhbmdlVGJsRW50cnkgKnJ0ZSwg
Tm9kZSAqY2xhdXNlLAogCQlUYXJnZXRFbnRyeSAqdGxlID0gbGlzdF9udGgoc3VicXVlcnktPnRh
cmdldExpc3QsIHZhcjItPnZhcmF0dG5vIC0gMSk7CiAJCVdpbmRvd0Z1bmMgKndmdW5jID0gKFdp
bmRvd0Z1bmMgKikgdGxlLT5leHByOwogCi0JCWlmIChmaW5kX3dpbmRvd19ydW5fY29uZGl0aW9u
cyhzdWJxdWVyeSwgcnRlLCB0bGUtPnJlc25vLCB3ZnVuYywKKwkJaWYgKGZpbmRfd2luZG93X3J1
bl9jb25kaXRpb25zKHN1YnF1ZXJ5LCB0bGUtPnJlc25vLCB3ZnVuYywKIAkJCQkJCQkJCSAgIG9w
ZXhwciwgZmFsc2UsICZrZWVwX29yaWdpbmFsLAogCQkJCQkJCQkJICAgcnVuX2NvbmRfYXR0cnMp
KQogCQkJcmV0dXJuIGtlZXBfb3JpZ2luYWw7CkBAIC0yNjIyLDcgKzI2MjIsNyBAQCBzZXRfc3Vi
cXVlcnlfcGF0aGxpc3QoUGxhbm5lckluZm8gKnJvb3QsIFJlbE9wdEluZm8gKnJlbCwKIAkJCQkJ
ICogcnVuQ29uZGl0aW9uLgogCQkJCQkgKi8KIAkJCQkJaWYgKCFzdWJxdWVyeS0+aGFzV2luZG93
RnVuY3MgfHwKLQkJCQkJCWNoZWNrX2FuZF9wdXNoX3dpbmRvd19xdWFscyhzdWJxdWVyeSwgcnRl
LCBjbGF1c2UsCisJCQkJCQljaGVja19hbmRfcHVzaF93aW5kb3dfcXVhbHMoc3VicXVlcnksIGNs
YXVzZSwKIAkJCQkJCQkJCQkJCQkmcnVuX2NvbmRfYXR0cnMpKQogCQkJCQl7CiAJCQkJCQkvKgot
LSAKMi41MC4xIChBcHBsZSBHaXQtMTU1KQoK
--9c575561e4b016bfc0eaf360ca5beee4a9e852d9f5a91c3972148ede29a7--