Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1v6F8p-001Weh-GC for pgsql-hackers@arkaria.postgresql.org; Tue, 07 Oct 2025 21:22:39 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1v6F8l-003yQS-MG for pgsql-hackers@arkaria.postgresql.org; Tue, 07 Oct 2025 21:22:36 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1v6F8l-003yQD-CK for pgsql-hackers@lists.postgresql.org; Tue, 07 Oct 2025 21:22:36 +0000 Received: from mail-pj1-x102b.google.com ([2607:f8b0:4864:20::102b]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1v6F8k-000vPm-0A for pgsql-hackers@postgresql.org; Tue, 07 Oct 2025 21:22:35 +0000 Received: by mail-pj1-x102b.google.com with SMTP id 98e67ed59e1d1-32eb76b9039so8847269a91.1 for ; Tue, 07 Oct 2025 14:22:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1759872151; x=1760476951; darn=postgresql.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=HWzC1rRiFFAUvl7F9RKva0Ox6FocQi9wJBo3Dt9jq4g=; b=UMUdEG460RdzpXAhs+PNnhJGJCmVNUby4vLKgPLVFXaHEZvtngSMm9sXGcGqKLPrFH tMBDwCcdX6rKhsk3SCOgimNeH1WdtrngNxtelS9iMiWqQyCHW4Rm0CJcgzhnUsdisjU5 xoLx1GzNdUOSX67KOYvMYKb8CIBoUfDXkBxClFntzFYjSBP3hBZA9yCPQ8NhOwom8Pwq MnuRb5Cqn52ZyvdByhn+BxxHQlPkzAZVuFTRVwZO6K47R2+ql6ubC3zsGaUdj55e9mex 50Izk+iNKi5xB4i7ezl4ok/bEJE8C6Vg1v2YRIRcmpV7a7MRhyUZobdM1JpirkHI6n+/ 8xYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759872151; x=1760476951; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=HWzC1rRiFFAUvl7F9RKva0Ox6FocQi9wJBo3Dt9jq4g=; b=HW5dd0b2pQiA07js8mjjkEeI8gg7sb9ksR1k+mP2oHTDrG57ZBSz9LJ5d43j7LVYFk 8Erpaq80dVLzsYCyxeSMe2XtogItBbk/B/g43yw9dqs0wjIQ80Aoxo/RjOmCxzvXGM+X 2EczUcua3fM5gVcC0+6tdXocKBmp8tecbqF0QMaY2+ohQh6FBodD2Hf8wCFIxiU7zFDo A1xNOIQC5eFWVimQtYjinVxXsxeEEXD4heZZrO9eTwqbHGpBjFOxrjao/rzDIctl5wzN lpoCm2f9LE5NFYFaxiPwidp8PZSPBuM8SdNqq3f5wJjYvVOs1k2F6VXg8cO4w+oD+lXs emAQ== X-Forwarded-Encrypted: i=1; AJvYcCW1bUOUwWT4wQY3M3sJDu6DgEydz3B5ZlUjiAd30e0ZNwlAPZzh7BiJ4duQxwxmNDXkzFpMcn39xOEqxOzP@postgresql.org X-Gm-Message-State: AOJu0YwOVuO9DoWSCFcgKPzHAlnO7ArNcBpTX8eivyokI19m3lq+Bm/S LPZ9ktC9pIZIRdy3ziRnqe7Oxl9ymNcOQh3YltSx3m+4MAx4hDV7lAQ4 X-Gm-Gg: ASbGncuX2koZoDk7G369PRe0HR55X4nLIBLjlYOWomWInUb3MqB3uCwQBjeoy9RWddy 3KoPGKN6vEXLYtahSp2VZR0i9aKYopsLKJ/dRlEj/rQ3YS3ifFz0uBIXM90VzTaUOTBJuIG2vSy C6cGzi+cYtg+JJnAf7ngXFDna3ZZOL+DxQyKHOVg/ugjPZ5vFcb9+XtofyEb4NWVjR0rZbi1soE aLgnrhNPvfUcx5N14x6vNbuEe61GCHct3rSGYRfhRhYe40vxt/AN3doX6DoNaiyll6/V4yuHWV9 Ov2WPhbliqvE2Du9vu2f7vJScYKe6RoknhJ3fE7Jtz2QfKF3JP585WHzogdR/XWz1j14lTR8wj9 kYn2bDTGVB3JD0Lz3i6lSLvV91DopzegqNQaTf37Ez41iGapYxdsA+nKL9DQlvFJ8LL0IlZ8Xsc 9a32mA X-Google-Smtp-Source: AGHT+IFozJ8J902o0mWexGD5y3ET2B5HKFyM/2RY76XZqQ98gPILh6rJf5xa095+RVIxcTLnwQh0YQ== X-Received: by 2002:a17:90a:e7cd:b0:335:3105:81d2 with SMTP id 98e67ed59e1d1-33b5139a11emr1199051a91.35.1759872150651; Tue, 07 Oct 2025 14:22:30 -0700 (PDT) Received: from localhost ([2804:14d:328a:a59c:cd72:c92f:e473:560d]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-33b50f07431sm723987a91.0.2025.10.07.14.22.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Oct 2025 14:22:29 -0700 (PDT) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 07 Oct 2025 18:22:26 -0300 Message-Id: Cc: "Joel Jacobson" , "pgsql-hackers" Subject: Re: Optimize LISTEN/NOTIFY From: "Matheus Alcantara" To: "Tom Lane" , "Matheus Alcantara" X-Mailer: aerc 0.21.0 References: <6899c044-4a82-49be-8117-e6f669765f7e@app.fastmail.com> <165530.1752362320@sss.pgh.pa.us> <02a7cd37-e2fc-4212-8b19-f8c239c95fb8@app.fastmail.com> <96f00bf1-cc9d-4520-9d02-9e14e7767c88@app.fastmail.com> <30c2aa7d-dd6c-4b68-a2e4-f217a1a34acf@app.fastmail.com> <0b4d402a-9ac2-4aa8-acf8-8231dbe579ea@app.fastmail.com> <3095599.1758644879@sss.pgh.pa.us> <0dc6a2cc-5216-4dc1-9dd2-430cafc6095b@app.fastmail.com> <52CC167F-763B-4ECA-B0B4-DAB381816828@gmail.com> <9186C6D0-F7A9-482A-9183-89E530B57E36@gmail.com> <1073593.1759423179@sss.pgh.pa.us> <4bd5e6c4-6fa7-44bb-869d-59a32a331fa8@app.fastmail.com> <2451053.1759855880@sss.pgh.pa.us> <2538963.1759871856@sss.pgh.pa.us> In-Reply-To: <2538963.1759871856@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Tue Oct 7, 2025 at 6:17 PM -03, Tom Lane wrote: > "Matheus Alcantara" writes: >> On Tue Oct 7, 2025 at 1:51 PM -03, Tom Lane wrote: >>> Also, I don't think it's the job of this patch to provide test >>> coverage for dshash. That should be quite well covered already. > >> When I was mentioning to test that we can grow the dshash correctly it's >> because the v9 patch has a logic to grow the array stored on dshash >> entry value that currently is not being cover by the tests. I'm not >> saying to test the dshash internal logic which I agree that it's not the >> job of this patch. Sorry for being confusing. > > Ah, yeah, I misunderstood what you meant. I agree that covering that > "Grow the array" stanza is a good idea, in fact I said the same thing > a little bit ago. > Yeah, I just saw your response after I sent the email, which I agree with all the points. So I think that we are on the same "page" now. -- Matheus Alcantara