Received: from malur.postgresql.org ([217.196.149.56])
 by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from
 <pgsql-hackers-owner+M243080=pgsql-hackers-arkari@postgresql.org>)
 id 1W7oXS-0000ex-Uh
 for pgsql-hackers@arkaria.postgresql.org; Mon, 27 Jan 2014 15:55:55 +0000
Received: from localhost ([127.0.0.1] helo=postgresql.org)
 by malur.postgresql.org with smtp (Exim 4.80) (envelope-from
 <pgsql-hackers-owner+M243080=pgsql-hackers-arkari@postgresql.org>)
 id 1W7oXS-0007Np-3M
 for pgsql-hackers@arkaria.postgresql.org; Mon, 27 Jan 2014 15:55:54 +0000
Received: from makus.postgresql.org ([2001:4800:7903:4::125])
 by malur.postgresql.org with esmtp (Exim 4.80)
 (envelope-from <atri.jiit@gmail.com>) id 1W7oXQ-0007Nh-Bw
 for pgsql-hackers@postgresql.org; Mon, 27 Jan 2014 15:55:52 +0000
Received: from mail-pa0-x22c.google.com ([2607:f8b0:400e:c03::22c])
 by makus.postgresql.org with esmtp (Exim 4.80)
 (envelope-from <atri.jiit@gmail.com>) id 1W7oXN-0004NJ-27
 for pgsql-hackers@postgresql.org; Mon, 27 Jan 2014 15:55:51 +0000
Received: by mail-pa0-f44.google.com with SMTP id kq14so6038509pab.17
 for <pgsql-hackers@postgresql.org>; Mon, 27 Jan 2014 07:55:47 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=references:mime-version:in-reply-to:content-type
 :content-transfer-encoding:message-id:cc:from:subject:date:to;
 bh=oB6Wd4caqvWzsBJgfEYNx5xjtbxfSRxpsj/QnvP/a80=;
 b=LZlDFZkEEUaImQm+NKLInKow8yqbzcTmNd7ylS2DtGaBLWpUZsSONNsNgD7TtCEkcT
 NTJ9rlwyLxF06sNvv9MfnZJR2jEWzNAN3LTB+5weIM7deOfV9kG9skuVoX4cfoXiHUu+
 QeHrS13tsF9YvAIyVpa6nAqrG7+B6FHgnyiqGh3iaeRUPZ6Pi1K34KLo1exmAXYMADkk
 93Lm6zunz5X+Bsar5Zi8p9JAHjrKSSpxRRfo9RP9MjUQ63Ifg/t2ztWP0hVaLmQKpEVb
 O+lxKfhzzzh4+YCsKIxsazu8Ebw8aa25yWZLNp/TFlbYeX35THlSuSdb+frwQwf6w/S6
 6A/w==
X-Received: by 10.66.197.135 with SMTP id iu7mr3507860pac.149.1390838147746;
 Mon, 27 Jan 2014 07:55:47 -0800 (PST)
Received: from [192.168.1.4] ([122.177.144.239])
 by mx.google.com with ESMTPSA id nv7sm33026650pbc.31.2014.01.27.07.55.44
 for <multiple recipients>
 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128);
 Mon, 27 Jan 2014 07:55:46 -0800 (PST)
References: 
 <CAEZqfEfVJNptoTSEY3QrQ90K9WD2nxfM+6fsk3YTc1ZXZ1Y5-g@mail.gmail.com>
 <12432.1384406906@sss.pgh.pa.us>
 <CA+Tgmob3ZNDi+P+v3ypHvFN1tD-Bpt8M+0dHFTnCqHxmcNw8aQ@mail.gmail.com>
 <10163.1384786524@sss.pgh.pa.us>
 <CAEZqfEc6MkEx+L=bQHVPEjr_+LgWSzy8uA11ci=X0A8VEPRmiw@mail.gmail.com>
 <52DDD071.9090405@ak.jp.nec.com>
 <CAEZqfEe_enXpSFpS8S_q6a8gNHK8AKtD5vy=fYxTddRtR8uOmw@mail.gmail.com>
 <CA+TgmoZiskpRfmSZuY01Uh3qBqPRb3-UgXnS-euUO5cw9Yst3Q@mail.gmail.com>
 <52E5F3FD.6050000@lab.ntt.co.jp> <52E6137B.1080704@lab.ntt.co.jp>
 <20140127153322.GB11668@fetter.org>
Mime-Version: 1.0 (1.0)
In-Reply-To: <20140127153322.GB11668@fetter.org>
Content-Type: text/plain;
	charset=us-ascii
Content-Transfer-Encoding: quoted-printable
Message-Id: <DED41473-95CF-43A8-ACC5-33C9DC893CE0@gmail.com>
Cc: Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>,
 "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
X-Mailer: iPad Mail (11A501)
From: Atri Sharma <atri.jiit@gmail.com>
Subject: Re: inherit support for foreign tables
Date: Mon, 27 Jan 2014 21:25:42 +0530
To: David Fetter <david@fetter.org>
X-Pg-Spam-Score: -2.0 (--)
List-Archive: <http://archives.postgresql.org/pgsql-hackers>
List-Help: <mailto:majordomo@postgresql.org?body=help>
List-ID: <pgsql-hackers.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@postgresql.org>
List-Post: <mailto:pgsql-hackers@postgresql.org>
List-Subscribe: <mailto:majordomo@postgresql.org?body=sub%20pgsql-hackers>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
X-Mailing-List: pgsql-hackers
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org



Sent from my iPad

> On 27-Jan-2014, at 21:03, David Fetter <david@fetter.org> wrote:
>=20
>> On Mon, Jan 27, 2014 at 05:06:19PM +0900, Etsuro Fujita wrote:
>> Hi Hanada-san,
>>=20
>> While still reviwing this patch, I feel this patch has given enough
>> consideration to interactions with other commands, but found the
>> following incorrect? behabior:
>>=20
>> postgres=3D# CREATE TABLE product (id INTEGER, description TEXT);
>> CREATE TABLE
>> postgres=3D# CREATE FOREIGN TABLE product1 () INHERITS (product)
>> SERVER fs OPTIONS (filename '/home/foo/product1.csv', format 'csv');
>> CREATE FOREIGN TABLE
>> postgres=3D# ALTER TABLE product ALTER COLUMN description SET STORAGE
>> EXTERNAL;
>> ERROR:  "product1" is not a table or materialized view
>>=20
>> ISTN the ALTER TABLE simple recursion mechanism (ie
>> ATSimpleRecursion()) should be modified for the ALTER COLUMN SET
>> STORAGE case.
>=20
> This points to a larger discussion about what precisely foreign tables
> can and cannot inherit from local ones.  I don't think that a generic
> solution will be satisfactory, as the PostgreSQL FDW could, at least
> in principle, support many more than the CSV FDW, as shown above.
>=20
> In my estimation, the outcome of discussion above is not a blocker for
> this=20

I wonder what shall be the cases when foreign table is on a server which do=
es not support *all* SQL features.

Does a FDW need to have the possible inherit options mentioned in its docum=
entation for this patch?

Regards,

Atri

--=20
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers