Feedback-ID: idd01497b:Fastmail
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Sun, 21 Dec 2025 08:19:04 +0000
Message-Id: <DF3QX1B91OKO.182K0IH9QDQUY@partin.io>
Cc: "AIX PG user" <postgres-ibm-aix@wwpdl.vnet.ibm.com>
Subject: Re: AIX support
To: "Srirama Kucherlapati" <sriram.rk@in.ibm.com>, "Peter Eisentraut"
 <peter@eisentraut.org>, "pgsql-hackers@lists.postgresql.org"
 <pgsql-hackers@lists.postgresql.org>, "Heikki Linnakangas"
 <hlinnaka@iki.fi>
From: "Tristan Partin" <tristan@partin.io>
References: 
 <CY5PR11MB63928CC05906F27FB10D74D0FD322@CY5PR11MB6392.namprd11.prod.outlook.com>
 <794e9968-c48f-4ec3-a5f9-a7e8faca8979@eisentraut.org>
 <176279401378.2081919.12877701948713975661.pgcf@coridan.postgresql.org>
 <SJ4PPFB817783263EA0FD91EBC346308C51DBA3A@SJ4PPFB81778326.namprd15.prod.outlook.com>
 <c4a5fcf5-fd41-4548-a18a-c05761979c9a@eisentraut.org>
 <SJ4PPFB817783267BD66F22BFC328D93F81DBA8A@SJ4PPFB81778326.namprd15.prod.outlook.com>
In-Reply-To: 
 <SJ4PPFB817783267BD66F22BFC328D93F81DBA8A@SJ4PPFB81778326.namprd15.prod.outlook.com>
Archived-At: 
 <https://www.postgresql.org/message-id/DF3QX1B91OKO.182K0IH9QDQUY%40partin.io>
Precedence: bulk

Thanks for your continued push for AIX support! Here are a few comments:

> # The static libpq is skipped in AIX. This is not required.

For comments like this, I would generally like to see some links or=20
inline documentation to why this is the case. Maybe Peter or Heikki=20
disagree.

There are a few places in the Meson code like the following:

	if AIX:
		don't define the static library target
	endif

Make sure that the innards of the if statements are indented.=20
Alternatively, you could define something like:

	static_library_dependencies =3D []
	if host_machine.system() =3D=3D 'AIX'
		# TODO: Document this
		AIX_poison_pill =3D disabler()
		static_library_dependencies +=3D AIX_poison_pill
	endif

And then for all static library definitions, you would just make sure=20
that they all depend on the poison pill. You could document the AIX=20
shared/static library situation where the AIX_poison_pill variable is=20
defined. I'd like to see if Peter thinks this is a good idea before=20
implementing it.

I'm also a little confused by the second patch. Some of it seems to be=20
the same, and some other parts seem to be new. Should we consolidate all=20
Meson AIX support into one patch? Overall, I think the size of the patch=20
is good, and seem pretty maintainable.

--=20
Tristan Partin
Databricks (https://databricks.com)