Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8; format=Flowed
Date: Thu, 08 Jan 2026 13:49:44 +0100
Message-Id: <DFJ7Y36W9C86.3K416WEM16SJF@jeltef.nl>
Cc: "Andres Freund" <andres@anarazel.de>, "PostgreSQL Hackers"
 <pgsql-hackers@postgresql.org>, "Robert Haas" <robertmhaas@gmail.com>,
 "Daniel Gustafsson" <daniel@yesql.se>, "Tom Lane" <tgl@sss.pgh.pa.us>,
 "Peter Eisentraut" <peter@eisentraut.org>, "Nazir Bilal Yavuz"
 <byavuz81@gmail.com>
Subject: Re: RFC: adding pytest as a supported test framework
To: "Jacob Champion" <jacob.champion@enterprisedb.com>
From: "Jelte Fennema-Nio" <postgres@jeltef.nl>
References: <CAOYmi+moGFuBaaAHq=kixGk0YuOZan09Wn5O4WAzA-xLTEumaA@mail.gmail.com> <CA+TgmoY4DRMVEV7CVo1D8p==ExsN69W89rF7-Ax4V=M9HGWL7g@mail.gmail.com> <CA+TgmoZV8B35Mvx8DqHtJjHDQxscJhwOWzNWiPj+dsUhwaUfSg@mail.gmail.com> <2302192.1718380169@sss.pgh.pa.us> <CAOYmi+k214g1tgREvQkUcr=OCiVKyaTDu1ja+OGAygG1y=jhPQ@mail.gmail.com> <CAOYmi+nEqA2LmetcJKUDmctypPLLumkVwj3vQ3idYd8yAGza5Q@mail.gmail.com> <CAOYmi+kebAt6wSX7ee0c0kMzV7r0hp93bAt10V5a88yHHUKwog@mail.gmail.com> <CAOYmi+=CrBFBRX-foRRES2tx2wXBJJhbsJGjgFbWvPcmBJuK-Q@mail.gmail.com> <DDOUZE2TCU8O.89TN0AS4GLP7@jeltef.nl> <DE5BODEZ607Y.3LNII22O5N27O@jeltef.nl> <g4gdtfedwwdgu5sbcopjt3djtqk6p2q7n5nymp7ppapfwukoyd@ev2v4jtsbure> <CAOYmi+mV97+FC=ME0EZj+3LBFHZ3g_xGmTGA_3u+TwJ_pvpFWw@mail.gmail.com> <DFHQQ4VS43SU.25NN2Y5GDWANL@jeltef.nl> <CAOYmi+ng-7j6JTzD5pe3AutHZ=LAJqVN1ZGNQwKAOfA2MYiBfg@mail.gmail.com>
In-Reply-To: <CAOYmi+ng-7j6JTzD5pe3AutHZ=LAJqVN1ZGNQwKAOfA2MYiBfg@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/DFJ7Y36W9C86.3K416WEM16SJF%40jeltef.nl>
Precedence: bulk

On Wed Jan 7, 2026 at 2:01 AM CET, Jacob Champion wrote:
> It's perfectly okay if you'd like to tie the GoAway proposal to this,
> but that seems like it's unlikely to result in short-term success.=20

To be clear, I did not mean to tie the GoAway proposal to this. I meant
to tie committing of *automated tests* for GoAway to this. Given how
little of our libpq interface is tested, I don't think that needs to be
a blocker for the GoAway feature itself.

Timing wise, I'd myself much rather have this patchset as an early PG20
commit than a last minute PG19 one.

> Writing code to start and stop a server and run SQL is a matter of
> programming. Writing a test suite that newcomers can intuitively use,
> and test interesting new things with, is a long-term collaboration. I
> am much more interested in doing the latter, because we already have
> the former, and personally I'm happy to build momentum slowly and wait
> on a group of people who are in a good place to discuss it.

Sure, it's a matter of programming. But my feeling is that most people
on the list don't want to build their own test infrastructure. They want
good infrastructure to "just exist", so they can write tests easily with
it.

So that's why after trying to use your initial attempt for a test of
mine, I moved the useful parts to a shared part of the codebase. So that
people can easily try writing a test with it, and explain what they like
or don't like. Instead of having to create or copy a bunch of
boilerplate every time they want to do something.

In any case, that's where we're at now. It would be nice if you could
take a look at the actual patchset at some point, but no rush.