Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1voLS7-001lkX-2E for pgsql-hackers@arkaria.postgresql.org; Fri, 06 Feb 2026 13:00:51 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1voLS6-003qeq-2F for pgsql-hackers@arkaria.postgresql.org; Fri, 06 Feb 2026 13:00:50 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1voLS6-003qei-0q for pgsql-hackers@lists.postgresql.org; Fri, 06 Feb 2026 13:00:50 +0000 Received: from mail-yw1-x112d.google.com ([2607:f8b0:4864:20::112d]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1voLS4-00000000qIa-0efV for pgsql-hackers@lists.postgresql.org; Fri, 06 Feb 2026 13:00:49 +0000 Received: by mail-yw1-x112d.google.com with SMTP id 00721157ae682-79427f739b0so23288577b3.3 for ; Fri, 06 Feb 2026 05:00:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770382847; x=1770987647; darn=lists.postgresql.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=P60YcomJjFBJcYpzlSvbKwZGf44DnO89JELdj3GDXhs=; b=YKpbROD+0nkgALvxegtgZWhLWDUF0Y61DpTb4g1aBqoWUDKV9qbAzBgFXKNBNjL1Pz pbVa3JVixWdpIORFt+Os+JinkEw8163jcFrGEiAl7+kMEVwE/b07hAuZLYGhLdi9OEpS itMV8xudqgvdSk9XlnnDnwoPemjOpAvQhdGDeiyNPjnTyh4sIhuKxaG2osPv1uY9BGs1 S7QzZKtUlWT+RgjHNn1MdVtR/V8zxhXAX7ltnAYvqKf2lsgepQnTXmcNlQuxP8j6ri6A zTeRDQJb5BQ07Tvc8Pu9D2c7T7W+tdI2RqZmivzKug8xZ3Xn2wyosNtizVwBgfCqhdq4 Sfvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770382847; x=1770987647; h=in-reply-to:references:to:from:subject:cc:message-id:date :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=P60YcomJjFBJcYpzlSvbKwZGf44DnO89JELdj3GDXhs=; b=wVixCnsp6kykqJhLYvhMMUkx2O9+/T/Qhr7NNTeSE4HJLed57q+ZzxIOugnScDeBUK ZwEM6prS31/e/oMnvae/tfMZBW7aV9w9K+yKxPHVcRC8OgGx6VP1IR3u0wbMEi5XpPTI 3m23T8L3C8l4Ieywrpxd/cjLQ3nc/eaWUCPQa/d99ifGVD0HwEwgfQIxbT3Z0s9sB+pi 42ykYdpxkeMjlUv/SaLurT0E9zbJGtYpc37y47zLMVUCBFvwXvDX9yGmQAS+DC5a0SoH LBz/IEjNTypXMy/poAqgaydVPmrF3/Ri5xupnugMogTcxebmLb8DBQbr/AYVRJePtX9W Ab8g== X-Forwarded-Encrypted: i=1; AJvYcCU23wSzE81ladFcRB+il1x+OSeXw+DLXl/eDHDkowbbW+YIvMV0ccVqFvylYQrmY0eqWLZXEQxyaQsZR+Tx@lists.postgresql.org X-Gm-Message-State: AOJu0YxI4gu+LvqyJtH5pbShaMq1MV/OqO68x5LjvwucBwo8KpEw5mHz hG3pLUkMRaoiN4wtHTsUyhWwOdTjJyID9uyKUGHXjRi0NMAQcIlY1K7l X-Gm-Gg: AZuq6aK+KOyDW50GCgDS2M71y00UbbBAYQhNjArTFPOr4AR3UPDqSH6I0I2UHnPWyym EKgX8CIAlpEDm5yHh+nGZreeWNgzn1MR/dLjBXduu5FJpul5/LjKzMgseC0z5If3vxmpr82jIRO GrAICjip/1b5Sntk6AYloag7Aq2kSqgm3hUeHlSQIZKg94VbcPJDXTn2D2m/lsMUbnEZfla62vF I/y12hzpmHU+QVgy6XAV8BDKAX/WEVBLz/HmvB+Qk/gqX3r4kB8gZrEM20a9CBeBlnzlpHuXmBT ToYUrMV1WMxGVgLqb0TdkIFZQA1X3rATIovipwyFx3Bw39Y09MPy4p4JY+DVEtEmiyLxS6FUvKQ ij8O49lisiIX6ANAwgZN+GfILmGcPWe6qoSy+IRN6NBsYPT5Kglb/7sSBEgE8RDgLBCJ9najAjX BlYGkBaIduBIch6ESagFGeIQVkfmcYUaCJJQ== X-Received: by 2002:a05:690c:39f:b0:794:eb40:6745 with SMTP id 00721157ae682-7952ab7ea3emr25463117b3.63.1770382846495; Fri, 06 Feb 2026 05:00:46 -0800 (PST) Received: from localhost ([2804:14d:328a:a59c:4d20:d883:f7a1:b34c]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7952a01616esm20778087b3.7.2026.02.06.05.00.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Feb 2026 05:00:45 -0800 (PST) Content-Type: multipart/mixed; boundary=43332367b511260997b589a6a403621f5201438e216815667a8faaa6ff56 Mime-Version: 1.0 Date: Fri, 06 Feb 2026 10:00:36 -0300 Message-Id: Cc: "torikoshia" , "Masahiko Sawada" , "vignesh C" , "Jim Jones" , "Kirill Reshke" , "Fujii Masao" , "David G. Johnston" , "Yugo NAGATA" , "PostgreSQL Hackers" Subject: Re: Change COPY ... ON_ERROR ignore to ON_ERROR ignore_row From: "Matheus Alcantara" To: "jian he" X-Mailer: aerc 0.21.0 References: <901967e5-e5dc-42c6-b2bf-fb3a49d7e787@gmail.com> <4c540fe3-495c-4bbf-8dcf-2c1e2b88bc3d@gmail.com> In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --43332367b511260997b589a6a403621f5201438e216815667a8faaa6ff56 Content-Type: multipart/alternative; boundary=20896cb616f43c1da8535741910e72952ec5ca7b6ba9a1748ea8cb4ca325 --20896cb616f43c1da8535741910e72952ec5ca7b6ba9a1748ea8cb4ca325 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Content-Type: text/plain; charset=UTF-8 On Fri Feb 6, 2026 at 9:58 AM -03, Matheus Alcantara wrote: > Thanks, overall the patch looks good to me. I'm attaching a diff with > just some small tweaks on documentation and error messages. Please see > and check if it's make sense. > I miss to include the diff file, sorry about that. -- Matheus Alcantara EDB: https://www.enterprisedb.com --20896cb616f43c1da8535741910e72952ec5ca7b6ba9a1748ea8cb4ca325-- --43332367b511260997b589a6a403621f5201438e216815667a8faaa6ff56 Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=v22-0001-tweaks.diff.nocfbot Content-Type: text/plain; charset=utf-8; name=v22-0001-tweaks.diff.nocfbot ZGlmZiAtLWdpdCBhL2RvYy9zcmMvc2dtbC9tb25pdG9yaW5nLnNnbWwgYi9kb2Mvc3JjL3NnbWwv bW9uaXRvcmluZy5zZ21sCmluZGV4IGRjZjZlNmEyZjQ4Li4yYWViMzhhNmU1ZiAxMDA2NDQKLS0t IGEvZG9jL3NyYy9zZ21sL21vbml0b3Jpbmcuc2dtbAorKysgYi9kb2Mvc3JjL3NnbWwvbW9uaXRv cmluZy5zZ21sCkBAIC02MjY1LDEwICs2MjY1LDEzIEBAIEZST00gcGdfc3RhdF9nZXRfYmFja2Vu ZF9pZHNldCgpIEFTIGJhY2tlbmRpZDsKICAgICAgICA8c3RydWN0ZmllbGQ+dHVwbGVzX3NraXBw ZWQ8L3N0cnVjdGZpZWxkPiA8dHlwZT5iaWdpbnQ8L3R5cGU+CiAgICAgICA8L3BhcmE+CiAgICAg ICA8cGFyYT4KLSAgICAgICBOdW1iZXIgb2YgdHVwbGVzIHNraXBwZWQgYmVjYXVzZSB0aGV5IGNv bnRhaW4gbWFsZm9ybWVkIGRhdGEuCi0gICAgICAgVGhpcyBjb3VudGVyIG9ubHkgYWR2YW5jZXMg d2hlbgotICAgICAgIDxsaXRlcmFsPmlnbm9yZTwvbGl0ZXJhbD4gaXMgc3BlY2lmaWVkIHRvIHRo ZSA8bGl0ZXJhbD5PTl9FUlJPUjwvbGl0ZXJhbD4KLSAgICAgICBvcHRpb24uCisgICAgICAgTnVt YmVyIG9mIHR1cGxlcyB0aGF0IGNvbnRhaW5lZCBtYWxmb3JtZWQgZGF0YS4gV2hlbgorICAgICAg IDxsaXRlcmFsPk9OX0VSUk9SPC9saXRlcmFsPiBpcyBzZXQgdG8gPGxpdGVyYWw+aWdub3JlPC9s aXRlcmFsPiwKKyAgICAgICB0aGlzIGNvdW50cyByb3dzIHRoYXQgd2VyZSBza2lwcGVkLiBXaGVu IHNldCB0bworICAgICAgIDxsaXRlcmFsPnNldF9udWxsPC9saXRlcmFsPiwgdGhpcyBjb3VudHMg cm93cyB3aGVyZSBhdCBsZWFzdCBvbmUKKyAgICAgICBjb2x1bW4gd2FzIHNldCB0byBudWxsIGR1 ZSB0byBhIGNvbnZlcnNpb24gZXJyb3IuCisgICAgICAgVGhpcyBjb3VudGVyIG9ubHkgYWR2YW5j ZXMgd2hlbiA8bGl0ZXJhbD5PTl9FUlJPUjwvbGl0ZXJhbD4KKyAgICAgICBpcyBzZXQgdG8gPGxp dGVyYWw+aWdub3JlPC9saXRlcmFsPiBvciA8bGl0ZXJhbD5zZXRfbnVsbDwvbGl0ZXJhbD4uCiAg ICAgICA8L3BhcmE+PC9lbnRyeT4KICAgICAgPC9yb3c+CiAgICAgPC90Ym9keT4KZGlmZiAtLWdp dCBhL3NyYy9iYWNrZW5kL2NvbW1hbmRzL2NvcHlmcm9tcGFyc2UuYyBiL3NyYy9iYWNrZW5kL2Nv bW1hbmRzL2NvcHlmcm9tcGFyc2UuYwppbmRleCA5NmJhMjNlOTYxYy4uMGE3NTgwMGI4YWIgMTAw NjQ0Ci0tLSBhL3NyYy9iYWNrZW5kL2NvbW1hbmRzL2NvcHlmcm9tcGFyc2UuYworKysgYi9zcmMv YmFja2VuZC9jb21tYW5kcy9jb3B5ZnJvbXBhcnNlLmMKQEAgLTEwNTIsNiArMTA1MiwxMSBAQCBD b3B5RnJvbVRleHRMaWtlT25lUm93KENvcHlGcm9tU3RhdGUgY3N0YXRlLCBFeHByQ29udGV4dCAq ZWNvbnRleHQsCiAJCQkJY3N0YXRlLT5udW1fZXJyb3JzKys7CiAJCQllbHNlIGlmIChjc3RhdGUt Pm9wdHMub25fZXJyb3IgPT0gQ09QWV9PTl9FUlJPUl9TRVRfTlVMTCkKIAkJCXsKKwkJCQkvKgor CQkJCSAqIFJlc2V0IGVycm9yIHN0YXRlIHNvIHRoZSBzdWJzZXF1ZW50IElucHV0RnVuY3Rpb25D YWxsU2FmZQorCQkJCSAqIGNhbGwgKGZvciBkb21haW4gY29uc3RyYWludCBjaGVjaykgY2FuIHBy b3Blcmx5IHJlcG9ydAorCQkJCSAqIHdoZXRoZXIgaXQgc3VjY2VlZGVkIG9yIGZhaWxlZC4KKwkJ CQkgKi8KIAkJCQljc3RhdGUtPmVzY29udGV4dC0+ZXJyb3Jfb2NjdXJyZWQgPSBmYWxzZTsKIAog CQkJCUFzc2VydChjc3RhdGUtPmRvbWFpbl93aXRoX2NvbnN0cmFpbnQgIT0gTlVMTCk7CkBAIC0x MDc1LDEzICsxMDgwLDE3IEBAIENvcHlGcm9tVGV4dExpa2VPbmVSb3coQ29weUZyb21TdGF0ZSBj c3RhdGUsIEV4cHJDb250ZXh0ICplY29udGV4dCwKIAkJCQllbHNlIGlmIChzdHJpbmcgPT0gTlVM TCkKIAkJCQkJZXJlcG9ydChFUlJPUiwKIAkJCQkJCQllcnJjb2RlKEVSUkNPREVfTk9UX05VTExf VklPTEFUSU9OKSwKLQkJCQkJCQllcnJtc2coImRvbWFpbiAlcyBkb2VzIG5vdCBhbGxvdyBudWxs IHZhbHVlcyIsIGZvcm1hdF90eXBlX2JlKHR5cGlvcGFyYW1zW21dKSksCisJCQkJCQkJZXJybXNn KCJudWxsIHZhbHVlIGluIGNvbHVtbiBcIiVzXCIgdmlvbGF0ZXMgbm90LW51bGwgY29uc3RyYWlu dCBvZiBkb21haW4gJXMiLAorCQkJCQkJCQkgICBjc3RhdGUtPmN1cl9hdHRuYW1lLCBmb3JtYXRf dHlwZV9iZSh0eXBpb3BhcmFtc1ttXSkpLAogCQkJCQkJCWVycmRhdGF0eXBlKHR5cGlvcGFyYW1z W21dKSk7CiAJCQkJZWxzZQogCQkJCQllcmVwb3J0KEVSUk9SLAotCQkJCQkJCWVycmNvZGUoRVJS Q09ERV9JTlZBTElEX1RFWFRfUkVQUkVTRU5UQVRJT04pLAotCQkJCQkJCWVycm1zZygiaW52YWxp ZCBpbnB1dCB2YWx1ZSBmb3IgZG9tYWluICVzOiBcIiVzXCIiLAotCQkJCQkJCQkgICBmb3JtYXRf dHlwZV9iZSh0eXBpb3BhcmFtc1ttXSksIHN0cmluZykpOworCQkJCQkJCWVycmNvZGUoRVJSQ09E RV9OT1RfTlVMTF9WSU9MQVRJT04pLAorCQkJCQkJCWVycm1zZygiY2Fubm90IHNldCBudWxsIHZh bHVlIGZvciBjb2x1bW4gXCIlc1wiIHdpdGggZG9tYWluICVzIiwKKwkJCQkJCQkJICAgY3N0YXRl LT5jdXJfYXR0bmFtZSwgZm9ybWF0X3R5cGVfYmUodHlwaW9wYXJhbXNbbV0pKSwKKwkJCQkJCQll cnJkZXRhaWwoIkNvbHVtbiBcIiVzXCIgZG9lcyBub3QgYWNjZXB0IG51bGwgdmFsdWVzLCBzbyBP Tl9FUlJPUiBTRVRfTlVMTCBjYW5ub3QgYmUgYXBwbGllZC4iLAorCQkJCQkJCQkJICBjc3RhdGUt PmN1cl9hdHRuYW1lKSwKKwkJCQkJCQllcnJkYXRhdHlwZSh0eXBpb3BhcmFtc1ttXSkpOwogCiAJ CQkJLyoKIAkJCQkgKiBXZSBjb3VudCBvbmx5IHRoZSBudW1iZXIgb2Ygcm93cyAobm90IGZpZWxk cykgd2hlcmUKZGlmZiAtLWdpdCBhL3NyYy90ZXN0L3JlZ3Jlc3MvZXhwZWN0ZWQvY29weTIub3V0 IGIvc3JjL3Rlc3QvcmVncmVzcy9leHBlY3RlZC9jb3B5Mi5vdXQKaW5kZXggNzIwMzQ3OTZhY2Eu LmQ5Y2M3YmY1ZjQ4IDEwMDY0NAotLS0gYS9zcmMvdGVzdC9yZWdyZXNzL2V4cGVjdGVkL2NvcHky Lm91dAorKysgYi9zcmMvdGVzdC9yZWdyZXNzL2V4cGVjdGVkL2NvcHkyLm91dApAQCAtNzk5LDEz ICs3OTksMTUgQEAgQ1JFQVRFIERPTUFJTiBkX2ludF9wb3NpdGl2ZV9tYXliZV9udWxsIEFTIGlu dGVnZXIgQ0hFQ0sodmFsdWUgPiAwKTsKIENSRUFURSBUQUJMRSB0X29uX2Vycm9yX251bGwgKGEg ZF9pbnRfbm90X251bGwsIGIgZF9pbnRfcG9zaXRpdmVfbWF5YmVfbnVsbCwgYyBpbnRlZ2VyKTsK IFxwc2V0IG51bGwgTlVMTAogQ09QWSB0X29uX2Vycm9yX251bGwgRlJPTSBTVERJTiBXSVRIIChv bl9lcnJvciBzZXRfbnVsbCk7IC0tZmFpbAotRVJST1I6ICBkb21haW4gZF9pbnRfbm90X251bGwg ZG9lcyBub3QgYWxsb3cgbnVsbCB2YWx1ZXMKK0VSUk9SOiAgbnVsbCB2YWx1ZSBpbiBjb2x1bW4g ImEiIHZpb2xhdGVzIG5vdC1udWxsIGNvbnN0cmFpbnQgb2YgZG9tYWluIGRfaW50X25vdF9udWxs CiBDT05URVhUOiAgQ09QWSB0X29uX2Vycm9yX251bGwsIGxpbmUgMSwgY29sdW1uIGE6IG51bGwg aW5wdXQKIENPUFkgdF9vbl9lcnJvcl9udWxsIEZST00gU1RESU4gV0lUSCAob25fZXJyb3Igc2V0 X251bGwpOyAtLWZhaWwKLUVSUk9SOiAgaW52YWxpZCBpbnB1dCB2YWx1ZSBmb3IgZG9tYWluIGRf aW50X25vdF9udWxsOiAic3MiCitFUlJPUjogIGNhbm5vdCBzZXQgbnVsbCB2YWx1ZSBmb3IgY29s dW1uICJhIiB3aXRoIGRvbWFpbiBkX2ludF9ub3RfbnVsbAorREVUQUlMOiAgQ29sdW1uICJhIiBk b2VzIG5vdCBhY2NlcHQgbnVsbCB2YWx1ZXMsIHNvIE9OX0VSUk9SIFNFVF9OVUxMIGNhbm5vdCBi ZSBhcHBsaWVkLgogQ09OVEVYVDogIENPUFkgdF9vbl9lcnJvcl9udWxsLCBsaW5lIDEsIGNvbHVt biBhOiAic3MiCiBDT1BZIHRfb25fZXJyb3JfbnVsbCBGUk9NIFNURElOIFdJVEggKG9uX2Vycm9y IHNldF9udWxsKTsgLS1mYWlsCi1FUlJPUjogIGludmFsaWQgaW5wdXQgdmFsdWUgZm9yIGRvbWFp biBkX2ludF9ub3RfbnVsbDogIi0xIgorRVJST1I6ICBjYW5ub3Qgc2V0IG51bGwgdmFsdWUgZm9y IGNvbHVtbiAiYSIgd2l0aCBkb21haW4gZF9pbnRfbm90X251bGwKK0RFVEFJTDogIENvbHVtbiAi YSIgZG9lcyBub3QgYWNjZXB0IG51bGwgdmFsdWVzLCBzbyBPTl9FUlJPUiBTRVRfTlVMTCBjYW5u b3QgYmUgYXBwbGllZC4KIENPTlRFWFQ6ICBDT1BZIHRfb25fZXJyb3JfbnVsbCwgbGluZSAxLCBj b2x1bW4gYTogIi0xIgogLS1mYWlsLCBsZXNzIGRhdGEuCiBDT1BZIHRfb25fZXJyb3JfbnVsbCBG Uk9NIFNURElOIFdJVEggKGRlbGltaXRlciAnLCcsIG9uX2Vycm9yIHNldF9udWxsKTsK --43332367b511260997b589a6a403621f5201438e216815667a8faaa6ff56--