Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vqZVB-00DRHX-2T for pgsql-hackers@arkaria.postgresql.org; Thu, 12 Feb 2026 16:25:14 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1vqZVA-009m2a-2f for pgsql-hackers@arkaria.postgresql.org; Thu, 12 Feb 2026 16:25:13 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vqZVA-009m2S-1h for pgsql-hackers@lists.postgresql.org; Thu, 12 Feb 2026 16:25:13 +0000 Received: from mail-yw1-x1133.google.com ([2607:f8b0:4864:20::1133]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1vqZV8-00000000JP3-1FZn for pgsql-hackers@lists.postgresql.org; Thu, 12 Feb 2026 16:25:12 +0000 Received: by mail-yw1-x1133.google.com with SMTP id 00721157ae682-790b7b3e594so501647b3.3 for ; Thu, 12 Feb 2026 08:25:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770913510; x=1771518310; darn=lists.postgresql.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=+PkiXKNYdIQAgLJJnAhHP9LKW7/85+e/6ozdiut1Tys=; b=i3Mw2fdlp8I+56wjT5c7h589y8RUgNZYto+x4xpqCT8J8r31pqkQGmdVEZAcZQIf3N sVY/rNE2DqHorXlbmuWi9Tl17QDz3qDvWQV+sk0PzRlHxoh6nlIK0PGK2zBttUAqASs3 SQHSdUOaV91TQQw1W3gRqJpERemt4B0g5aNtHBaJauZ4G7nFVYO5wGXprnYW+USuS0dW 3VP8I2C1pD9Yl+mtbpmQ4fz3qVbv7vOM77Stn+eXn0BhZhbybX3h0yWtgYyMN/WEhvSJ TOYCef4nN1pDoS8mWqFj7lvXnUCnMK6n/C7afyEa+xYFdu+PqiA/5viu61oaXLTjdP9i Q/Lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770913510; x=1771518310; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=+PkiXKNYdIQAgLJJnAhHP9LKW7/85+e/6ozdiut1Tys=; b=ajmCj2kQuxdykvuFcJc/+0MelSJsuItvSoBmni8fkcDQrZWM6SeFzS5OitrWmeipGm a+kwQJynEMr3MJ3kSOeT42CbjhXBXBinZIIMgZmtXoRo+wCB60SMfDBNgSuAuhRp86kp tLa/bg1qYX/iLLhh+YB5ZFx29XZEOxgQnhYzSVOckAWxevrwih55I8nvJkKVG8hul/2S eHbIUJxBS/lv/by4GW/B6jzVBM7qdrvTjPKdEsIIWzkc1APdtWpRCB/uHg1mE1pQ4hOD J2p5ZI3nf4ZSGldZgve2+ljGA3TcQGvN/jpMcVhve9ew2VROWQQtrXg8WPBrROMz5suC UWBg== X-Gm-Message-State: AOJu0Yy60HF6C/fxYnr/yi32ZJ/q92l9GxbMGol11daFBmONZyqMTgRS Z9O1EZOTNCxp0/dGlgygHw3yrZpZU/4mWKm4vdtSjzPV4P+qreeoGoBa X-Gm-Gg: AZuq6aJYxaxfQBsoHzXg4pOSmtEOKOK1+C4cliMchjSHq2U5R7wBqa7CBrWNADhMVJj hZkFSsXNZL33NNAPO1yn2sK7TiOP7ucJ6kxJFxGozwArMeHOPVdNp+iWetDZVVpeP+sc1l309Px +uYlC6VblnIsvU3bchGjjfpvbxntebFq1YuJpCNOKvTyoBsYZDKE8w8y4MWaAclzIIMfc7PTfCw z3HLDAvngsNwbjO8GnVDCfy5D0tLf5O0nlz6RS29xvnpq/648uZB0XzPljbvHMAwPhfOsyMrTfT ev6E9Th/3xHdRQmNs60BkNZ+8Z4tW/PpwwrT+n1SfATd9xAv9PAW/jG7lXzOfS6JzsVLN5DHV9Y zFPQE6IsYGYf530KdhWPSweTuZsXHohGQ7tJ/uh+z/Bv84JGIlL9yRGIksT2HSrGtyxnmnnU9m6 hGE8DOMohzVzs768wzsTTCpbwOm+Zuu4V3Rob874bDnrpBGw== X-Received: by 2002:a05:690c:5:b0:794:de8:cbd8 with SMTP id 00721157ae682-797375eb04amr39181107b3.19.1770913510306; Thu, 12 Feb 2026 08:25:10 -0800 (PST) Received: from localhost ([2804:14d:328a:a59c:2551:f0bd:33c7:95d2]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7966c267ba3sm47536487b3.48.2026.02.12.08.25.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Feb 2026 08:25:10 -0800 (PST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 12 Feb 2026 13:25:07 -0300 Message-Id: Cc: "pgsql-hackers@lists.postgresql.org" Subject: Re: COMMENTS are not being copied in CREATE TABLE LIKE From: "Matheus Alcantara" To: "Jim Jones" , "Fujii Masao" X-Mailer: aerc 0.21.0 References: <50f693ad-faec-4b1b-8de5-88dc90b236b4@uni-muenster.de> In-Reply-To: <50f693ad-faec-4b1b-8de5-88dc90b236b4@uni-muenster.de> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Thu Feb 12, 2026 at 12:33 PM -03, Jim Jones wrote: > > > On 12/02/2026 16:08, Fujii Masao wrote: >> On Thu, Feb 12, 2026 at 11:36=E2=80=AFPM Matheus Alcantara >> wrote: >>> The patch fix the issue and it seems correct to me. > > Thanks for the review! > >> The documentation [1] states that INCLUDING COMMENTS copies comments for >> the copied columns, constraints, and indexes. It does not mention copyin= g >> comments on the table itself. Therefore, not copying table comments with >> INCLUDING COMMENTS does not appear to be a bug. That is, the proposed pa= tch >> seems more like an improvement than a bug fix. > > Hmm, it seemed so obvious to me that I didn=E2=80=99t look more closely a= t the > documentation :)=20 >=20 Yeah, me too. I even checked if column comments was being created, but I still assume that table comments should also be copied. > Although I struggle to see the rationale for not > copying a table=E2=80=99s comment in a CREATE TABLE LIKE ... INCLUDING CO= MMENTS > statement, I have to agree that the documentation is quite clear about > this limitation, and therefore it cannot really be considered a bug. > That said, it may well be worth considering for a future release. > > What are your thoughts? > +1 for having this as a feature on a future release. -- Matheus Alcantara EDB: https://www.enterprisedb.com