Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Tue, 24 Feb 2026 16:32:15 -0300
Message-Id: <DGNFXVTPKNX4.2D61JYJY21QJ1@gmail.com>
From: "Matheus Alcantara" <matheusssilv97@gmail.com>
To: "Ilia Evdokimov" <ilya.evdokimov@tantorlabs.com>, "Tatsuya Kawata"
 <kawatatatsuya0913@gmail.com>, "David Geier" <geidav.pg@gmail.com>
Cc: "Chengpeng Yan" <chengpeng_yan@outlook.com>,
 "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Subject: Re: Hash-based MCV matching for large IN-lists
References: <7db341e0-fbc6-4ec5-922c-11fdafe7be12@tantorlabs.com>
 <c5c7cf37-218d-405a-8dde-520aa313830a@gmail.com>
 <988e3168-6096-488a-bb42-787e1e8c21a4@tantorlabs.com>
 <21FF6A0B-886F-4132-B6A6-0F4E934B4CEE@Outlook.com>
 <8ee9d903-bb13-434c-8145-b3769bf2b3cb@tantorlabs.com>
 <ff7d491d-f084-4935-8417-c0b7285cdd89@gmail.com>
 <CAHza6qdAH99C0xa27YDTixiNVFa99j90QYquUPAxL0JwahmggA@mail.gmail.com>
 <9e3054ae-1c5d-46dd-9b6a-7fb67764b076@tantorlabs.com>
In-Reply-To: <9e3054ae-1c5d-46dd-9b6a-7fb67764b076@tantorlabs.com>
Archived-At: <https://www.postgresql.org/message-id/DGNFXVTPKNX4.2D61JYJY21QJ1%40gmail.com>
Precedence: bulk

Hi, thanks for working on this!

On Wed Feb 18, 2026 at 9:48 AM -03, Ilia Evdokimov wrote:
> I've fixed all the comments raised above and updated the v5 patch.
>

Here are some comments regarding v5 patch:

On scalararraysel() we have:

+				ReleaseVariableStats(vardata);
+
+				if (s1 >=3D 0.0)
+					return s1;

I'm wondering if we also should call ReleaseVariableStats() on the early
return?

+					if (!useOr && elem_nulls[i])
+					{
+						pfree(elem_values);
+						pfree(elem_nulls);
+						pfree(elem_const);
+
+						return (Selectivity) 0.0;
+					}

------------------

On scalararray_mcv_hash_match() free_attstatsslot() is called only on
if (have_mcvs && OidIsValid(hashLeft) && OidIsValid(hashRight)),
perhaps it should be moved outside the if condition?

+	if (have_mcvs && OidIsValid(hashLeft) && OidIsValid(hashRight))
+	{
+       ...

+		MCVHashTable_destroy(hashTable);
+		free_attstatsslot(&sslot);
+	}
+
+	return selec;


------------------

typo: "all elements are const"

+ *              array is NULL if all elemnets is const.

------------------

It's worth adding on scalararray_mcv_hash_match() an early return when
num_elems =3D=3D 0? I imagine that this can happens, e.g "WHERE a =3D
ANY(array[]::int[]);". In this case the function should still execute
completely?

--
Matheus Alcantara
EDB: https://www.enterprisedb.com