Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w2S6A-000IqF-1B for pgsql-hackers@arkaria.postgresql.org; Tue, 17 Mar 2026 10:56:30 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1w2S69-000adC-0C for pgsql-hackers@arkaria.postgresql.org; Tue, 17 Mar 2026 10:56:29 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w2S68-000acw-22 for pgsql-hackers@lists.postgresql.org; Tue, 17 Mar 2026 10:56:28 +0000 Received: from mail-ej1-x629.google.com ([2a00:1450:4864:20::629]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1w2S65-00000000AiN-0SxV for pgsql-hackers@postgresql.org; Tue, 17 Mar 2026 10:56:27 +0000 Received: by mail-ej1-x629.google.com with SMTP id a640c23a62f3a-b9793fa5371so357256566b.2 for ; Tue, 17 Mar 2026 03:56:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jeltef.nl; s=google; t=1773744985; x=1774349785; darn=postgresql.org; h=in-reply-to:references:from:to:subject:cc:message-id:date :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=oG2Nzgu97TWor5dzHOy2ZiZ42n3GgbjuGxnYzopmJHE=; b=Za4Ljmpk9zaMs2x7meSjuTGeX6r0xhhWO8KsWpElqLBJiLtJr7+4lnKmZFu7UI0xEY NKLAt/AFZ/git29cTB/ge3DY4DXH2CLVxQr+1yMOhnKAVkNvJOA56otFLrRq+ICMJANI jbLwcnmepUIPqyXe7wZOPsJmTsHH8v5PKdLv865PM7FHmmQYOr25z8CFiQLuJGKZ61jB OTBgRm3JZ0+m6PL2eeC5Mp+Nun+7D2wVXP1NmmWSpq6zuLWviEo4EVz/wSmnsyxZOsiL Mi2HpOAPONt9fykQDteiuXnhWWtlYBqhc7mY04xnScWVWyQoPgTgIwEe+JhgKupS+w46 7+3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773744985; x=1774349785; h=in-reply-to:references:from:to:subject:cc:message-id:date :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=oG2Nzgu97TWor5dzHOy2ZiZ42n3GgbjuGxnYzopmJHE=; b=DwE/RiRqwS8fQFQ0FeOnAgV0JjOBEvoXu0bUBLAF0JOrmyPIl1zBZYWoP9IeVNy2jR mxPMZ+ULYBinpN8t2oIQUhd4Z3laGrqLbVW0laZ4NZQ0rKN71Ci5Jezu14R+25E0j4rb G8QtiQvqcOijIwmqkq0lrxmhGup6pugJGBu7T1s+Gpag4l5zvBpI2Wvc5Lve672GEfuf Ti9RpPOBcA+uppf4ZTnONXEZGHSsWVYtFNSb1jj77D19/5trOlYCtvGImyygj17V7F1T sWnd5IeINhspqvQphJ+U80+eUQf8x5LNTmzxcLNpRpvfuJ++6XmwUoKv1sTJg+nmdNTu wYNQ== X-Forwarded-Encrypted: i=1; AJvYcCXkBgnipzGxH4FJu/qM2yO441kxlPBs8BbpYf87B04R4pMgSfAliXNU+mIR4gXPl+T/XRpHi6hlqvJvzI1g@postgresql.org X-Gm-Message-State: AOJu0YwjC1KN1CA8ZrcLbtHGPYiTYXijTWjaM28+P18eDRHXLiOxqFE7 yKNsXlDLBLbVNLaFhaslDTDlfjzWf/TlZhNGCGf+KMbB80rI9235vuTBFXq8taamZcs= X-Gm-Gg: ATEYQzzzRP0CDkNBNttdjxdaYH98rGoNmn+NUKWe6oUR2qU2tCIHG70ebbwRvXxWGTN 2RmO0nOunbnwlZfpjg2QKu72QDyNV4fnboH/Y31pgvb/paXfQ9dZ5sbDxJJ73WYYNQYfVshvMwb +V3uBz6qczCygUE9OvvGSmY2NaUBhLy/fgO2JqEf7WuZ700vmFLAMBMpdWzrkvUPtYtKk42N4ld Ib5UyQ0iLLT3UwmwnP0fJqgzgEMlkXovzjoaiXRjA7vUoZlHhMh/vCv3Ly1vllG2tpt7rg2V+3f 2jtGx/ehcrrMuKKOKOUqPUQljHZ1aBmgjvcaIe3O+F8nwy35j9LumC48afHVqMOdeMMXFQ6+w/L /VbyOuSVXhwpVqh6aZslIQOkPPpuhDbCGcSMCaVd+ilfizx5+WoHybHtaMsDVCzN/WyR3Gph/pH gGW+q800DK3I3ZduL9h66Avwu+/SDgv2/fxoGOiTSCC+PeKxYL X-Received: by 2002:a17:907:990a:b0:b97:1d24:bfe1 with SMTP id a640c23a62f3a-b976502b62bmr841935166b.22.1773744985039; Tue, 17 Mar 2026 03:56:25 -0700 (PDT) Received: from localhost (145-53-221-196.fixed.kpn.net. [145.53.221.196]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b976c86ce02sm726507566b.0.2026.03.17.03.56.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Mar 2026 03:56:24 -0700 (PDT) Content-Type: multipart/mixed; boundary=f84718bbd85319a2fb1c985ba15be663f19c197e99609752a51725e99660 Mime-Version: 1.0 Date: Tue, 17 Mar 2026 11:56:24 +0100 Message-Id: Cc: "Peter Eisentraut" , "pgsql-hackers" Subject: Re: Change copyObject() to use typeof_unqual To: "Tom Lane" , "Masahiko Sawada" From: "Jelte Fennema-Nio" X-Mailer: aerc 0.20.1-31-gf6db7c329ce0 References: <92f9750f-c7f6-42d8-9a4a-85a3cbe808f3@eisentraut.org> <2191112.1773612810@sss.pgh.pa.us> <000e196b-3eb3-4ff4-a5e3-f535e6db2f91@eisentraut.org> <14523.1773675135@sss.pgh.pa.us> <314254.1773715169@sss.pgh.pa.us> In-Reply-To: <314254.1773715169@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --f84718bbd85319a2fb1c985ba15be663f19c197e99609752a51725e99660 Content-Type: multipart/alternative; boundary=f17456dd65ae211a26695fddc9bcf3ec1887c15973621c03fa16313febd8 --f17456dd65ae211a26695fddc9bcf3ec1887c15973621c03fa16313febd8 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Content-Type: text/plain; charset=UTF-8; format=Flowed On Tue Mar 17, 2026 at 3:39 AM CET, Tom Lane wrote: > While this version of clang doesn't like typeof_unqual, it does take > __typeof_unqual__. So maybe we were premature to decide that we > could prefer the typeof_unqual spelling. Hmmm, that makes sense. How about this patch to at least keep the all the logic related to this in one place? I was able to reproduce this error using the following flags, and this fixes the issue for me. CC=3Dclang-21 CXX=3Dclang++-21 CFLAGS=3D-std=3Dc23 BITCODE_CFLAGS=3D-std=3D= gnu17 CLANG=3Dclang-19 LLVM_CONFIG=3Dllvm-config-19 --f17456dd65ae211a26695fddc9bcf3ec1887c15973621c03fa16313febd8-- --f84718bbd85319a2fb1c985ba15be663f19c197e99609752a51725e99660 Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=v1-0001-Hardcode-typeof_unqual-to-__typeof_unqual__-for-c.patch Content-Type: text/x-patch; charset=utf-8; name=v1-0001-Hardcode-typeof_unqual-to-__typeof_unqual__-for-c.patch RnJvbSBiMDI2MWFiY2U0NWZmMTQ0YmM2ZjhjOWQ3OTc5ODRmODM3N2ZjZmUwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKZWx0ZSBGZW5uZW1hLU5pbyA8cG9zdGdyZXNAamVsdGVmLm5s PgpEYXRlOiBUdWUsIDE3IE1hciAyMDI2IDExOjM0OjE2ICswMTAwClN1YmplY3Q6IFtQQVRDSCB2 MV0gSGFyZGNvZGUgdHlwZW9mX3VucXVhbCB0byBfX3R5cGVvZl91bnF1YWxfXyBmb3IgY2xhbmcK CkEgbmV3IGF0dGVtcHQgd2FzIG1hZGUgaW4gNjMyNzVjZTg0ZDIgdG8gbWFrZSB0eXBlb2ZfdW5x dWFsIHdvcmsgb24gYWxsCmNvbmZpZ3VyYXRpb25zIG9mIENDIGFuZCBDTEFORy4gVGhpcyByZS1p bnRyb2R1Y2VkIGFuIG9sZCBwcm9ibGVtCnRob3VnaCwgd2hlcmUgQ0xBTkcgd291bGQgb25seSBz dXBwb3J0IF9fdHlwZW9mX3VucXVhbF9fIGJ1dCB0aGUKY29uZmlndXJlIGNoZWNrIGZvciBDQyBk ZXRlY3RlZCBzdXBwb3J0IGZvciB0eXBlb2ZfdW5xdWFsLgoKVGhpcyBmaXhlcyB0aGF0IGJ5IGFs d2F5cyBkZWZpbmluZyB0eXBlb2ZfdW5xdWFsIGFzIF9fdHlwZW9mX3VucXVhbF9fCnVuZGVyIGNs YW5nLgotLS0KIHNyYy9pbmNsdWRlL2MuaCB8IDMgKysrCiAxIGZpbGUgY2hhbmdlZCwgMyBpbnNl cnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvc3JjL2luY2x1ZGUvYy5oIGIvc3JjL2luY2x1ZGUvYy5o CmluZGV4IDg5ODdhMTIxZDZhLi5mZDZiMDkzYmIzYSAxMDA2NDQKLS0tIGEvc3JjL2luY2x1ZGUv Yy5oCisrKyBiL3NyYy9pbmNsdWRlL2MuaApAQCAtNDQ0LDYgKzQ0NCw5IEBAIGV4dGVybiAiQysr IgogI2lmIGRlZmluZWQoX19jbGFuZ19fKQogI2lmIF9fY2xhbmdfbWFqb3JfXyA8IDE5CiAjdW5k ZWYgSEFWRV9UWVBFT0ZfVU5RVUFMCisjZWxzZQorI3VuZGVmIHR5cGVvZl91bnF1YWwKKyNkZWZp bmUgdHlwZW9mX3VucXVhbCBfX3R5cGVvZl91bnF1YWxfXwogI2VuZGlmCiAjZW5kaWYJCQkJCQkJ LyogX19jbGFuZ19fICovCiAKCmJhc2UtY29tbWl0OiAxODJjZGY1YWVhZjdiMzRhMjg4YTEzNWQ2 NmYyODkzZGMyODhhMjRlCi0tIAoyLjUzLjAKCg== --f84718bbd85319a2fb1c985ba15be663f19c197e99609752a51725e99660--