Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Wed, 22 Apr 2026 07:53:04 -0300
Message-Id: <DHZMLEQ2VMIO.2F3VN1UMHHQ8G@gmail.com>
Cc: "Dmitry Koval" <d.koval@postgrespro.ru>, "pgsql-hackers"
 <pgsql-hackers@postgresql.org>
Subject: Re: MERGE PARTITIONS and DEPENDS ON EXTENSION.
From: "Matheus Alcantara" <matheusssilv97@gmail.com>
To: "Alexander Korotkov" <aekorotkov@gmail.com>
References: 
 <CALdSSPjXtzGM7Uk4fWRwRMXcCczge5uNirPQcYCHKPAWPkp9iQ@mail.gmail.com>
 <31d04a1b-c0cb-4e6f-a344-0db048a3b673@gmail.com>
 <DHMZH5ILXV80.36CLMWXU18J3@gmail.com>
 <414c3430-77a9-438e-9dc0-c66033f6be63@postgrespro.ru>
 <DHURZGPYE4B4.2XG5GT4TQ72U4@gmail.com>
 <CAPpHfdvQSmRAHu1BRTVcvgons_Smt0QW+mLP4np=QxG==WyFAg@mail.gmail.com>
 <DHYV404JC894.P813UU2Y36L1@gmail.com>
 <CAPpHfds2NsGvpi4fK-xBDk9S=ZY8FEsG-a3z7m_cRSJhn5GKvQ@mail.gmail.com>
 <271ebb35-8d8f-41c3-9d95-5c1e5b416216@gmail.com>
 <CAPpHfdt66RjWZnUakTZKk6eQ=xVrscfp9HAg8xXnxjnsgHuF-g@mail.gmail.com>
In-Reply-To: 
 <CAPpHfdt66RjWZnUakTZKk6eQ=xVrscfp9HAg8xXnxjnsgHuF-g@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/DHZMLEQ2VMIO.2F3VN1UMHHQ8G%40gmail.com>
Precedence: bulk

On Tue Apr 21, 2026 at 4:35 PM -03, Alexander Korotkov wrote:
>> > I've revised the patch.
>> > 1) collectPartitionIndexExtDeps() is rewritten().  Now it works in
>> > three phases: collect, sort, compare.  The comparison phase requires
>> > strict equivalence of dependencies and doesn't depend on the order.
>> > The complexity is now O(n * log(n)), which I think is acceptable.
>> > 2) PartitionIndexExtDepEntry struct now have indexOid.  So, on
>> > conflict error contains both partition index names.
>> > 3) Tests moved to
>> > src/test/modules/test_extensions/sql/test_extdepend.sql where
>> > test_ext3/test_ext5 extensions are available.
>> > 4) More tests for different scenarios.
>> >
>> > Could you, please, review this changes?
>> >
>>
>> I think that you miss to include the patch?
>
> Yep, here it is.
>

Thanks for the patch. It looks good to me, and I confirm that it fix the
issues that I miss on the previous version.

--
Matheus Alcantara
EDB: https://www.enterprisedb.com