Feedback-ID: idd01497b:Fastmail
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Tue, 05 May 2026 16:01:04 +0000
Message-Id: <DIAVABAZIYEG.371CCRMOFWC6Z@partin.io>
Cc: "pgsql-hackers" <pgsql-hackers@lists.postgresql.org>
Subject: Re: Cleanup: Replace sscanf with strtol/strtoul in snapmgr
To: "Amul Sul" <sulamul@gmail.com>
From: "Tristan Partin" <tristan@partin.io>
References: 
 <CAAJ_b97mG=6ybUYE8nQyDfKkhaxTCD8rE8s6L8efNmqHaUYNWQ@mail.gmail.com>
 <DIA0EJH2KL60.29M1F14V8I9V7@partin.io>
 <CAAJ_b974KcAQ=XMBfw-iy2tnbwNk9YnSA5XcQctf7N0GUSDRQA@mail.gmail.com>
In-Reply-To: 
 <CAAJ_b974KcAQ=XMBfw-iy2tnbwNk9YnSA5XcQctf7N0GUSDRQA@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/DIAVABAZIYEG.371CCRMOFWC6Z%40partin.io>
Precedence: bulk

On Tue May 5, 2026 at 2:24 AM CDT, Amul Sul wrote:
> On Mon, May 4, 2026 at 9:19=E2=80=AFPM Tristan Partin <tristan@partin.io>=
 wrote:
>>
>> On Mon Apr 20, 2026 at 12:07 AM CDT, Amul Sul wrote:
>> The patch generally looks good. One comment:
>>
>> > @@ -1359,17 +1365,36 @@ parseVxidFromText(const char *prefix, char **s=
, const char *filename,
>> >  {
>> >         char       *ptr =3D *s;
>> >         int                     prefixlen =3D strlen(prefix);
>> > +       long            lval;
>> > +       unsigned long ulval;
>>
>> Perhaps better variable names would be procNumber and
>> localTransactionId.
>>
>
> Thanks, Andreas and Tristan, for the review !
>
> I have renamed the variables as suggested but used the shorter forms
> procno and xid instead of procNumber and localTransactionId. I also
> applied similar changes to parseXidFromText (changing val to xid), but
> kept val in parseIntFromText since it seems to be more appropriate for
> a generic integer value.
>
> Updated patch attached.

New patch looks good to me. I can confirm that the only changes in the=20
new version of the patch are the variable names.

--=20
Tristan Partin
PostgreSQL Contributors Team
AWS (https://aws.amazon.com)